Received-SPF: pass (google.com: domain of linux-kernel+bounces-72207-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Huang Shijie <shijie@os.amperecomputing.com>
To: kuba@kernel.org
Cc: patches@amperecomputing.com,
	davem@davemloft.net,
	horms@kernel.org,
	edumazet@google.com,
	ast@kernel.org,
	dhowells@redhat.com,
	linyunsheng@huawei.com,
	aleksander.lobakin@intel.com,
	linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org,
	cl@os.amperecomputing.com,
	Huang Shijie <shijie@os.amperecomputing.com>
Subject: [PATCH] net: skbuff: allocate the fclone in the current NUMA node
Date: Tue, 20 Feb 2024 10:18:04 +0800
Message-Id: <20240220021804.9541-1-shijie@os.amperecomputing.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?zACM/W6grIwbFC/FJaxXUnOzeUifkT4du3h15UZPpxqrjcHIaYqt563ifZTd?=
 =?us-ascii?Q?xyla73MscHns6p9/+CXfefHnj0TV3+oRUqQv72Rg+VHh+Bi/zAXeNRr9peCT?=
 =?us-ascii?Q?Qjl9PoHhkqGs1Nl60ZU4LzzU5kpA5uxp+aiNkSyZaR1UIo9352mpg0enkUVR?=
 =?us-ascii?Q?8UrD1cH8M1XZsbIMv9BsDSQi7ToYBX2xzPI4F2u0+czI09nrWHeuaha1L8sh?=
 =?us-ascii?Q?+MkXLD0NfvBVLnQGdbspitdiwmTOe8mJelx2G94lkhH/GR/TE6jQHR2gfMQI?=
 =?us-ascii?Q?RdZx28XGnFn0Y/INJ/R9yOXz/Jtrt6M5EY4IIhY5nEkXxHlU794dWJLMhinb?=
 =?us-ascii?Q?JDHcP9kIFN54RQLRHQdu9bbym1m7oXbis/ZF1WhErRuanzLLZB7QUHdHTy1D?=
 =?us-ascii?Q?Ef27Y08pGzpc2Hr/kXplQ6y6KMqP7hO69AUzVd6jpXLWl6npok6gmBbzPE4a?=
 =?us-ascii?Q?ajclaPYGsxHbmGTHkyVlUYZ1TY8j76zgPSTdmKY6wDRv/LoVR3HmR0r6lKS+?=
 =?us-ascii?Q?a8QY6+bFAgXf49LsRaslfcR/FVjS9q7PkuV0LHYS/K6zTRzbnWi1ZZg1Ef+0?=
 =?us-ascii?Q?3q7da+jlEmh/bcq+60WX4Q8DEw6ErcS7JtgQi6fWO0QQARo9KUYif3xWjLJ5?=
 =?us-ascii?Q?1oW9quhrPMB8QC55d7b2U1XKMISa8IqeTppYQpdxH0JiOWbxkmD1Od2rv4U3?=
 =?us-ascii?Q?NFPFodW7lrG5/CMa1yyYIIfqyg4uXLBSN6FwkkleIjc+ed5kUs+AnDsCcR/W?=
 =?us-ascii?Q?6FOpsswyt5Rkr5Oi1SYrNY8ss37I5FCF9/ILrrtn9DgMmcsBmI2+cBrebP4E?=
 =?us-ascii?Q?nIV30VOzMzxZGlON1qoNTPjZp8UZ7ijthwejvgQ2dez8cx6JvFd2Gm/6niGM?=
 =?us-ascii?Q?vZz969OSc2t05UfUoKspyqbEWAtKGDm3iJ3I1Ypnc+Dg0oP8tbnd7aRdaGlS?=
 =?us-ascii?Q?ckww4kUN+pm/0wsTMQ3awRw/hqtsnZkyMLzXtm7tLajjF4mSnIXYbJFZctzO?=
 =?us-ascii?Q?nW9+uK/RyLKUskMXbq3a7Zx5KBmKKsYEnxIDwgv4eFQvkO4yTzNAYl0hfZF1?=
 =?us-ascii?Q?rCojpMpYG4OrK/48nHfDCO1uI6wYFUcNxz1+LkrRpEh7hSEbQcLAGLm+88qu?=
 =?us-ascii?Q?90tv95QuvlxW9y+rzJoTpi3lZ/pBnRVy2IbQkXuGk6jqZ9n4aev8Au+2zF06?=
 =?us-ascii?Q?szoSDzIt3v4RtR4YeQFdzkUW0amSl+NW/yjsYNorKKRwfyjnG5FyhZaHUFaw?=
 =?us-ascii?Q?nuJnPzytQM8V6ZdwY1zVUjk+flk1i5HrXOKRiV6hfoK2Bp+yU1u8+sto1ype?=
 =?us-ascii?Q?EgqWWAjXPpN05leBXJ6UbI1yVVTBv7R9azLSAjISzfoHvq2mSjtnLBcJI75P?=
 =?us-ascii?Q?0x+dBLjZKpDun7JBpVW1gP18Lyw93XxeRbK9ed/23y52e6+w73CC7q8S5xTw?=
 =?us-ascii?Q?pz8IuBfoL3fp3kXfy9QIc5qNSpaclTQE9YPb5XF2S7FqUUA5vC/CFrWYB+lX?=
 =?us-ascii?Q?GMlRFP+bfepa/7COGcXyi4mY9qe09FQH/+LS09AdHiShSMujd9Ix/AsqiCVT?=
 =?us-ascii?Q?YuEEZy/LpN47UDpgmZ5KbXjSXNhRnalfmHowtHOxZh5kLZ1CIyK86nxNAXVM?=
 =?us-ascii?Q?eg=3D=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c6d04598-3016-4484-11a2-08dc31ba3c5f
X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7975.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 02:18:32.9164
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: E69ykqQ7vAnjUe7N06L9pbMofuEdE8gzlwmONBjgEPNI9kH0bzGz0Eo0zqzay5b0lg2WSbxPHIzO/tUyu/NCNz2Y82+WlX/CqCraGz4d9lI2mhhXbxBV4aKpD5efGWna
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR01MB6179

The current code passes NUMA_NO_NODE to __alloc_skb(), we found
it may creates fclone SKB in remote NUMA node.

So use numa_node_id() to limit the allocation to current NUMA node.

Signed-off-by: Huang Shijie <shijie@os.amperecomputing.com>
---
 include/linux/skbuff.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 2dde34c29203..ebc42b2604ad 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -1343,7 +1343,7 @@ static inline bool skb_fclone_busy(const struct sock *sk,
 static inline struct sk_buff *alloc_skb_fclone(unsigned int size,
 					       gfp_t priority)
 {
-	return __alloc_skb(size, priority, SKB_ALLOC_FCLONE, NUMA_NO_NODE);
+	return __alloc_skb(size, priority, SKB_ALLOC_FCLONE, numa_node_id());
 }
 
 struct sk_buff *skb_morph(struct sk_buff *dst, struct sk_buff *src);
-- 
2.40.1