Received-SPF: pass (google.com: domain of linux-kernel+bounces-72243-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 19 Feb 2024 19:05:20 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Byungchul Park <byungchul@sk.com>
Cc: "Huang, Ying" <ying.huang@intel.com>, mingo@redhat.com,
 peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org,
 dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com,
 mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com,
 linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com
Subject: Re: [PATCH v4] sched/numa, mm: do not try to migrate memory to
 memoryless nodes
Message-Id: <20240219190520.b5e373273ec743aacbad263b@linux-foundation.org>
In-Reply-To: <20240220015343.GD65758@system.software.com>
References: <20240219041920.1183-1-byungchul@sk.com>
	<87o7ccrghz.fsf@yhuang6-desk2.ccr.corp.intel.com>
	<20240219174508.bc6256248a163c3ab9a58369@linux-foundation.org>
	<20240220015343.GD65758@system.software.com>
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 20 Feb 2024 10:53:43 +0900 Byungchul Park <byungchul@sk.com> wrote:

> > > IIUC, you will use patch as fix to the issue in
> > > 
> > > https://lore.kernel.org/lkml/20240216111502.79759-1-byungchul@sk.com/
> > > 
> > > If so, we need the Fixes: tag to make it land in -stable properly.
> > 
> > Yes, this changelog is missing rather a lot of important information.
> 
> This is not the root cause fix any more but just optimization.

It would have been helpful to have told us this in the changelog :(

> That's
> why I didn't add Fixes: tag and cc stable@vger.kernel.org in here.
> 
> Instead, I added Fixes: tag and cc'ed stable@vger.kernel.org in the real
> fix patch. check the following link please:
> 
> https://lore.kernel.org/lkml/20240216111502.79759-1-byungchul@sk.com/

But doesn't this patch "sched/numa, mm: do not try to migrate memory to
memoryless nodes" also fix the bug?  Do we truly need both?