Received-SPF: pass (google.com: domain of linux-kernel+bounces-72315-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <95a87f90-f82d-f146-110e-1e23cd8d8b24@oppo.com>
Date: Tue, 20 Feb 2024 12:14:08 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH 0/2] Support kshrinkd
To: Matthew Wilcox <willy@infradead.org>
Cc: akpm@linux-foundation.org, david@redhat.com, osalvador@suse.de,
 linux-mm@kvack.org, linux-kernel@vger.kernel.org, v-songbaohua@oppo.com,
 gregkh@google.com, tkjos@google.com, surenb@google.com
References: <20240219141703.3851-1-lipeifeng@oppo.com>
 <ZdOG-135dLP0IeU8@casper.infradead.org>
 <a642d9dc-6d48-016c-7007-c08ce8933d18@oppo.com>
 <ZdQUmWxYuuP24w_1@casper.infradead.org>
From: =?UTF-8?B?5p2O5Z+56ZSL?= <lipeifeng@oppo.com>
In-Reply-To: <ZdQUmWxYuuP24w_1@casper.infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?R1NsMWN1ZjdMQlZ6K3d0Y3NNT2NiN0dHS1ZIekRjVHNKMXdmeVNsYjQyZ2tR?=
 =?utf-8?B?VFpCeGRYZmRyWG94SDcwcnhhWDRFK2lzS3NxcmllOXlUNGk5V0taMjlJc1Za?=
 =?utf-8?B?SHovUlVEaFJiYzdvNTBLY1hLdlJoWVpWbzFvNGtkeTBaRUtBQUtpR3pnNTYz?=
 =?utf-8?B?SWRyRlIyWXY1U0lQOVpHSFhMVVR3S1dueWpQbkJRSWNGckJKa0FhYzFLTzBC?=
 =?utf-8?B?TzB5dk9HMFB4bzljVDhJb3dtWlJrbWZhUEF5NjZ6MUNSZDNXdzF6OVIweFNk?=
 =?utf-8?B?MTFreWV3cXNkdFd4d2RoR1k0QWVhZTNab09YZjVnZWNBcG9kWS83QkY2N3lQ?=
 =?utf-8?B?NFlva3lHaEdDVXFHZTl2YVFWdzVrenJBM2N3ZkxEeW9JblZqd09XaERZZzdI?=
 =?utf-8?B?TjQwL1RKbUhKTXZ3d1NWdXgyQ2IxazhFcU94R3JNZ0x2Zi8vdzdpbFp1MFBi?=
 =?utf-8?B?ektnUkJlVXgxK252M09lQlZuM0ZCYXVpeURvSGp6Vy9OTTFIcGZ5cFdIM0dV?=
 =?utf-8?B?N090M0J2alVtb3NzZ3pDNDI1alplRFVScVVqY3o3UVlIYm5nMEUrSnBCYXh1?=
 =?utf-8?B?UlE0NnVYS3JZUmJhWEV3SVZDVHlVSGh5UkVSdEhad3lyWmtTSEE1VzhwRGd2?=
 =?utf-8?B?N3UxZElPa2RHTy9QNmxnN2VwSG5ZSHY3NmRLNGRyWHAxbWtzejVLM2VUUTZN?=
 =?utf-8?B?TjFQNTVIdThOemo5eFMweUo2R3E4VHR4UVU3WHJFQ2Q5aTlTOTJ1ZS9DdzBl?=
 =?utf-8?B?Y1Zsc1p6MDhOOHp3YWg5Nzh5UEFBVUNLYktsUklTN3ZpNG9Jc0kwK0VON1J1?=
 =?utf-8?B?U05iZmdhRERNVzJncVdLSjBDVDFrYmxRNHRRcmJkbk9OMDQ4S2ZNUk5pa1VJ?=
 =?utf-8?B?QXBFaGJWR0liSlRlQmZvdmN1bG5Fa00wdllvUWY2a1Bzd0s3U0ExRHAzZWRt?=
 =?utf-8?B?MkUxeHk1djhRTFlGWXlxYmpIZGZoVENWNUViakR2WU43NjNsVVlSZ3JlNmVh?=
 =?utf-8?B?dTJ4K0gyVTRuK1Nwdm1nQTdUd1FTVWpJcmpSQmhvM0ZWVS9xRHBBc2Y0aUpr?=
 =?utf-8?B?cjVuNUo2eHFzNjA2WVYwczlSRXNMT1NOakRGSW95bXhhYXo1RzFvemZYbHBn?=
 =?utf-8?B?QUh0UVYvM2VUUENnUjAxSGd1anJaU281RG1LUlc4bnpYNytPQldEZnJKZDlw?=
 =?utf-8?B?UEhybnVDRW9rbUwzQ2VDcWhmMUM4L2FZa1MyYXhJenJRMjVTNGtuSnVML1lq?=
 =?utf-8?B?ZFBtZGViU05MUHBtTEdZMkN3OE5PN3VlRXhSQ0hJUVo4bk5DaldCejVxLyt1?=
 =?utf-8?B?V2MyeXIrVHBuQWRyaS9Ca2d5UCsyd04wSzNwTG1yM2VnaExLWlhNZUZnclND?=
 =?utf-8?B?MWUwNEtrOEhuZkRDeXh6ZGZKcHRSY2sxNlFqMW1xWER0NjBiMEdtclE4SE40?=
 =?utf-8?B?WWg4SWlhVThRVm9xWjE4TmFIWWpyKzlOL2lwQzVkYm1hS3Q4K01jMUkzbWpt?=
 =?utf-8?B?Q042UmU4YnZ6emp3cVFBa0JWS0FrbW1nVDRiMGVsazRXNTJrMFowVCswcUQ1?=
 =?utf-8?B?OVpLK3I5WVBzeElvVWt0ZXlBd05OSlhrOUtMYXdhOHV4TGhiRG11ZzFtSy9z?=
 =?utf-8?B?QnlJd0cvbmtON0FDVi9BVVVCdW1rektFRXl2Nmo2TVBqSXovTUFvOGYzYmth?=
 =?utf-8?B?VHFLdlpXbDlHanhmZVYzODZwZXhHczFocVZScGM0c1hLS2VaVk9RV1lmdmJQ?=
 =?utf-8?B?Rjl0aHVveGpyZjgwaE90UkN6QkdHNjJiRXo3VHgrcktlTHJLSGhYZk02TU9U?=
 =?utf-8?B?dHNjNmg3ZnJRQWxqYU9nMjJMYnJZT1U4bHdiSERPSmxqeVZBb0JVMEJZeGFP?=
 =?utf-8?B?NE1QK3l2OTdYR1ZpbS9mUUtXV3JHUW5RVVg1V0s4WFBUSTlTZ3dVOTc3Wjcr?=
 =?utf-8?B?TXY4Zkl4VlV5RXdzRGdYU1FHNVRaeE1jUHJZd21ELytwUkx1YWhaUUM4Y2J5?=
 =?utf-8?B?aFUvT1REdzBZQng4V1VIak1PWWlUU0JxZDBYb05jK2UrT1M2bVo1cnlJL1Bs?=
 =?utf-8?B?b0NMMGtqT3RjSWRrVUxvZHUvNVExQnhNdml0WnJiM0ZhMzJqSDU3VEFXSVBl?=
 =?utf-8?B?b2RUTHM5SXpyMytBTjBNb21mT2pmTTVPM2loUU5uK1NwZEdWSnlSbHgyd2lu?=
 =?utf-8?B?WGc9PQ==?=
X-OriginatorOrg: oppo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cc8621ce-d36e-421d-0a4f-08dc31ca650b
X-MS-Exchange-CrossTenant-AuthSource: SI2PR02MB5612.apcprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 04:14:13.0299
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f1905eb1-c353-41c5-9516-62b4a54b5ee6
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: h/IB/TGUn3TGPsnSyUSN78vJLluz6ZWq7h8laGI/aCdhYqmzbNwcuNRrbEFVTimg5QK9cCuSFZL8z92oLNK6fA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR02MB8223


在 2024/2/20 10:55, Matthew Wilcox 写道:
> On Tue, Feb 20, 2024 at 10:04:33AM +0800, 李培锋 wrote:
>> Monkey-test in phone with 16G-ram for 300 hours shows that almost one-third
>>
>> of the contended-pages can be freed successfully next time, putting back
>> those
>>
>> folios to LRU's head would break the rules of inative-LRU.
> You talk about "the rules of inactive LRU" like we care.  The LRU is
> an approximation at best.  What are the *consequences*?
> Is there a
> benchmark that executes more operations per second as a result of
> this patch?

Hi Sir：

1. For the above data in 300 hours test in 16G-ram device:

- 795503 folios would be passed during shrink_folio_list since lock 
contended;

- 262577 folios would be reclaimed successfully but putback in head of 
inative-lru.


2. Converted to per second,:

- 0.243 folios would be putback in the head of inative-lru mistakenly


3. issues:

There are two issues with the current situation:

1. some cold-pages would not be freed in time, like the date we got in 
16GB-devices almost 1GB-folios

would not be freed in time during the test, which would cause 
shrink_folio_list to become inefficient.

Especially for some folios, which are very cold and correspond to a 
common virtual memory space,

we had found some cases that more than 20 folios were contended in 
rmap_walk and putback

in the head of inactive-LRU during one shrink_folio_list 
proccess(isolate 32 folios) and more background

user-process was killed by lmkd. Kshrinkd would let reclaim-path more 
efficient, and reduce 2% lmkd rate.


2. another issue is that staying more cold folios at the head of 
inative-lru would result in some hot-pages

to be reclaimed, and more file-refault and anon-swapin. Data would be 
updated soon if need.