Received-SPF: pass (google.com: domain of linux-kernel+bounces-72340-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 19 Feb 2024 23:13:57 -0600
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Yury Norov <yury.norov@gmail.com>
CC: <linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>, "Andy
 Shevchenko" <andriy.shevchenko@linux.intel.com>, Jani Nikula
	<jani.nikula@linux.intel.com>, <intel-xe@lists.freedesktop.org>,
	<intel-gfx@lists.freedesktop.org>, Jani Nikula <jani.nikula@intel.com>
Subject: Re: Re: [PATCH v3 2/3] bits: Introduce fixed-type BIT
Message-ID: <erg2ymp6raf7ru5ggj4hrrhet4i762msoqa2ronv4znfhlkc6o@nxu6ygtdfmrj>
References: <20240208074521.577076-1-lucas.demarchi@intel.com>
 <20240208074521.577076-3-lucas.demarchi@intel.com>
 <ZcZYhZbLyzSXX8PU@yury-ThinkPad>
Content-Type: text/plain; charset="us-ascii"; format=flowed
Content-Disposition: inline
In-Reply-To: <ZcZYhZbLyzSXX8PU@yury-ThinkPad>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9KW13i16rIvIkgVGPQkR4Lz7I8W1y30GPRRBcqK1fklkxwdLaE8jSI2g4HUj?=
 =?us-ascii?Q?uwf1nAWf4nqEMDV7RHjEChx1qPCGTJ47hOg1NE6+qxv8b9BQtOqoktT7359f?=
 =?us-ascii?Q?QHo4CsWkGFTQYPFQZ0qxs1pM5/LkTm5aUm3yDZXUr8z7yqG/gXozi5LP4ryH?=
 =?us-ascii?Q?eqM8xZ31t8gJZ6TaBvSzJFlCITuku6kcJEXdW/GAYpk/Lyg8v3//izvUVrbX?=
 =?us-ascii?Q?kW8UlBxgZG/gZAcsyMXeXK+YNCB1Y7qfYdMDr48HZpwaf40gEgVhpL3GZ+zX?=
 =?us-ascii?Q?tu92KOMlZNrBME+LuCj1wTbRpJNJM8a/4aXkTbRU6EKnAHFvKCd+xAdQsLML?=
 =?us-ascii?Q?7J04/hlCO61q96+qQl4dmG5MQmzbT1eAiX/8hDqZ5vYDpwFmwTihzFuctckW?=
 =?us-ascii?Q?Roo7XwG2EAQaOweK5IPnrlX6gp0pPGFupS7lbZ6CWmqylmc4VXrncrPNVn7g?=
 =?us-ascii?Q?+HBebw1npfRN/SEhSYIzl3L/3WYBGo3gmvs602OtB4NClKl2BP//sxTvQIbK?=
 =?us-ascii?Q?HrZ7CWcqyBTCWhhBYjCP9zB2fJ9Jz7z+eSqfeq3nEmBqJwtn96FayyZmdzjM?=
 =?us-ascii?Q?OC+nYljZVn/7IckEuH7JORZ88R8dkX8WQc+mo6bsmtUu6iplPHqLb9P3cCeq?=
 =?us-ascii?Q?JB26WrSeNc8cFnmPxJodj+xD3bbC2zaJWuWiccy3x7/0SbD9gixGCeKoDA/y?=
 =?us-ascii?Q?siv2aItEK/Ila/qevxA4neoCEaarCZCIy8mkz9xAiyYTQSTI7vQsGdHx7owF?=
 =?us-ascii?Q?+xml7t8fKEgZwrb0TNIg/I+oUiutndc4/riXB8iCbcX54sVDkZknXYEVuIUW?=
 =?us-ascii?Q?6sDzUCifxNUC3HyzlMmaeZxXqfrOT9PSRTO6IApEFRNBpVgW3B8KrzQk5yBC?=
 =?us-ascii?Q?r4FSJgWxl53x2e31rVoyihdF7yjb7Iwc02I6aMbq6em0FHlcvnAOEr2ivpV9?=
 =?us-ascii?Q?p9kQ0ZW93OWxN39NV6Q7Z+OusNWEhY9WAhpCItcZ0Xj7Ylx/jhylBGHB2pqP?=
 =?us-ascii?Q?9/xYFYoIY7emGXBjXpWx1dV7WPFwZxyt4wHhjH2pUvvAH95pfVBUQuDBJFLP?=
 =?us-ascii?Q?tsCqIYo3GHNp9XI+FMqleVYDqzM3M6BoBfomK/ZX2rMj04AwVFY0zdmt3m/3?=
 =?us-ascii?Q?lT6rRSaMVbFaZZ9bDL0DisEMrWiv2tgjXflLAX0DLkv3w1bZXXQ5WbsLJx0Y?=
 =?us-ascii?Q?kNUl1QVTMfOYtCu4rgaAPASbHrl2cryDxTwPXR8SDIGGUlPmApnLP9wYAh+0?=
 =?us-ascii?Q?Yn5tZ1kRGmVW8iDVqjxr53mTn7KqjSgndSMtDZv3bikNkrdpUQ4PjLXJIzj7?=
 =?us-ascii?Q?1gmYYIXG+xMS6xxbbxNmttDzfLfuCqhYmQduAyJ7OsZ3eTzv/rcb216sn6PI?=
 =?us-ascii?Q?kcvnZT2FaL9rQNi7EFhwKnBaq0dmxiAiUp0hS97mp1KK5ndywSy6gJyHBou1?=
 =?us-ascii?Q?6bbTWLHRd03XlzDY9uO5nMRPkhwpzR36QCKQaeYTwr9if4Pj2f2nZUNPZA/a?=
 =?us-ascii?Q?taK8STmjXPa57b6aFXDKxcZAmTjdGJjROlFj37+VrUISEyoZt2lUkXbo3G9F?=
 =?us-ascii?Q?8Dvz8Dy4MgI7gKUSJId2/qxsQJyExmUBsz8rtCIlBhY75S3YZS7TAyda4UmX?=
 =?us-ascii?Q?Tg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d1b4661a-9d2f-4ec9-84d4-08dc31d2bef7
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6139.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 05:13:59.8098
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hybKNB6WpGsLpAbmDTY8dafEeopY1K7jlep9f/lwDSijnfFu29gnHM0LXR0fEQfHW8YeVROET7VjVtRamBGyPgMPeWJSUYDWp80Jkhro2T8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7118
X-OriginatorOrg: intel.com

On Fri, Feb 09, 2024 at 08:53:25AM -0800, Yury Norov wrote:
>On Wed, Feb 07, 2024 at 11:45:20PM -0800, Lucas De Marchi wrote:
>> Implement fixed-type BIT() to help drivers add stricter checks, like was
>> done for GENMASK.
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>> Acked-by: Jani Nikula <jani.nikula@intel.com>
>
>So I get v1 from Jan.23 in my mailbox, and this one is v3. Did I miss
>a v2? Anyways, please bear my reviewed-by from v1 for this patch.

Jan 23 was actually the v2 and I missed the subject prefix.

My understanding was that you were going to apply this through some
bitmap tree, but checking MAINTAINERS now it seems there's no git tree
associated.  So I will just add your r-b and merge this through
drm-xe.

thanks
Lucas De Marchi

>
>Thanks,
>Yury
>
>> ---
>>  include/linux/bits.h | 17 +++++++++++++++++
>>  1 file changed, 17 insertions(+)
>>
>> diff --git a/include/linux/bits.h b/include/linux/bits.h
>> index bd56f32de44e..811846ce110e 100644
>> --- a/include/linux/bits.h
>> +++ b/include/linux/bits.h
>> @@ -24,12 +24,16 @@
>>  #define GENMASK_INPUT_CHECK(h, l) \
>>  	(BUILD_BUG_ON_ZERO(__builtin_choose_expr( \
>>  		__is_constexpr((l) > (h)), (l) > (h), 0)))
>> +#define BIT_INPUT_CHECK(type, b) \
>> +	((BUILD_BUG_ON_ZERO(__builtin_choose_expr( \
>> +		__is_constexpr(b), (b) >= BITS_PER_TYPE(type), 0))))
>>  #else
>>  /*
>>   * BUILD_BUG_ON_ZERO is not available in h files included from asm files,
>>   * disable the input check if that is the case.
>>   */
>>  #define GENMASK_INPUT_CHECK(h, l) 0
>> +#define BIT_INPUT_CHECK(type, b) 0
>>  #endif
>>
>>  /*
>> @@ -54,4 +58,17 @@
>>  #define GENMASK_U32(h, l)	__GENMASK(u32, h, l)
>>  #define GENMASK_U64(h, l)	__GENMASK(u64, h, l)
>>
>> +/*
>> + * Fixed-type variants of BIT(), with additional checks like __GENMASK().  The
>> + * following examples generate compiler warnings due to shift-count-overflow:
>> + *
>> + * - BIT_U8(8)
>> + * - BIT_U32(-1)
>> + * - BIT_U32(40)
>> + */
>> +#define BIT_U8(b)		((u8)(BIT_INPUT_CHECK(u8, b) + BIT(b)))
>> +#define BIT_U16(b)		((u16)(BIT_INPUT_CHECK(u16, b) + BIT(b)))
>> +#define BIT_U32(b)		((u32)(BIT_INPUT_CHECK(u32, b) + BIT(b)))
>> +#define BIT_U64(b)		((u64)(BIT_INPUT_CHECK(u64, b) + BIT(b)))
>> +
>>  #endif	/* __LINUX_BITS_H */
>> --
>> 2.43.0