Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1533238rdb; Mon, 19 Feb 2024 21:24:31 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWhwPhQ5/D/JLP2IrtCdKe4iBa+HT8qiIWMoiSsR6a7dkmpV5/kXi8+HNjvO2ouoMgaBMgei4byROiutekS1LHoUIlLB2mGcS7m7eGSpA== X-Google-Smtp-Source: AGHT+IEl5Hcx6nneawauSLuSm3NL1VfCKS+Z2ydu2XlmAwJrtwe8Y8zWpPLvbrdj5ayej36Xceap X-Received: by 2002:a05:6a20:d70f:b0:1a0:686b:afdd with SMTP id iz15-20020a056a20d70f00b001a0686bafddmr13343398pzb.5.1708406670892; Mon, 19 Feb 2024 21:24:30 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708406670; cv=pass; d=google.com; s=arc-20160816; b=cTXYE7Iix52oAB08Wqa8u/m2ENTnq6DFH7Qly6YGNYAuB2pxpdxXsyIjKm16cU/ZeP 0+cjzeKYtu389CcgWV3KtXxIn4Z0EMx1mPw27vTCnjNj/5gGfjiatOIlht9k/Hw6UwTn So3eWIFdR901ECoeNeXkvWcvasJcA77FOIxPwN1YdSI9zYulGEsvbgZq1s4Nzk8e0jGq +OA7iGfrP766Qf2JZQ6HPjLFSr7Xm/JjdbkDQk9p3TvO6l+K5B9iw8/mk4mpY89rwenr pgiaJjudGRgA5isDIqUlSfwRJwC0Gqu5x/B2nlANl5V4MYmd/qjVhrl9iexhzti8G8dp Iwhg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=NV09tUAzZc9dnnCtco4N+xbImTBJKqV3EQlqPqU5324=; fh=8M51bn2csvRFxBITOO7M0raGfwAIJm0y6ntmCRR1bsI=; b=qiRF6j2oPmucVx/8n2OaeWgllUhw9ytUG/NDjpTRNpE9dssmGf1/WhYkQHZRaNxvJN 6NcWml7d1tLVMyl5kn3rypwoiGFjTd9tjc2IXIN31t3zN/ujBEpNm9949OX2wIRrsk9h qTRaupi1H3PTV+DG343+tvq5a/0IhVa6BI9z30GNDWkM7pSLP/+lHD7KOJ2xXUVFBalt Qq2xJAnUfaAx+MBxiTy5em1/21iRJtuMZooYZChJMFSEKDDjCxZqE1bFtECVv6nkSc53 s3Xvjb8ts7YHLFnuDHTuBnvyqrl/FMe6ELsdcOQ7rZ/mp5MEEJhqMkI8XjV0Z97S0gw7 Rl5Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="S//xKMks"; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-72307-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-72307-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id z16-20020a170902ccd000b001d8d54d83c5si5720795ple.94.2024.02.19.21.24.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 21:24:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-72307-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="S//xKMks"; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-72307-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-72307-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id C7B4EB2162B for ; Tue, 20 Feb 2024 04:07:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E071755E56; Tue, 20 Feb 2024 04:07:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="S//xKMks" Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22E87535B4; Tue, 20 Feb 2024 04:07:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708402042; cv=none; b=r5fn1X7VnXtgT98Vq0luuboy0XccaDbrimFVl1hQaCjpEvJnLifU1FQ92JticXjoKyNygcIsRRU5+hhHvSYbJRLPnNn+so6vAnyizv9A7mhLzDkk1E+5/30Yk7H98dQO/z3ZAJG5eQVVY8R3VAWMpO+aTnfudb7cLX/YdFB9Cp4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708402042; c=relaxed/simple; bh=WzcJaUbAd9e6n4Q8B/516dQe7OIlDOfUYRQ8n1ZqKVE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tIfO+TCkJI9ZDuDQAHkWswHNxwG4HPEzlr3QVXo1nS7U+NwFf8LL6FbfEMqBaHB50tEMRTWUID6NGCtyYA98DidfJII20YOv15kV9acNMo5MR3oC5CZA5elGsIuc4XuH7SEuUS06jSiX1R3oHh71BPTAlCdvYqs3rbCX5OES85k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=S//xKMks; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NV09tUAzZc9dnnCtco4N+xbImTBJKqV3EQlqPqU5324=; b=S//xKMks2ig+UZ7aW6tJN8A8Oa 7/13hOBwKMRxyhtgHiAYyph09RhQnc/uq1h+5Yrtus0OvkBRbLC18p0MR7C/d9aVFr5t1R/TwAXZN x0K4cxR4q3cPRF6+BAFbh8lU0mzRACVntAsnkLZmAStbIncRRoxR5CjJMKsMf9nRLQkgZhUX5v4lP PpwDcVBLo9bGGnZz9XG8/fHmX8scVoSRX4Jnzx/cEtgPDrlPs/b5ReLvVutH1kj95Ho0XtFZUDg1v ZUuswLW+qV3B7tBZobwekgFvd1LHdhbfDKGS/NVkoIvzVtZOd+538o0ui/Qfr4FMD2sg8YZSfSdbl hF8mK5Dw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcHPR-0000000Eat0-0mh3; Tue, 20 Feb 2024 04:07:09 +0000 Date: Tue, 20 Feb 2024 04:07:09 +0000 From: Matthew Wilcox To: Edward Adam Davis Cc: syzbot+c244f4a09ca85dd2ebc1@syzkaller.appspotmail.com, jfs-discussion@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, shaggy@kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [PATCH] jfs: fix uaf in jfs_syncpt Message-ID: References: <0000000000003d021006119cbf46@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Feb 20, 2024 at 11:55:18AM +0800, Edward Adam Davis wrote: > During the execution of the jfs lazy commit, the jfs file system was unmounted, > causing the sbi and jfs log objects to be released, triggering this issue. > The solution is to add mutex to synchronize jfs lazy commit and jfs unmount > operations. Why is that the solution? LAZY_LOCK with IN_LAZYCOMMIT is supposed to cover this. Please be more verbose in your commit messages. Describe what is going wrong and why; that will allow people to understand why this is the correct solution to the problem.