Received-SPF: pass (google.com: domain of linux-kernel+bounces-72359-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Armin Wolf <W_Armin@gmx.de>
To: Shyam-sundar.S-k@amd.com,
	mika.westerberg@linux.intel.com
Cc: hdegoede@redhat.com,
	ilpo.jarvinen@linux.intel.com,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] platform/x86/amd/pmf: Do not use readl() for policy buffer access
Date: Tue, 20 Feb 2024 06:45:12 +0100
Message-Id: <20240220054513.2832-2-W_Armin@gmx.de>
In-Reply-To: <20240220054513.2832-1-W_Armin@gmx.de>
References: <20240220054513.2832-1-W_Armin@gmx.de>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:9mDdGKpSQWw=;FZUCS8i+sySI+qn939HZXC7F9jt
 XQZ/HXICIrSQYIQpfT4EounJf+Sa/W3Ql0bp4L+s7vUiuSAgmT0Lpt2dHFsulOul3bohA6uln
 t+WPZOLoSTFR8Lu/cJgikCh+OWF2G7K2HFy71sRhYJ/Fb9dC/tBV7DZp7iVGykkqfyPRDHxvK
 2/YWQ/GAMOB1Sx/K9VwGklT+3qyMDJtsxbH3uNX3O+KyxWrnClh7rhymditKgnnIsGYQBxNER
 +LuibJqnhiJQy9z4pgR2/ODmSEZYkJYNXEaccIe3Q7yN0Daz3YxdyUuCZWLNh9ZBwSQ+wACf4
 OSCK9RvJiVmOuDgZdCHd2+gu/1z4kPxP4j1O5+GxUheS4vi1U1kPsB9LE5WgvNypCpE/9QB7S
 K4zvYBwB+LKNNjGaVBHsqNFblgv3OFSBRnRrh3RT8kuK2RXbJbSoGH9xztnws/t3s5r4mut7P
 OrdZQ8jRqCYAH39i6BlT4/5Z+D/MvuBSJkw1V3SiS08SweyEchMbvtubPSM34Cu+uozYE5Apq
 fi9ivaW1ewcueyJ9zv7t/YZnlLnQYjpGY3lisfSYXDfjfJcGT3EQUuZp6ljbYrQqceGIz42BF
 NxUZEVD6pyBjgAQfDdLz/VUzDEH4RBUXSqPTsiwAJUs+IuDFSI9f6r6AyugZLJuNLfsTnJwEO
 Hv36fnd8Ahkt80VPylRCgMue67f16SKLaDfDOyW3DYmX8SfB59731gqBilvNoYA4LuweHxi46
 usNrzRDrTCIva8wSsMk0V/sQ7f+UUl4pNA5jYalmDAc4hHuQAQ4DNN8aUMc7X7I4s4Op48FHg
 1WFAd+ip1tVR2m4fD/xcnqx9Y4xk7/U0sglXU7+k9F0SY=

The policy buffer is allocated using normal memory allocation
functions, so readl() should not be used on it.
Use get_unaligned_le32() instead.

Compile-tested only.

Signed-off-by: Armin Wolf <W_Armin@gmx.de>
=2D--
 drivers/platform/x86/amd/pmf/tee-if.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/amd/pmf/tee-if.c b/drivers/platform/x86/=
amd/pmf/tee-if.c
index 16973bebf55f..3220b6580270 100644
=2D-- a/drivers/platform/x86/amd/pmf/tee-if.c
+++ b/drivers/platform/x86/amd/pmf/tee-if.c
@@ -11,6 +11,7 @@
 #include <linux/debugfs.h>
 #include <linux/tee_drv.h>
 #include <linux/uuid.h>
+#include <asm/unaligned.h>
 #include "pmf.h"

 #define MAX_TEE_PARAM	4
@@ -249,8 +250,8 @@ static int amd_pmf_start_policy_engine(struct amd_pmf_=
dev *dev)
 	u32 cookie, length;
 	int res;

-	cookie =3D readl(dev->policy_buf + POLICY_COOKIE_OFFSET);
-	length =3D readl(dev->policy_buf + POLICY_COOKIE_LEN);
+	cookie =3D get_unaligned_le32(dev->policy_buf + POLICY_COOKIE_OFFSET);
+	length =3D get_unaligned_le32(dev->policy_buf + POLICY_COOKIE_LEN);

 	if (cookie !=3D POLICY_SIGN_COOKIE || !length)
 		return -EINVAL;
=2D-
2.39.2