Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756746AbXL2Ith (ORCPT ); Sat, 29 Dec 2007 03:49:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756633AbXL2ItY (ORCPT ); Sat, 29 Dec 2007 03:49:24 -0500 Received: from courier.cs.helsinki.fi ([128.214.9.1]:57274 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756620AbXL2ItT (ORCPT ); Sat, 29 Dec 2007 03:49:19 -0500 Date: Sat, 29 Dec 2007 10:49:17 +0200 (EET) From: Pekka J Enberg To: Marcin Slusarz cc: LKML , Christoph Lameter , akpm@linux-foundation.org Subject: Re: [PATCH] slab: avoid double initialization & do it in 1 function In-Reply-To: <20071227202849.GA11114@joi> Message-ID: References: <20071227202849.GA11114@joi> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 533 Lines: 15 Hi Marcin, On Thu, 27 Dec 2007, Marcin Slusarz wrote: > * alloc_slabmgmt: initialize all slab fields in 1 function > * slab->nodeid was initialized twice: in alloc_slabmgmt > and immediately after it in cache_grow Looks good to me. Reviewed-by: Pekka Enberg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/