Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1541397rdb; Mon, 19 Feb 2024 21:54:04 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUZaIGpc9xs9WNftP9DDIN09PNbWUlc4WdsiBgHI6iWOz2Ny9hpYz1MeA9bb0tIUFf+Ks5d+4fxnQ1iNt5ruAcidSv7ECR15Ed4wu9mbQ== X-Google-Smtp-Source: AGHT+IHiWZMT6XS/c5wiTSmQbwYp2CYEwAqyCLl5cdf1UR/OynBsqzbq90HIdOlH2+W6+neFCH1C X-Received: by 2002:a17:906:5916:b0:a3e:8312:616a with SMTP id h22-20020a170906591600b00a3e8312616amr4887450ejq.30.1708408444782; Mon, 19 Feb 2024 21:54:04 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708408444; cv=pass; d=google.com; s=arc-20160816; b=pnOp9fVdF+Cp54L12+xHByaq9SYT+65IC2VdIcJOf0UiyHQ+NvDmK2Y7eH31SbOMb9 iy3aUnBcteWuSe3EKYg6D3bcrkY6xGS1Z1Z1Huvo5jiCVHCS8QnXIeA6I/v6KRUJqy+S Vrcj8LcP9u4NiDOvEPZgiFGWw7ljebkJ0qgL+gjZt2a7GswN8VbGdIzEZlsaCXhDErbp oqAqjrD6T7CqLSEJ3zck8yaOz/ccg4BVSF9OWT0vc4GsaYSu9tcAtgIZlS2ubXu7Imik 29RLppJZg0nznMuFiMGh7RdbbGXvrs9WMEAw3r44Qmp3JGZmNzmTXRCZg+Xcb9rGfiKc 9fMA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=mGAsuJ4JUrAAtk/Y4GdBXmsxhu1i6DQQWGtABcrWkbI=; fh=97zEDWPNB6z1vTcEl58zKX6382RdHQMWx0CMUvmPOSg=; b=bAuZzJisFvfMP6CzfnnFWDj522HrrkGo1cZtD3PMbyl9ZATHhLmXoS70guByFHaSJn d+8GHmq+E4lqQ2hUEv+E9DH+qKO3/9WgdJcJPpTA3741PIuWVejFC4u7vR03s+E3PHaQ nKqmGJMrUarztwXmubvgtK2WAdesRG1FOhRbJE/OXP8rt7Lo0BunOl4Nuiy2YlHXChLa DCHsNoNQxjXdJpw4Kf50i5TRIScy9NaJZHqnexhfcZJzoH5BrXrU3X8OyY0c0b1/NSVz WbU0vRwkfA/22wLdENU0siKsw+0c/gnRYozuxTPjjTnxVoS2WcTVPSxFU8P61IFC1BSP FegQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-72366-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-72366-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id gs34-20020a1709072d2200b00a3ec9d2cdf6si1085603ejc.897.2024.02.19.21.54.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 21:54:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-72366-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-72366-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-72366-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 8A0361F23402 for ; Tue, 20 Feb 2024 05:54:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EBAA757320; Tue, 20 Feb 2024 05:53:58 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9B1E57302 for ; Tue, 20 Feb 2024 05:53:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708408438; cv=none; b=Z1Fv73l3CMrd1O7qCfcR78egbj8Pfq+FxHHv2lhNkilZ9MImuBhBEyBxx22uO+hsIpQfztkcZDzz/hMeLRDldE4VMoCG1GtBpHiZna+l7MJF4gM+PyEViniMl/JHh8fVkMfBjtzJMId8lLoi2VyASNxx5jOqTNqmABFOVAb64oQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708408438; c=relaxed/simple; bh=mGAsuJ4JUrAAtk/Y4GdBXmsxhu1i6DQQWGtABcrWkbI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gXVjMlt1mBen6q2b1Oe6z61ur6Gkqcqeebl/rVHONQJiNX5DDje9sZGB55TYkNliRGPETUzMm4iee3J1Xbk3iylVbEK821mKWrVLsPodoC3GyZ45TLd3aGS6JT+i1/CiCRmLl+YSa6Y7AfDKRpPrpLQSD5HJ+BhiZCK2I3TPNaI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id A54E168AFE; Tue, 20 Feb 2024 06:53:53 +0100 (CET) Date: Tue, 20 Feb 2024 06:53:53 +0100 From: Christoph Hellwig To: Keith Busch Cc: Daniel Wagner , James Smart , Christoph Hellwig , Sagi Grimberg , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/6] nvme-fabrics: introduce connect_sync option Message-ID: <20240220055353.GB7554@lst.de> References: <20240219131531.15134-1-dwagner@suse.de> <20240219131531.15134-2-dwagner@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Mon, Feb 19, 2024 at 11:44:08AM -0700, Keith Busch wrote: > The series looks good to me. My only feedback is this patch doesn't > change anything without patch 6, so I think these two go together. And it needs to clearly document why fc is different and why we believe that's reasonable (if we do, I'll chime into that thread in a bit).