Received-SPF: pass (google.com: domain of linux-kernel+bounces-72374-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Content-Type: text/plain;
	charset=utf-8
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\))
Subject: Re: [PATCH]     Fix implicit cast warning in test_klp_state.c
From: zhang warden <zhangwarden@gmail.com>
In-Reply-To: <20240219141606.6711-1-mpdesouza@suse.com>
Date: Tue, 20 Feb 2024 14:06:10 +0800
Cc: Shresth Prasad <shresthprasad7@gmail.com>,
 jpoimboe@kernel.org,
 jikos@kernel.org,
 mbenes@suse.cz,
 pmladek@suse.com,
 joe.lawrence@redhat.com,
 shuah@kernel.org,
 live-patching@vger.kernel.org,
 linux-kselftest@vger.kernel.org,
 linux-kernel@vger.kernel.org,
 linux-kernel-mentees@lists.linuxfoundation.org,
 skhan@linuxfoundation.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <FD18B42B-6B73-4B55-A9B2-272414531C26@gmail.com>
References: <20240219141606.6711-1-mpdesouza@suse.com>
To: Marcos Paulo de Souza <mpdesouza@suse.com>

Well, the repo location I use is =
git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git.
It seem klp_get_state return struct klp_state.
The definition of this function in my repo as follows:

struct klp_state *klp_get_state(struct klp_patch *patch, unsigned long =
id)=20
{
    struct klp_state *state;

    klp_for_each_state(patch, state) {
        if (state->id =3D=3D id)=20
            return state;
    }  =20

    return NULL;
}
EXPORT_SYMBOL_GPL(klp_get_state);

Are you sure there is really a need for forced conversion?

> 2024=E5=B9=B42=E6=9C=8819=E6=97=A5 22:16=EF=BC=8CMarcos Paulo de Souza =
<mpdesouza@suse.com> =E5=86=99=E9=81=93=EF=BC=9A
>=20
> On Sat, 17 Feb 2024 04:21:26 +0530 Shresth Prasad =
<shresthprasad7@gmail.com> wrote:
>=20
>>    The function `klp_get_state` returns an `int` value, but the =
variable
>>    `loglevel_state` is of type `struct klp_state *` and thus does an
>>    implicit cast. Explicitly casting these values fixes:
>>=20
>>            - warning: assignment to \u2018struct klp_state *\u2019 =
from \u2018int\u2019
>>    makes pointer from integer without a cast [-Wint-conversion]
>>=20
>>    on lines 38, 55, 68 and 80 of test_klp_state.c
>=20
> I was unable to find where you saw the klp_get_state returning int. I =
tried
> searching at the current master of live-patching repo[1], on =
linux-next. Can
> you point where do you saw it? For me, klp_get_state return a pointer =
to klp_state.
>=20
> Thanks,
>  Marcos
>=20
> [1]: =
https://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching.=
git/tree/kernel/livepatch/state.c
>=20
>>=20
>> Signed-off-by: Shresth Prasad <shresthprasad7@gmail.com>
>> ---
>> .../selftests/livepatch/test_modules/test_klp_state.c     | 8 =
++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>=20
>> diff --git =
a/tools/testing/selftests/livepatch/test_modules/test_klp_state.c =
b/tools/testing/selftests/livepatch/test_modules/test_klp_state.c
>> index 57a4253acb01..ae6b1ca15fc0 100644
>> --- a/tools/testing/selftests/livepatch/test_modules/test_klp_state.c
>> +++ b/tools/testing/selftests/livepatch/test_modules/test_klp_state.c
>> @@ -35,7 +35,7 @@ static int allocate_loglevel_state(void)
>> {
>> struct klp_state *loglevel_state;
>>=20
>> - loglevel_state =3D klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE);
>> + loglevel_state =3D (struct klp_state *)klp_get_state(&patch, =
CONSOLE_LOGLEVEL_STATE);
>> if (!loglevel_state)
>> return -EINVAL;
>>=20
>> @@ -52,7 +52,7 @@ static void fix_console_loglevel(void)
>> {
>> struct klp_state *loglevel_state;
>>=20
>> - loglevel_state =3D klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE);
>> + loglevel_state =3D (struct klp_state *)klp_get_state(&patch, =
CONSOLE_LOGLEVEL_STATE);
>> if (!loglevel_state)
>> return;
>>=20
>> @@ -65,7 +65,7 @@ static void restore_console_loglevel(void)
>> {
>> struct klp_state *loglevel_state;
>>=20
>> - loglevel_state =3D klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE);
>> + loglevel_state =3D (struct klp_state *)klp_get_state(&patch, =
CONSOLE_LOGLEVEL_STATE);
>> if (!loglevel_state)
>> return;
>>=20
>> @@ -77,7 +77,7 @@ static void free_loglevel_state(void)
>> {
>> struct klp_state *loglevel_state;
>>=20
>> - loglevel_state =3D klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE);
>> + loglevel_state =3D (struct klp_state *)klp_get_state(&patch, =
CONSOLE_LOGLEVEL_STATE);
>> if (!loglevel_state)
>> return;
>>=20
>> --=20
>> 2.43.1
>=20