Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1557517rdb; Mon, 19 Feb 2024 22:45:03 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWr7ooOad6d5ARS/Zcgwss4DzeegNJar8ErzXR9fydyZjpcwZlpL6e1XviTasouV2HaxG4tIxNI7Lbmv9Ov0E1qm0n6pWW0yQL050Dx9g== X-Google-Smtp-Source: AGHT+IHUhEpWhvPscXTSIxx6++ofKbKWqyGDU3kNPTUS4vrWrkRZoG1NO5byEhZJw1u5V/E6Zx6g X-Received: by 2002:a17:902:e5d0:b0:1db:e6f6:e284 with SMTP id u16-20020a170902e5d000b001dbe6f6e284mr7358356plf.68.1708411503660; Mon, 19 Feb 2024 22:45:03 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708411503; cv=pass; d=google.com; s=arc-20160816; b=qw3lDbGVqxuFuiZCIDdn2D4gV1Y6V+kGpQFSG0jvn5aGGW1S/eoocKEbdvmTFpa44J bX8aOO9hl2wi4byThJN/HI2uXa/JNUUsDGB4SdwrP/DLyL9WTnE7hKZJVy1reuJL+mRs tlIHmC8jL7nnPWBvEnQho8jtsN/lgRW1jC15KOGh0mGd65uTmq98S5EZnwXQjRdMxNk6 tAVvc0xg2FT7k2U7wRzvm/gDXUXATdb37WMhNXqjnXOhHqRmsEJd/l/PrfwsP8/4RjzY 3VkGIUzVc26GpBHpE3im4MPQCcWoYaB5Vt6QqCST7J5F6wc6IRgQFCdummh747I5JV2h lBuw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=f/cX0Xb+suXKEP+eoJpTnCJw48yCFcQJWk46D5ossts=; fh=W6COFBd4BX4Q4YpnsinfP4Lifuq45kIfChsHXFM1YEQ=; b=X1ibmrpBSJLSBpw7PiTRfZ+zfSYjRIeDl1JKsJSw2rTJ278S3zGpa7z027HXuI/6Hu nIJV21bxVrOaP4MJWs38VpxixTxIQYgFwpTeRQ4zWiP6cBwdA+GzbDgb25MLu6NDasSv 4Qka5Q7Sb2nYFIIu+OmubADSd3M87SJEe8pZPsWtS4iU9e6A9Ki7iVORG2vv1OTdLtIl bzbEocbZBDSSzL80+iKF0O7QC4TiU5wz1b5KpcPO1UGaVPlIuBahhT+80l+sF7Vh9f6E E18By1m6r2ww4rZZ/6KFsdt7mxIaXzsIOSuiXXnt5x5CFuXuzhVXN6XdIkJiXinlWD97 ZSwA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Mq4C/18l"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-72410-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-72410-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id c6-20020a170902c1c600b001d8ee28a307si5703359plc.277.2024.02.19.22.45.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 22:45:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-72410-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Mq4C/18l"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-72410-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-72410-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D3A5D286841 for ; Tue, 20 Feb 2024 06:29:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 21C9859174; Tue, 20 Feb 2024 06:29:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Mq4C/18l" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3181059149 for ; Tue, 20 Feb 2024 06:28:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708410539; cv=none; b=RT2i6RRQP0lA8v5pKuVeYoZNJEaqDMB0oJaIMk6BezBRc1c0l7qiYVnooJvM9W3+y5KfDICfS1TRXPteuAoLlNDuoYbZJxrnBAwyDN+icVk5eFHp6tc0VwQEmPHmIjdldmkJtnNT/VA0lQsIJwwEvhkIqIr/pzpri5DderSYJXk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708410539; c=relaxed/simple; bh=Ikjos80Zh4ll9+FUW8GvMvm0wxmlexe33zUqOA66Oe4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JSYRttsY0lpnKoxtyMBwkQK9VC/sBjuvTN4x/c459eR1/X5sm+jumezzXteyBptskuFuX5L9LvvkprIa8uuu7u8unwZ6awSApUNfdXuAKMpGLDuFByAjFVkSxce/m3V0Z+2c/kWp+BF79uFY6JeXJTLeNQGoyWgBAKhXSCbsJPE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Mq4C/18l; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB4BEC43394; Tue, 20 Feb 2024 06:28:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708410538; bh=Ikjos80Zh4ll9+FUW8GvMvm0wxmlexe33zUqOA66Oe4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Mq4C/18lAi4M7zsAm4LZ/+yCdlf1E4TTdePQzBVcrGiEM+51rNbUfT5llkiwyaf1J zr1YL0j+kZg6cFhsnRDru4TiXgAmO7KYH8XEY6ZiTk02lt6g10Sl9NTOMUGolUH/dO xmqd8eGOWpIxMrYpDz8Dt+KNJzDdTgFe2Qgplie2bR97Ch2y1l19N24fukS2hSCAfQ Pa29ZgiUyrKTELJqSUsPEvMys4IYsE1fjjJ/zv64q+OkP7bm9y1GaI9aTDUTJc3KK4 GHSCH3eIhi7BVWXEu+waTfomTQeNlJZZxCSqkig/jfvDZqZslAhNbblSxo76ViR9Mh +3y2WG+i7YfJg== Message-ID: <3c8a3170-3a73-4c97-aeac-0d86356a0f03@kernel.org> Date: Tue, 20 Feb 2024 14:28:54 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/4] f2fs: stop checkpoint when get a out-of-bounds segment Content-Language: en-US To: Zhiguo Niu , jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, niuzhiguo84@gmail.com, ke.wang@unisoc.com, hongyu.jin@unisoc.com References: <1708409484-27326-1-git-send-email-zhiguo.niu@unisoc.com> From: Chao Yu In-Reply-To: <1708409484-27326-1-git-send-email-zhiguo.niu@unisoc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024/2/20 14:11, Zhiguo Niu wrote: > There is low probability that an out-of-bounds segment will be got > on a small-capacity device. In order to prevent subsequent write requests > allocating block address from this invalid segment, which may cause > unexpected issue, stop checkpoint should be performed. > > Also introduce a new stop cp reason: STOP_CP_REASON_NO_SEGMENT. Can you please adjust f2fs-tools as well? > > Signed-off-by: Zhiguo Niu Reviewed-by: Chao Yu Thanks,