Received-SPF: pass (google.com: domain of linux-kernel+bounces-72430-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <f51946e2-68f4-4368-9a77-050382dfa3ff@kernel.org>
Date: Tue, 20 Feb 2024 14:50:11 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] Revert "f2fs: stop allocating pinned sections if EAGAIN
 happens"
Content-Language: en-US
To: Wu Bo <wubo.oduw@gmail.com>, Wu Bo <bo.wu@vivo.com>,
 Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
 stable@vger.kernel.org
References: <20240205031415.557879-1-bo.wu@vivo.com>
 <793fd834-fe28-4647-b2cf-0012acb95b43@kernel.org>
 <bab0d763-2907-4412-8075-a7ebb25081c0@gmail.com>
From: Chao Yu <chao@kernel.org>
In-Reply-To: <bab0d763-2907-4412-8075-a7ebb25081c0@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 2024/2/8 16:11, Wu Bo wrote:
> On 2024/2/5 11:54, Chao Yu wrote:
>> How about calling f2fs_balance_fs() to double check and make sure there is
>> enough free space for following allocation.
>>
>>         if (has_not_enough_free_secs(sbi, 0,
>>             GET_SEC_FROM_SEG(sbi, overprovision_segments(sbi)))) {
>>             f2fs_down_write(&sbi->gc_lock);
>>             stat_inc_gc_call_count(sbi, FOREGROUND);
>>             err = f2fs_gc(sbi, &gc_control);
>>             if (err == -EAGAIN)
>>                 f2fs_balance_fs(sbi, true);
>>             if (err && err != -ENODATA)
>>                 goto out_err;
>>         }
>>
>> Thanks,
> 
> f2fs_balance_fs() here will not change procedure branch and may just trigger another GC.
> 
> I'm afraid this is a bit redundant.

Okay.

I guess maybe Jaegeuk has concern which is the reason to commit
2e42b7f817ac ("f2fs: stop allocating pinned sections if EAGAIN happens").

Thanks,

> 
>>