Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1559417rdb; Mon, 19 Feb 2024 22:51:50 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUNZi+QP2FUqhAAzj9YkxjSK0GefP2GYO6cYeZek8oXcdg6uqaocExDjLhj7wuUV0/zemL9Tfq+/9dx/YRY7suaCQoEZdmbj2zZ/uPFpQ== X-Google-Smtp-Source: AGHT+IFnmuu0aq4lwDHh06u3Z4q4vBeB15WchLBk7/wX7N/va0pdzTCuSb12QNEwZSaokeFCgBub X-Received: by 2002:a17:906:7145:b0:a3e:95b8:4c7a with SMTP id z5-20020a170906714500b00a3e95b84c7amr2769445ejj.23.1708411910689; Mon, 19 Feb 2024 22:51:50 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708411910; cv=pass; d=google.com; s=arc-20160816; b=gZYQbUGSrwDGGUEodLuTlZmubvxgCc+lls8oU/2RuDtDOlodSsFVhCjgGtf201HvJf lyvfrzTemyekB2gG7YHvhQ+6PI2g/05XNyJEQEOF/GruXhya2uDGrux46VbvH5efyxYQ PXWXNyMyCIw2RSPjz9ROBFRcDeZRyV6yEqULjN7GtqAiThVn2GGr+l0x2iQSKAb6fESk W0Hw49fquJtq2AzP8uu5F5vpGhpa/52XVde9RQfGgVu4RX1MM5pjf/L3jap8AtMpy8Yu n/nO8DU8haKrUst8Wih1SfvayDihvxwJMmxHKjCa7VB6I8J2Bxt7xxlwD33RdxrZx/8U GBgQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=nVdg1PJbryLNJr8OPoKP6QSZt+qIgtFAGudvSq/1sw4=; fh=XWpJM0+sAeGthyY3nBhK6zPbStAEoEiiNvrZrRt2iVU=; b=dOIuYrKh87pclRlP5IWWSwdF0vB083/2NxFy7sxit35wKLSClLXAPFHSMNQL7Aq5rv clmoqOBfJs6+qYg33TqmfmsM1F3F2RylmDwzozFacOcrLyG+06YM54rSjhECX0lZ93hY fLxXHRZKKNomX1CHenEBHhzRXkS6KqJ9MsV8etvABFdk7eXtjobLzdib1ZE40Qfy2SWN FzNZBViD0hzeUwmnAp/RO7h6JlyhODoVQoizP696ie5P9WjhZoDt045sqBxEDqA9Y+4F j6DmPKA2pGDxQn0T7mjHtfjuPi3UXsjJPOG5H4o6wBzypo6FIc9n82YTQoAOAYFf3pqx rL7g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-72432-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-72432-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id hq19-20020a1709073f1300b00a3ebe808ffasi1259534ejc.190.2024.02.19.22.51.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 22:51:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-72432-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-72432-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-72432-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 6ACD21F21C9F for ; Tue, 20 Feb 2024 06:51:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4B3162C86E; Tue, 20 Feb 2024 06:51:44 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF0551DDFC for ; Tue, 20 Feb 2024 06:51:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708411903; cv=none; b=Osk6yzlHVo/RH9gXiFh6EQU+gSGUlxERMVVEj0O1G30D8nmei5Ir1noHI85kg7OVqFT9pEgApdpj4e3GXV1LBQqh0lv8fnG6plQUnPsNdn2+AaZ3PrvaYCipmIwhE/ziG8LBe8klgbgxNLOfOhuuDBqj9XamQ6WtU8VRkxYsK8k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708411903; c=relaxed/simple; bh=tkxEBUHWm9trNzsG//zbI8cdUdecOc1mtQHx43KyyH4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Bz5EQzP9csuNNFkTkkTLlYlOYSNfWov8G1v4JDE4IbRnBYOtTHNxpd0FJTn2Pu3rvE87NevAzFFQ1RausxCPjVJ2O31/CbpGbLeuf55Fzhar4+C9az/NxtW94tMymqElse8IAg0hiFdUuH5xxHyeYkvrpiZWXGF9aYZlWRPG9oU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id A55F368AFE; Tue, 20 Feb 2024 07:51:31 +0100 (CET) Date: Tue, 20 Feb 2024 07:51:31 +0100 From: Christoph Hellwig To: Daniel Wagner Cc: Christoph Hellwig , James Smart , Keith Busch , Sagi Grimberg , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v0 1/6] nvme-fabrics: introduce connect_sync option Message-ID: <20240220065131.GA9150@lst.de> References: <20240216084526.14133-1-dwagner@suse.de> <20240216084526.14133-2-dwagner@suse.de> <20240216094909.GA19961@lst.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Fri, Feb 16, 2024 at 05:44:02PM +0100, Daniel Wagner wrote: > James answered this point on my attempt to make this synchronous: > > https://lore.kernel.org/linux-nvme/0605ac36-16d5-2026-d3c6-62d346db6dfb@gmail.com/ That needs to go into the commit log. And I call complete BS on that to be honest. > Ideally, we could agree on behavior which is the same for all > transports. sync and async opt in it is. I'm still pissed FC did this differently without any proper discussion of the tradeoffs.