Received-SPF: pass (google.com: domain of linux-kernel+bounces-72442-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <2abe3279-ccba-4e1d-a04c-fd724e1660b6@nvidia.com>
Date: Tue, 20 Feb 2024 08:57:55 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/2] net/mlx5: pre-initialize sprintf buffers
To: Zhu Yanjun <yanjun.zhu@linux.dev>, Arnd Bergmann <arnd@kernel.org>,
 Saeed Mahameed <saeedm@nvidia.com>, Leon Romanovsky <leon@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>, "David S. Miller" <davem@davemloft.net>,
 Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
 Paolo Abeni <pabeni@redhat.com>, Alex Vesker <valex@nvidia.com>,
 Erez Shitrit <erezsh@nvidia.com>, Hamdan Igbaria <hamdani@nvidia.com>,
 netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240219100506.648089-1-arnd@kernel.org>
 <bbef7014-5059-405d-a27a-a379431a3fcf@linux.dev>
Content-Language: en-US
From: Yevgeny Kliteynik <kliteyn@nvidia.com>
In-Reply-To: <bbef7014-5059-405d-a27a-a379431a3fcf@linux.dev>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Nk5vb3dIaHZMNFhxMUM2ZHJxVVhWVERkMmRIWjB3TWwwdHNibGF3eU42Mk5O?=
 =?utf-8?B?bGwzT3ArSTlZS24yWGdJNUZHT1dZWGQyRTU2UzNMdU14NlgxWk9ZbFBqM2M3?=
 =?utf-8?B?Q2M5SGlpQmozdm55TFZvMmZ1ejV4WC9WaDgrRGhySGFJdkc0RXlDcjFHRnNy?=
 =?utf-8?B?MWYvY0dkSk1VdFlZNDQ4dVNzeHE2S3FhK0Y0ZTN0R04vSjdpTy9sNjYycktN?=
 =?utf-8?B?dHd1Y1VjWjRtcTZhdk1ya1lybEd1NG1jZmRtN01kbCt3c3YwZzZaSkhURi9v?=
 =?utf-8?B?Zjh1cXVtZlI1b0MySkErVExUcWpLY0FUcm16cjlOdlQ2cDFpZlg3SE1mcjRm?=
 =?utf-8?B?WlRGaHV6R1A5SU12N0pEUjlZOFYrYWtqc0ZsZjJPd25wYnpqR2RuVlpnYzc5?=
 =?utf-8?B?Nm9hM2N3VUhaQXVndHM5NmRDcUc2emM0VkxCYUJNeXN2MUgyRDBpc0xhZkJs?=
 =?utf-8?B?NVVXdnphWGJaN3NxaU5uRmZHV2xsK0lJWmtBNXB6U2JnR1U3TytqNVNNNE55?=
 =?utf-8?B?ZTlEa1Q3MjRDVlByODE5aXAyOXdzOFBBUzVoRXU1TWdjVklneXdoWHB1ZXFJ?=
 =?utf-8?B?ajJWVGEyb3lUb3JxQkhmdktkRnZndEFpNFVOQ1VDaGJ5ZlBYVktLUnpVclY4?=
 =?utf-8?B?YWtNU2x3SzZKWUczay9pQXM3OXBFOVJWaGpXaE9KMjBGOWpwbGp1SXFhSjl3?=
 =?utf-8?B?emhuSFYyNHQwb09jeDE1VytJU0U0RjBhaWd0OWZsV1c5MDJUU2xlS2MzQXM3?=
 =?utf-8?B?K2VndXpSWWM5TDFYQndtNGh3WlFXSE5JeWszYUNTaHU5UFV2UmwxdnNuTDh6?=
 =?utf-8?B?S2JxMUdmMHVObDRham54NGg4UzBrZXNJNGtnTXc1czBkZzE1VlNrK3dBQ0Fs?=
 =?utf-8?B?eHRmQXhDZGFmMUpQTnQ4ZXFyUWxlT0NoZzJVMjVxbnVKRktFUTcwQ0lBQWN1?=
 =?utf-8?B?ODRkNVovVjdxbnV4N2t6OHdTN0hldHFnUlFzWHBlTEUrUWdpLzZhQVBTTVh4?=
 =?utf-8?B?Q2QxRVZUcnN1MWptaVdGc1E2YkgwSTJCRWVETjlqSEdtb0pPTElSZzdxWjRa?=
 =?utf-8?B?UEFtbXMyM2VDN25vU2ViZ3NDVzE1SFBKaDBrWjFhbmhrWWt2TkJhUmVvNG9D?=
 =?utf-8?B?WkVaZHZCTHIvOE9MSFVCWkRtaXU2VzhhNkdtRzR4N3VYTjQ5SjNrdXRORi9I?=
 =?utf-8?B?OFRRN3NNckFyT3Z5dWdTdXNuc2FLcXd6cjFwZHlBN0ZtZTdCcXZRY0RFZUhS?=
 =?utf-8?B?T29YN1N0S1FBUkF0R0lRRFNIV090NFRnZ2pjOURydDUxakVMMDBQUGNLVk9R?=
 =?utf-8?B?dUxheTN6Wlo1T3JLcU53UVZCT2hpY1pnNjBnNGQyNHFGc2ZySjB2bWNwZDdZ?=
 =?utf-8?B?VzJVQ0FZeU9ZbHR1RWpROVpVRitnTDJoOStVS0lQWXhwQ0NNMUlJdld5Ti9Y?=
 =?utf-8?B?UHE4VmEvcUtESXM4ZjdkWEJVZXBIM3E4VVkrZENOZlJ1bFM5VzZ4ZHBNbU81?=
 =?utf-8?B?TGFTQ0c1U2lRRWNPUkhQWHM4VHRMcmh0MHM4TXRVS3JFVUNOQTNZUGRmTXlT?=
 =?utf-8?B?SjRiZ2gzWDVCYmZGdFdzaHljREtVWFVWYXpvUWh6aEo0UGpFRnkxbEpEMytQ?=
 =?utf-8?B?TnRaTHRlZGRWQitEWnZrTm8rUk42U205ZEo3SWhHeDB3UGxBS0pwdC9NMHdx?=
 =?utf-8?B?YkRNN0h2MGJZclJNTWVYb3YrRlZuWjBzcmpQNmJabmExMGswNE5KNlRkZHlz?=
 =?utf-8?B?SWFQOGtsb3RrOWN3TUtDSS9EMHdsTDhyQ0FIcy9KQ3AwbVlBQWFJZkZJQ0k3?=
 =?utf-8?B?NHFSVFRvY1FRd3FUNEdFaktpQTc4d2hQNmh6M1VXVEluajlYaGxyVUpzVHY1?=
 =?utf-8?B?T2xhdUwxTnp0UGNzUisvM3lmMWtycG5PdnJyN3MwbkdFaEwzWTNqVG00YzBx?=
 =?utf-8?B?Y2tNZHdwV1pXZW92ZTlNckVWb1lyeWF0aE5iNStlMlFkN1NlZlY0SHNtRmJa?=
 =?utf-8?B?bmxzT1J4RDVIb3NwaG5sVXUrY2FjUTdNcUZDQzhraS9lTGw5bFZMUG5wbnlP?=
 =?utf-8?B?UnlDMU5VU3RmT24wdDRYRDQrL1Zta2ZsZUpYSW93WTdUa3VRNTU4WFV6NnRE?=
 =?utf-8?Q?hnv1Fw4y3H+dZqw0qJmBsq7Hb?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bf6e7b3b-00c0-47a9-5918-08dc31e1491c
X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8086.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 06:58:04.5847
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MDrE0lq38wlAUPLXdotdlbOOD3/NFfFd70VbDz7cIxHelY/2DvKSiYD6DPHHWr0rPrJs/frHtIe0rtSQhRZ2Ng==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8871

On 20-Feb-24 07:50, Zhu Yanjun wrote:
> External email: Use caution opening links or attachments
> 
> 
> 在 2024/2/19 18:04, Arnd Bergmann 写道:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> The debugfs files always in this driver all use an extra round-trip
>> through an snprintf() before getting put into a mlx5dr_dbg_dump_buff()
>> rather than the normal seq_printf().
>>
>> Zhu Yanjun noticed that the buffers are not initialized before being
>> filled or reused and requested them to always be zeroed as a
>> preparation for having more reused between the buffers.
> 
> I think that you are the first to find this.

The buffers are not initialized intentionally.
The content is overwritten from the buffer's beginning.
Initializing is not needed as it will only cause perf degradation.

-- YK