Received-SPF: pass (google.com: domain of linux-kernel+bounces-72482-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240216180559.208276-1-tj@kernel.org> <20240216180559.208276-17-tj@kernel.org>
In-Reply-To: <20240216180559.208276-17-tj@kernel.org>
From: Lai Jiangshan <jiangshanlai@gmail.com>
Date: Tue, 20 Feb 2024 15:33:34 +0800
Message-ID: <CAJhGHyBR6up3o9Svxn=uL2a0rRcu-q3BR8TgdpLykR6iTZ3Aew@mail.gmail.com>
Subject: Re: [PATCH 16/17] workqueue: Allow cancel_work_sync() and
 disable_work() from atomic contexts on BH work items
To: Tejun Heo <tj@kernel.org>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, 
	allen.lkml@gmail.com, kernel-team@meta.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello, Tejun

On Sat, Feb 17, 2024 at 2:06=E2=80=AFAM Tejun Heo <tj@kernel.org> wrote:

> @@ -4072,7 +4070,32 @@ static bool __flush_work(struct work_struct *work,=
 bool from_cancel)
>         if (!pool)
>                 return false;
>
> -       wait_for_completion(&barr.done);
> +       if ((pool->flags & POOL_BH) && from_cancel) {

pool pointer might be invalid here, please check POOL_BH before
rcu_read_unlock()
or move rcu_read_unlock() here, or use "*work_data_bits(work) & WORK_OFFQ_B=
H".

> +               /*
> +                * We're flushing a BH work item which is being canceled.=
 It
> +                * must have been executing during start_flush_work() and=
 can't
> +                * currently be queued. If @work is still executing, we k=
now it
> +                * is running in the BH context and thus can be busy-wait=
ed.
> +                *
> +                * On RT, prevent a live lock when current preempted soft
> +                * interrupt processing or prevents ksoftirqd from runnin=
g by
> +                * keeping flipping BH. If the tasklet runs on a differen=
t CPU
> +                * then this has no effect other than doing the BH
> +                * disable/enable dance for nothing. This is copied from
> +                * kernel/softirq.c::tasklet_unlock_spin_wait().
> +                */

s/tasklet/BH work/g

Although the comment is copied from kernel/softirq.c, but I can't
envision what the scenario is when the current task
"prevents ksoftirqd from running by keeping flipping BH"
since the @work is still executing or the tasklet is running.


> +               while (!try_wait_for_completion(&barr.done)) {
> +                       if (IS_ENABLED(CONFIG_PREEMPT_RT)) {
> +                               local_bh_disable();
> +                               local_bh_enable();
> +                       } else {
> +                               cpu_relax();
> +                       }
> +               }
> +       } else {
> +               wait_for_completion(&barr.done);
> +       }
> +
>         destroy_work_on_stack(&barr.work);
>         return true;
>  }
> @@ -4090,6 +4113,7 @@ static bool __flush_work(struct work_struct *work, =
bool from_cancel)
>   */
>  bool flush_work(struct work_struct *work)
>  {
> +       might_sleep();
>         return __flush_work(work, false);
>  }
>  EXPORT_SYMBOL_GPL(flush_work);
> @@ -4179,6 +4203,11 @@ static bool __cancel_work_sync(struct work_struct =
*work, u32 cflags)
>
>         ret =3D __cancel_work(work, cflags | WORK_CANCEL_DISABLE);
>
> +       if (*work_data_bits(work) & WORK_OFFQ_BH)
> +               WARN_ON_ONCE(in_hardirq());

When !PREEMPT_RT, this check is sufficient.

But when PREEMP_RT, it should be only in the contexts that allow
local_bh_disable() for synching a BH work, although I'm not sure
what check code is proper.

In PREEMPT_RT, local_bh_disable() is disallowed in not only hardirq
context but also !preemptible() context (I'm not sure about it).

__local_bh_disable_ip() (PREEMP_RT version) doesn't contain
full check except for "WARN_ON_ONCE(in_hardirq())" either.

Since the check is just for debugging, I'm OK with the current check.

Thanks
Lai