Received-SPF: pass (google.com: domain of linux-kernel+bounces-72519-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <de554783-f9da-4fc5-aaa5-6fde74c1c728@oracle.com>
Date: Tue, 20 Feb 2024 08:13:59 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 03/11] fs: Initial atomic write support
To: dsterba@suse.cz
Cc: axboe@kernel.dk, kbusch@kernel.org, hch@lst.de, sagi@grimberg.me,
        jejb@linux.ibm.com, martin.petersen@oracle.com, djwong@kernel.org,
        viro@zeniv.linux.org.uk, brauner@kernel.org, dchinner@redhat.com,
        jack@suse.cz, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
        linux-fsdevel@vger.kernel.org, tytso@mit.edu, jbongio@google.com,
        linux-scsi@vger.kernel.org, ojaswin@linux.ibm.com, linux-aio@kvack.org,
        linux-btrfs@vger.kernel.org, io-uring@vger.kernel.org,
        nilay@linux.ibm.com, ritesh.list@gmail.com,
        Prasad Singamsetty <prasad.singamsetty@oracle.com>
References: <20240219130109.341523-1-john.g.garry@oracle.com>
 <20240219130109.341523-4-john.g.garry@oracle.com>
 <20240219191634.GY355@twin.jikos.cz>
Content-Language: en-US
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20240219191634.GY355@twin.jikos.cz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?MmFrT0t4TDNKZ21uTFlOL0g0K29ibS82cFNQejdpb1lNVTd2SkRFQXBneW9s?=
 =?utf-8?B?SmFmVFlyRGxjdWJtWDd5MW8rOXZmMUFMMXlnYXJMODRrTlE5N1dNb2lHVnRE?=
 =?utf-8?B?bmhxZ2ZXY3lpL3REdUx0SW5vQnB6NHo1RVZIZXRSVC92eE4rQnJPaUNOOVps?=
 =?utf-8?B?bXJZUXViVEV6K0VJMFgzRFNhVjMydnVOa25JOTA0bVBPdFhqdnZYZkhpdjB3?=
 =?utf-8?B?QXBUYmJoZzFacGp1d3g2UmNoWnBJSUs4QStBVVBmUFFQdzg1T0c5aFZQRFpV?=
 =?utf-8?B?eVZxM0NkSjk2NUVhWFhiQVJnMDJjNmE1V01WNzVNbWJFbHk0ZkF2YXJEMWhO?=
 =?utf-8?B?c1QyQTRQc00zc29IUVZyaEVLejJ0UE45ZlovQjhZK1BWcC9JSkFhdTJMUFJO?=
 =?utf-8?B?dkdxUFZCQjJFZ2NjQXE3ZWdua3ltMDBvL1hTMTEyOUYxN21IcDhUME90WTU4?=
 =?utf-8?B?QVBJcmdqaUhKc3JrZUJqUG9MOHFYMklmSGg4WGxRY3FreEVEd1p2VEJVenRn?=
 =?utf-8?B?aTdxN3QyNmpjcFowcEVqWGNRbm9KaEhscEdOblBHOXpMWVVacTdFZVVXK1lM?=
 =?utf-8?B?NENFd3RaU1ljUlZWQ09yWTRlNjR3cnY3RmpNK1R2UkpCdWlzYVQ5SE05RVNu?=
 =?utf-8?B?T1lkZUoyRGN4NXB3dXFjeExoWUJZWVhjNUJVblBwRU1EUk5tTVJuQ0JsK2hD?=
 =?utf-8?B?MkVRR1hNQ0xlWHZmUnZwNFhQdVNLbWVPSVRiT3krVmZoUmMvb3IzQlpDb0NB?=
 =?utf-8?B?aERZRlN3NHZCUVNjMlFHaGwvYUZyOWd5VGRHTkFxSVFXSDZvUzhua2ZsaE5x?=
 =?utf-8?B?MzNLSE02UXhVNnhGLy9kd2MrMkd0SThrdTVZcjFFc2ZzaUFGZHVtUDIxSjV4?=
 =?utf-8?B?Sk1vaERUM1lCNlJQS0NVMmU2MTVCRk1PTHA0SXdQb1puekp0ZFNqL21US2gx?=
 =?utf-8?B?dkdERmV0SHQweXpKQlBLOVY3ZE9LZmdCUkk2UDF2M1BmTHhXdG9IeUd6M2RY?=
 =?utf-8?B?RSswRjFCOGx5MHYyZXhacjB4RUJidW9hUDNJSCtLZ0t5OExObzR4OHNXSmFM?=
 =?utf-8?B?L3Vnc0t3TGtGMStIQ0dQcFhqSFJKVTlna21zU05NeDF0c3Z6L0k2V21hMll1?=
 =?utf-8?B?YkprMnllTUM0blBGMWR4NWo1TVhJTHZicVVKOWVVd3FCbkRXZHh4YlZiL2Ri?=
 =?utf-8?B?Z3R0eTNjcVAycTZHOStoY1djTGNyd0tyKzVDYURieEZtcGw2SjdLeWRYZDdB?=
 =?utf-8?B?akhzNWYxQ1Rrc1dEZkFqaXc0bm9jV1FWaGZtK0o0WVJQR3R6blVHTnpTbExV?=
 =?utf-8?B?MzFhemxLQTV2UGhmbU9iSjY4UkxGYlFlYi9oM0V6TEU3SUt5YXRJZm9YeTYw?=
 =?utf-8?B?Rk9OT3VCSVp4UENMcnUxeHhEUnRFZUZLZkJuNHF3c0V2cSt0SlVGQWFNbHZ1?=
 =?utf-8?B?NW9kdS9uVjhHamUwWXBZUXY1VVptWlhMQ2cxZ2NXbEdlcjFYNHgrSVpPZmdP?=
 =?utf-8?B?VGdVUXZyU202LzNnNlUxZXFqQUpBYm5BaU1renMzZnEvbTBBWmJtdmlFNkh3?=
 =?utf-8?B?cWdZVUE1bnQyTGwxVlFROEFQQVZ2RkYzb1VtSFRtYXdvSE5IQ2tmYUYvanM4?=
 =?utf-8?B?UjlCTERIMThLK3FNNjdOVG9TSnV2Ym1IWVIvVzRCZkxJVVY3dlhrWFZiT1pi?=
 =?utf-8?B?NTFVd3Bia0R6aUJEdXAzbVBTZW9IVTBUMm9tdll4NWh0T0VvRUttcU45OTQ3?=
 =?utf-8?B?TzJYU2xIZUVHT29TaGJSTGVmdStRaEFYWktjU3pZV0gvckM5SDVkZWt6TTA1?=
 =?utf-8?B?dTFzenlyUGNRTlRXUEQ5clF6eUsyS0lSd1R6b2xwR1VmLzZ6c1hNVnZ2QWlt?=
 =?utf-8?B?M3ZUZWUvVEhGcmprS3gxaVAyeEdLdlU3alF0b0diM2d5MHpvTmcrS3gxV0cy?=
 =?utf-8?B?Z2xHbTZLZ2QxRXdoRllTUEhnTmxLYkpQa1J5Qkc2eXZRTmd0V0J2aE9VQVJa?=
 =?utf-8?B?TFlMZjA5Qk15MWlTdStIck4xcktScEk5Q0FTU3lXOVlhSlltd0tqTFNEaWMx?=
 =?utf-8?B?TEtPS0VBUit5VG5WOUhyQ2Z2dDg4enpyZDFoN2M5bksvL2ZpUmZZaGN1N051?=
 =?utf-8?B?SDVFczlxM1F5VkNWNlJ4MTVuaFFzeFp2Z2hMTGNXZWZydEI1UVhUWjNIYVFO?=
 =?utf-8?B?RlE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	PdtfroX0xnD3p3rcSoC9BAxLCOfC3nTs/PnAiYDmaLSBBYTiW+clYXBTLdAQQLCtmwNjx+Fxk6/PukKkGiTdV4cmaKupoF9R8lcTqKjIoIKmdQ97qDTMhpz77nq5NaTl2DxKkps7Sq9IV50XMMRz4j5KbLzr1/vfq26YAIIyho11pI0wyiVlulRBc82pg81LzEhROv4mmVisZGa9f++wHLy4IlNQyOw8IcALrXiet+28XYmhCI/fctYyR/QQrr1fl38rpr41TnpFy2q9ASqDQ+MEyBIT07zQF2TY3333+fI0/0g/jP5hyub9wn7enMaWjdOsmFZtr7cjO9UCqRpmJa0KeoATNn5gEJbLqUqIMy2DjRPbuYBtXYmHOhdeZRILrG8/d/SvVuC0z0GdizWuOEZZ8X/RYDPp5UaGnu39T/wlBBLKV8Q18wr37Sg7mHUk42gEXb9ZPtJNVLXp20Vc7KbxOg7P0oLlCCyCgj2IGXNyQ2piMkgJlZ1h2xg8bgLYAd8CHXomZ/DtTPt6K2l7zE6mhVLrZ7jtFNPQXOtOlMLxJJbz2ZkfyNxxHUSZVqEKs4thyQakyEE2Rep07iIT+M479/GiFR9/6FFuei09Xc8=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1b586e4c-12ff-4e05-a441-08dc31ebe774
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 08:14:05.2703
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EGLtLwmXy+k8xzdq6BqpgeeO3uhCoaNaGO2FQNx78upXMIh/zGBmg4QLcygCHoFLwo0Ekz9vEuZMoqvaoRkIuA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4391
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-20_06,2024-02-19_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 adultscore=0
 mlxlogscore=999 bulkscore=0 malwarescore=0 phishscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402200058
X-Proofpoint-GUID: FnTaSnPjP2TPx9dYhN_nBgE0j6MZzcRA
X-Proofpoint-ORIG-GUID: FnTaSnPjP2TPx9dYhN_nBgE0j6MZzcRA

On 19/02/2024 19:16, David Sterba wrote:
> On Mon, Feb 19, 2024 at 01:01:01PM +0000, John Garry wrote:
>> From: Prasad Singamsetty<prasad.singamsetty@oracle.com>
>> --- a/include/uapi/linux/fs.h
>> +++ b/include/uapi/linux/fs.h
>> @@ -301,9 +301,12 @@ typedef int __bitwise __kernel_rwf_t;
>>   /* per-IO O_APPEND */
>>   #define RWF_APPEND	((__force __kernel_rwf_t)0x00000010)
>>   
>> +/* Atomic Write */
>> +#define RWF_ATOMIC	((__force __kernel_rwf_t)0x00000040)
> Should this be 0x20 so it's the next bit after RWF_APPEND?

Support for new flag RWF_NOAPPEND - which has value 0x20 - has been 
picked up on the vfs tree for 6.9 .

I had been just basing my series on Linus' release so far while also 
trying to anticipate any merge issue.

Thanks,
John