Received-SPF: pass (google.com: domain of linux-kernel+bounces-72530-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <d27bc0d9-1a7f-4451-83ec-bf24df08f12e@oracle.com>
Date: Tue, 20 Feb 2024 08:19:37 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 10/11] nvme: Atomic write support
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>
Cc: axboe@kernel.dk, sagi@grimberg.me, jejb@linux.ibm.com,
        martin.petersen@oracle.com, djwong@kernel.org, viro@zeniv.linux.org.uk,
        brauner@kernel.org, dchinner@redhat.com, jack@suse.cz,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org,
        tytso@mit.edu, jbongio@google.com, linux-scsi@vger.kernel.org,
        ojaswin@linux.ibm.com, linux-aio@kvack.org,
        linux-btrfs@vger.kernel.org, io-uring@vger.kernel.org,
        nilay@linux.ibm.com, ritesh.list@gmail.com,
        Alan Adamson <alan.adamson@oracle.com>
References: <20240219130109.341523-1-john.g.garry@oracle.com>
 <20240219130109.341523-11-john.g.garry@oracle.com>
 <ZdOqKr6Js_nlobh5@kbusch-mbp> <20240220065553.GB9289@lst.de>
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20240220065553.GB9289@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?MmRZT2c4QWRTVWtpS0toMVZpSnR2b3FlckI1K0YzV0x3dWJ4QWM5bEllUnB2?=
 =?utf-8?B?TEdDSnQ3c0V1MjdKL1BzaDEyYkdmV2QrMHpSMGMvdXh0Tjg4Um5aWVppMEY5?=
 =?utf-8?B?aXRKRkF2aWNzSExtQkRmU0F6YXpKYjlrTmc3c2JHQ2VvKzRkRFVnbXJDMENT?=
 =?utf-8?B?MTVxRlA0RnlibW5CYjlNY1hSUWhvd3NrclFqODZjbklMcWFvay8zei8rNmdC?=
 =?utf-8?B?ZFQrWDdoMVdya3RsNURYVUVaT0Y3TVFFb1NjTTVKQXp1d3I4N1lpN2dGTitv?=
 =?utf-8?B?cTZ5QmxXeE84MG9pdk0yeTh5RVlOaVgraTRLZG0rMElxL2Znc1l4UFdBU1Aw?=
 =?utf-8?B?SHVIY0lQWktpMFB0N2JyaURXQnhWSzF5Ry90Tk8wWGpkOHZXNDlleEFNbUxR?=
 =?utf-8?B?NTZ0eTVYSUpjOHV0Uisxalp3c0gyVlVvOUxvL2VHbHJwNjhPQnoyYUVjeEd4?=
 =?utf-8?B?WWNveFJzWU5zb2k4eFZIYkVhanpyeHR1UmRBNEo1Y1c1UHBxVHZNWG9oZGZG?=
 =?utf-8?B?ZUh6cmlGTkZlMWZmN1o1ZkswcTFQRXkvWVR2TzVHdEwraUZ3aW1jeHEvaEIz?=
 =?utf-8?B?M1Q1U1E4dSt4S25OUS9uT1N2WGlyV3dMZU1QV0EvUVg0NVdyTEc2MjV1OVhJ?=
 =?utf-8?B?T0l5MVFmWExrLy93ZmdOSFpHWERWUzFyMDhGZlg5NlJFcXpSZytpUDFjaHlm?=
 =?utf-8?B?M1BSZEdncG82alEycXl3MzFsQ09IUzNxZHdza21zaVNjeVA0SEdWaWdDU3FL?=
 =?utf-8?B?MkZBT3Z3MG1RTzJKMDB6RVRLMTNKaHFJRzc5cTJsaGdsbXpnU2dUMUFRckxT?=
 =?utf-8?B?SWxKTGRuUmhXdnhyNjgvOGRCL29MYm1ZU09ldnV2c1ZvZFJyMldDVDFUaXNn?=
 =?utf-8?B?S1BMdjVCWTJJWU1GRy9pTDJzUlg2ZXVvdERuQnQ5WjVXdFhaNnQ3NnRYcmgw?=
 =?utf-8?B?RjN2NlRHOEFtaUtVMUFPN3ArS0tOZnhYZ0Q1aVJGQU9OY3NFbGtoYU5vazZp?=
 =?utf-8?B?QnY0a005aE84YS94dytwUUJnbTczenFocjRPRVhuNFYyY0ZBSXorV3cvUTFJ?=
 =?utf-8?B?V1pSUkRYVFE2Q3czV0RKVHQyMnZFRVZacGZqOWxVTi9OZ0JoK3lFb1VUMWd0?=
 =?utf-8?B?eGNJNVRzb3NsVjRaV3piVFRNTTJ0ZU9GREEzcFAvSHVzdEMzMWFSbnBPNzJa?=
 =?utf-8?B?RXVVTlBvRDI2V1kzMkJiVG45cFN0d0VIQUUvdWo0WWtDZDlPZ01JeEh0Zkd3?=
 =?utf-8?B?ZmRnWHhzVUV4bVhnY2lIVEpKVFpCLytHL2xOMEhLc1FtV3VINlcvRzhQZDM5?=
 =?utf-8?B?MVZ4NnJYNHNkZmhaRlRsYTVSMmNTKytQVXJJY0JCQnpMaXUxREt1UlhCMnp5?=
 =?utf-8?B?UDFJajFxSDBKRUZqcmYvTk9qWmZRRk5xTXp0QzVFSzNHazZDZmM3NXVFVUV0?=
 =?utf-8?B?RDRtalRYdHE5M0ZzN2lMTkFzUkRTZXp5YkhWdjJWcEJxYzBwZTkxVlVKQ1Qw?=
 =?utf-8?B?YUxZRU5JdVJSM0FTd016akpkY3BKT2xVZW1IRGc2WmFGUnlwMXU4NGk3UVJK?=
 =?utf-8?B?aDRFUjgvMmg1THd2dEpMRDY4UjhIUHBkQmk0V0JhWDRuQUxjMUU0ZzVENVFq?=
 =?utf-8?B?WHN4V3BSUEpQZHR1TFJyank5amIrTk9FRDlSSHRidkdiaTE0UDc1Tkk4bS9I?=
 =?utf-8?B?T05ZRitaa1hKRTFPSDdBSVBDRytnc2tsRGthZ3RTNTlGRHpkcFgxQTJYbXpY?=
 =?utf-8?B?R2dzU05Bam5ILzhUbFh2L25IekU0bUhxT1J0SVhwNW0zbG1XUXVpSWJyYzBr?=
 =?utf-8?B?L3M2VnZ0eUwzcGZMdGJuaTVaZHFaVHZ1d1NXdXJWSkxLWXo3OUlJNmdEUE0w?=
 =?utf-8?B?YmZhTW4zZm15eDZUVG1NWEw0ZGhva3htWXJXRkdHZU9HaUE4NHc1Zmp3MGJ3?=
 =?utf-8?B?NWNBSmtZWXA4VkgwT2U4V2JNSnhpMWpOVDRBbVN0VUpnWjdlbmVKMlB3eS9u?=
 =?utf-8?B?VTd4UEJVQURRR3c1VjZBeGJDT0lhSUpIRXFMckZVcUFWU3hZaGpmWDl6TUR3?=
 =?utf-8?B?cytOWTdoZXVvOWdpcHAwU1NldmwrSXhKMldBVVQyMEF2Z1AzS0c5TUZYOC9s?=
 =?utf-8?B?Mzl1blVkR1ZjZ1BDR0FoZVVJeTd4Unl4K1BQOHkvWExKZjFOck9CWEkxUVc2?=
 =?utf-8?B?TFE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	++DEM7JkGJ6npCN+QwHzh4om4PMErtnLSLG6K//qBXkYqW/zje1T8uhS0NzIC1Zg50rX1QQVLr/Ic7W36GPeyj4AaXLL2ZkI/jeje3iTUfVHuwcjiyF/mduBVNQFm08twlE4NSAyGfzHESdj9rm1h6oWpcygiUGccctBE4XFZiEPYD21L27+FKY+EoTL5r7xIysQAreXzqmraCH1zHP/UpeIUOCAW1Urb0aPILEO6FAne09shC+Mf2scxu5fLBloZr/WKDpm1CrtfJMIuq+0Zv5pabF4xocuSnNKhOqHn24y3Yll4Eh4/k9/L22YcEZ0aIQ9SeDZp2PQk0O/JuAQ8AIiaLpZZcbnwzrr4prKrUONr7J9KTq5cCJhlz1b9iM/EgKndmBta3j+TQvKKdK398DtEVkpodBiiiu5LwyhI+QZ+4kfyNMe6VLNSBzKd7C8EjoPl2b95Ll97CCMNylF66VHk2pHScHiKQrPWfJajro5t5CZSEAUXg7ym4+1GBPsk6DjdKLP9Kjh36aNmcG4c5rJdvcsgFHlnzUqy9XiD41s2t6to24EN2vFTPHIXXSnC/pFQROaqjw6QdCt3mKs+P/hqe5r14yTbeB86/lvXEw=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 44ffc693-4d88-4334-d023-08dc31ecb0ac
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 08:19:42.7810
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: z/LY2EQRQlz7eUo4fRpz2BgBzFNaEMiGHetTSRLTd5DXgm9DyyWmjVLbAo2ZJ5rpUkmCQ1qLLiw8t8yPr/p0mw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4391
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-20_06,2024-02-19_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0
 phishscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 bulkscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402200059
X-Proofpoint-GUID: WrQetJUHALk82U00GBw_Rr-E1eMpmCW-
X-Proofpoint-ORIG-GUID: WrQetJUHALk82U00GBw_Rr-E1eMpmCW-

On 20/02/2024 06:55, Christoph Hellwig wrote:
> On Mon, Feb 19, 2024 at 12:21:14PM -0700, Keith Busch wrote:
>> Maybe patch 11 should be folded into this one. No bigged, the series as
>> a whole looks good.
> 
> I did suggest just that last round already..
> 

I created the helper function and folded it in, but not the callsite. 
Not folding in the callsite change did not make sense to me, but that 
was my understanding of the request. Anyway, I can fold everything into 
this patch.

Thanks,
John