Received-SPF: pass (google.com: domain of linux-kernel+bounces-72536-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <461d3ede-5d34-449e-8115-1c4558ae31a2@nvidia.com>
Date: Tue, 20 Feb 2024 10:21:34 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] [v2] net/mlx5: fix possible stack overflows
To: Arnd Bergmann <arnd@arndb.de>, Simon Horman <horms@kernel.org>,
 Arnd Bergmann <arnd@kernel.org>
Cc: Saeed Mahameed <saeedm@nvidia.com>, Leon Romanovsky <leon@kernel.org>,
 Zhu Yanjun <yanjun.zhu@linux.dev>, "David S . Miller" <davem@davemloft.net>,
 Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
 Paolo Abeni <pabeni@redhat.com>, Alex Vesker <valex@nvidia.com>,
 Hamdan Igbaria <hamdani@nvidia.com>, Netdev <netdev@vger.kernel.org>,
 linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240219100506.648089-1-arnd@kernel.org>
 <20240219100506.648089-2-arnd@kernel.org> <20240220080624.GQ40273@kernel.org>
 <726459a9-c549-4fec-9a4d-61ae1da04f0a@app.fastmail.com>
Content-Language: en-US
From: Yevgeny Kliteynik <kliteyn@nvidia.com>
In-Reply-To: <726459a9-c549-4fec-9a4d-61ae1da04f0a@app.fastmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cWFGaXNUUDVwVjNHbW5SYzFnSm5FOGxCb2lqOG5pVk5aaUJURlJtYU03RVZE?=
 =?utf-8?B?bkJzS3RoSFhPMkRleHZmanNBSGVjNEpZRUpoNzYvUFhTUlVCRG8vNlh4Smd1?=
 =?utf-8?B?QkhhTE5JOWJnSWRSUzBMWFREUE02bUlFdVZucDE1c0FaVGRzMFVuKzJWVmlM?=
 =?utf-8?B?TU4rdE1FdzI2T1IyR2V2Y0laMEsyak9PcHdBMllLM3FwQm4yczJ3OS9Oek9V?=
 =?utf-8?B?WDlXV0VsR09GZFA0NTY5R1A3cDhhcHQwTFZackMzTmFMUGtwNENYZ3o0V0hL?=
 =?utf-8?B?UHdIZXRzdC9ERTU2OHlNVVlBNVJIZmdlaEhTUHFSdk5nZHNNSmtXdmEzeEpn?=
 =?utf-8?B?NFZ6Umc4Z1hwMThTblorcCtKeEh4ZW5oakFiSUI2T2Q2eGpHUVFCL3VPaWdn?=
 =?utf-8?B?RmlEcWJxMldTbDB4ZlF5cXg5OWMwMVhoQzg5RzR3RGlPWG1jYnVyNW1xTTk2?=
 =?utf-8?B?ZzB0WUUxcTcrOWRDY0FuVkY4eWk5bnVwNFJHdWpBQ2lDcldZTE5pWUFtUXRz?=
 =?utf-8?B?TXRidVZBT2lqYm85eklRbU8xN1ZMOVBXQWEwcE9uN2I4TEU4c2ExdVExWS9n?=
 =?utf-8?B?Q0kvYzFlajVDNG0yZTByUEpmVi9FMC9vbzN5R0V0YWlyZElCQnNRZlZ0WCt6?=
 =?utf-8?B?c3FVY2dMMnZpZGZzUGJGT1JydjNSZ2sxdEpqdUh4ZmZuNVVycFgrb0hzSlp5?=
 =?utf-8?B?czRaTzl0ZndtSWJMTDVLbGVkTm1MQTFHYUtTeUtaQkNyQnVLa3NQb1p0MnZt?=
 =?utf-8?B?MTRJTnU5VFI3UlJxRFNGSUNlaHlyVHRuK0h5alFScy83c2ZXUmh1dEpvOWRm?=
 =?utf-8?B?QlNOdXJnVUxVWEQ2MVNCMEtPRDhoMVdzdEJQMmJSRlJjK1JkOEZjcXBoekRW?=
 =?utf-8?B?Q2NaeTFyeENneWZDcVlzeXJHWTBvT3dDZXdldmJmUHptQUNQVDNsQUxOUVMw?=
 =?utf-8?B?RmxSenpoY0VTSlRoRUN2a2Z1aWZvOWsyNW5LeHo2amtGcDJQKzI1TC81YTBH?=
 =?utf-8?B?bWZTTkNDMWgySW9xTXkzbWtvL0kxM05GWjkyN1JGWG5Fbld4eEhhQ2dKb0c3?=
 =?utf-8?B?L3JpcldXZUIydGp4eFRXaFVxMnV4STRTZVB4QTVJbmZPanNuRVhUWlZ3WWxt?=
 =?utf-8?B?K2JaRDlFRXJZNTg1TzVpKzE1L0kxaDREZ0E5K2F6OVNQQjdiNVpwa2pRV0FS?=
 =?utf-8?B?dkRXMzNyWThneUtYRktacTMyRlhvSVVnQjdvNVVTc3ExbGR2TnpYQTYwZ1Vw?=
 =?utf-8?B?a3hCcVVFTnBTTVdnQnpVS1hReGk5YkZxRGVaWGthb3lDcTdYSU9JSEtIVkM2?=
 =?utf-8?B?TUVUN05iSWRDWEZvZXloZzJnVDUvc1ZaN1ZBTmIxeXhBbEdlR3ZDTTZ4NXpZ?=
 =?utf-8?B?QlVFcGpWZDFIUk9RUk5WZGs3NW1VZFhJa2ZPWWtFNjQ2Q21QOGMrZnpubFJt?=
 =?utf-8?B?RGVBYmJ3enM1UUdPWjBIck9Xak00QUd1bS9ycU9WMWJkT3ljUGpaRHAwREo4?=
 =?utf-8?B?YkY2cTRqTTFFcjViaGcvMzh0cjJod3R0alpsK3N3OXhWWjJFdWVtSjhkNXZ0?=
 =?utf-8?B?aGtqQ0lUcWdJaWFhZC9QRFVpcFV0SnZBbmFnaUpYaG1VL2oxcVBnSnRrYnRp?=
 =?utf-8?B?Y3RlZjlqVytXblAzMTJ0T2E3a0liQmJRNGQyTXhhbnhRVjdwZDNFYVNZUExM?=
 =?utf-8?B?emdhcEFsOURKVTluL2ZEeWJtcHdyeVlNckRGc3RzUURZSE9vaFNvNTZFNGxa?=
 =?utf-8?B?V2tJSnBzU3ZnVGFzUlBYYVFUbzJOQXJzNkRzQ0g4SzJFVC9yTGZyN0tmcjNF?=
 =?utf-8?B?WWFnNjVUM1NrcDNyQ3haN0UxbTNLVVF4dWRYTWNCaU54RVREYjdST0xGQm1D?=
 =?utf-8?B?c24zdVU3TlNRdlpwMDlrb21lUFRqQzJ5QlcyLy9HTDJmcTRMNEQrOUYxbDdN?=
 =?utf-8?B?OTVGY1c1dTU3aVBaNzMwQU04UFRITURSYkNLQzk1UlYzV0l0WnEvUFFDbUpO?=
 =?utf-8?B?VVFSZmRWRlJkNHg3M1FaOGs5d1FxTE5VUlJaWDBYMTBOYzhRUEFydUVaK0o3?=
 =?utf-8?B?QjhCQlJyNEt5SCsxdHpHSkE1UTB1d3VseEt2ZlhxMmthdnlWUkJ1VFhmTU9X?=
 =?utf-8?Q?80kwo/26zNkJvpTDNflzvPWbF?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c5e3c035-ca24-40c3-6e1d-08dc31ecf812
X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8086.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 08:21:42.5547
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +D0hMwyA0sTFJ3TN0qcaoukaAZ/XHBpjT4kqt2sUvi+hx3fZaBs3I0ckA0+p4aaD6lggUPKsixGgLxRBbIvs/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7970

On 20-Feb-24 10:11, Arnd Bergmann wrote:
> External email: Use caution opening links or attachments
> 
> 
> On Tue, Feb 20, 2024, at 09:06, Simon Horman wrote:
>> On Mon, Feb 19, 2024 at 11:04:56AM +0100, Arnd Bergmann wrote:
> 
>> Hi Arnd,
>>
>> With patch 1/2 in place this code goes on as:
>>
>>        switch (action->action_type) {
>>        case DR_ACTION_TYP_DROP:
>>                memset(buff, 0, sizeof(buff));
>>
>> buff is now a char * rather than an array of char.
>> siceof(buff) doesn't seem right here anymore.
>>
>> Flagged by Coccinelle.
> 
> Rihgt, that would be bad. It sounds like we won't use patch 1/2
> after all though, so I think it's going to be fine after all.
> If the mlx5 maintainers still want both patches, I'll rework
> it to use the fixed size.

No need for the first patch, so only the stack frame limit
fix is needed.

Thanks,

-- YK

>       Arnd