Message-ID: <477632AC.2000502@s5r6.in-berlin.de>
Date: Sat, 29 Dec 2007 12:42:36 +0100
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.11) Gecko/20071216 SeaMonkey/1.1.7
MIME-Version: 1.0
To: Dave Young <hidave.darkstar@gmail.com>
CC: krh@redhat.com, linux-kernel@vger.kernel.org,
       linux1394-devel@lists.sourceforge.net
Subject: Re: [PATCH 03/12] firewire : Use mutex instead of semaphore in driver
 core
References: <20071229010602.GD2883@darkstar.te-china.tietoenator.com>
In-Reply-To: <20071229010602.GD2883@darkstar.te-china.tietoenator.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1124
Lines: 35

Dave Young wrote:
> --- linux/drivers/firewire/fw-device.c	2007-12-28 10:02:38.000000000 +0800
> +++ linux.new/drivers/firewire/fw-device.c	2007-12-28 10:05:00.000000000 +0800
> @@ -26,7 +26,7 @@
>  #include <linux/delay.h>
>  #include <linux/idr.h>
>  #include <linux/rwsem.h>
> -#include <asm/semaphore.h>
> +#include <linux/mutex.h>
>  #include <linux/ctype.h>
>  #include "fw-transaction.h"
>  #include "fw-topology.h"
> @@ -731,9 +731,9 @@ static int update_unit(struct device *de
>  	struct fw_driver *driver = (struct fw_driver *)dev->driver;
>  
>  	if (is_fw_unit(dev) && driver != NULL && driver->update != NULL) {
> -		down(&dev->sem);
> +		mutex_lock(&dev->mutex);
>  		driver->update(unit);
> -		up(&dev->sem);
> +		mutex_unlock(&dev->mutex);
>  	}
>  
>  	return 0;

ACK to this part of the series.
-- 
Stefan Richter
-=====-=-=== ==-- ===-=
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/