Received-SPF: pass (google.com: domain of linux-kernel+bounces-72563-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <d31a99ae-448b-4c0a-9ba6-fc82e24ad25c@oracle.com>
Date: Tue, 20 Feb 2024 08:31:08 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 02/11] block: Call blkdev_dio_unaligned() from
 blkdev_direct_IO()
Content-Language: en-US
To: Keith Busch <kbusch@kernel.org>
Cc: axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, jejb@linux.ibm.com,
        martin.petersen@oracle.com, djwong@kernel.org, viro@zeniv.linux.org.uk,
        brauner@kernel.org, dchinner@redhat.com, jack@suse.cz,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org,
        tytso@mit.edu, jbongio@google.com, linux-scsi@vger.kernel.org,
        ojaswin@linux.ibm.com, linux-aio@kvack.org,
        linux-btrfs@vger.kernel.org, io-uring@vger.kernel.org,
        nilay@linux.ibm.com, ritesh.list@gmail.com
References: <20240219130109.341523-1-john.g.garry@oracle.com>
 <20240219130109.341523-3-john.g.garry@oracle.com>
 <ZdOklTSG9tHuYtGi@kbusch-mbp>
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <ZdOklTSG9tHuYtGi@kbusch-mbp>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?WTdmc0k0T0NiczlQT0lxbmlQbjd0UVlGdjZRUHBFV2Q4N2o5MTN3bG81ZnRy?=
 =?utf-8?B?emtqSDF6UG5WY25DRDlmZFFCTmRTUXJqdkpMcCt2Vm1WVi9HdkdQTXZyT2tp?=
 =?utf-8?B?MjhBUXJUeXBSVmF6cnUzNkk3dHZ2MnBRQ3RKMGFoU01OcGNYdjd5RTgvR0xk?=
 =?utf-8?B?YkZYRFRMbksyZ1l1a2xHVmZkWFVDQXFYNjEwaTlKTS9WelpkQkl6cC95Vnkw?=
 =?utf-8?B?WGdJNVJ2Rk45TUhzNENPQTB1cFFjZktSV2l5UVM5cnR2bk16Q3REa1hsa3Qw?=
 =?utf-8?B?dm5pNytBN1grbnN1VmZqakxkZWhlUGJJVUpHN1FZVndHeHBWR0pPOHRtMnI5?=
 =?utf-8?B?dzNKY2QvUStIdlJVekRIVVk2UUVMNmhWQ3hVcldrZ0Nva2dyRkQ3b212eXIw?=
 =?utf-8?B?cGU2dG83YTd5TC8zZ29LTkMyZm9QeVN4ZnVjYkRIVXVraGg5ZlpRY3Iya1FR?=
 =?utf-8?B?MVZGL0RXUm1EbUw2ZUpMWGFOV2huN0dtOWVIL0ZoV0pJd3pDSWZHNmlSL1dH?=
 =?utf-8?B?QjVJQTM1TkR2RXdkUXRQY3ZweXhQc1lPeXFGckNkcEFXODdKOUVkVmkyTnYy?=
 =?utf-8?B?eG5YNlZiZHB6ZlQ1QVlQRmF0ZEl3VkNwRWpkTHNyMFJhQ2ZCdTMyR05GZWtx?=
 =?utf-8?B?WHlGMFR2eVhoYzYyQlRGRlp4Y0JWWExhRVIwdTdVMnk0Q21LYld3NXNvVzI4?=
 =?utf-8?B?UVh5aE1HdlZtZDRqTHZWQnJjOTZ5UUNUeE1td2h0T3E1NERxeFJ4K0ZwVnZ3?=
 =?utf-8?B?dGIzUHdDclNOOXdHMzd2TDVOQnFORFlEUFYyRUliV0RGbDhhTkF1c2Q2RWo5?=
 =?utf-8?B?OTN1TUJXTXpvTjIyeFJIU0x6eWx5V1EraEVBQUNaalZBUUp3UklieU0wTzRs?=
 =?utf-8?B?aEpPeTE1ekVsdG4zci9vV3loTFBOc2hSSlI4VG1MNk1DeDVuRUNvcVBhYlds?=
 =?utf-8?B?TkZZZmNMaGZPSms4R1JVWHhLNlFwT0JvbFJkdTd6UFpKRzJ3QXBqN1EweWQr?=
 =?utf-8?B?WExrQlhmWlZYSFg0cjB1aEQxTUcySW9QejJpSmNoUjY4UTIvVnc1WGlvT1A4?=
 =?utf-8?B?aFc4SUFlTGViOGxka3lKOTNFSU9YR2hTbmYvQ1F0Zm1zQmNwVmMyUHJnMGNh?=
 =?utf-8?B?a0M0TWlTcHJpRytDYzdycTJ4cnJKNkw1STYyWUJINElUY0g4aWw0a0NNWXdB?=
 =?utf-8?B?dXQrMmNuVXdwaXRGNlBmNmF1Vzd6aG9nVnVzd29QNWYvR0lZVktyZDZ3VDVK?=
 =?utf-8?B?SXlacUlIalVIMkJXRGVEWFZ3RlI2QTMrSFZwTzVEdDNpQUJZaEpWRHc1NlVk?=
 =?utf-8?B?YksxWjdLQm0rYmdKRVdOYnlwblI2cjV5OThzNVBseS9JMkZmT2MzUWk4SFpE?=
 =?utf-8?B?TzJrQlZqUlNMSzlwWjJ4TDJZUGxQejFZMWxORlpSY3pRaUV5c0p0WjA2VytW?=
 =?utf-8?B?R2FGVmZqeEFsckFXR25VUjAveE1FQi9Dd0dWSXVBQWhScGRmb0xiYXJqQVZH?=
 =?utf-8?B?UlozOG8xNFBmZkhNVU5KQmF0TDJGeXFicFJzMVluYmxzUGlhWDUyRk81TXRh?=
 =?utf-8?B?S2d6RkhzNG1SQjVLdjNNbXNmQ2FQSXZJMjAraEc3M002QUZnTlI2aE8vc1JU?=
 =?utf-8?B?ZCtkOFp6aXkrYWhLZzhReHpDSGhtVjg2NkxhNXZ5N1lETEFDbmNyZGl3aWZF?=
 =?utf-8?B?b1VqRHVpdkM1alh6eDFLd1RxTXhIUDhMTUhZL3NhbkRjUjBHYUZkSUovWUpu?=
 =?utf-8?B?cHpxMUZseEVCZHpkaE5mOUFXWE42N2ltN0Z5WnF0QktQU1hRaFV6RDkya3Fj?=
 =?utf-8?B?UnRmWk02MXd0NmthTGc0Zmxpc1FpZ0RRK2RPMmtJQzg1OTBQWEVGaWJ6S1Vh?=
 =?utf-8?B?L284QXU5b3p2eHJnMHBFb09KYkhlYW1WbmM1dHU0KzBaMnJEdk5rbjB5WlpK?=
 =?utf-8?B?UU9hSklqeGZELzRRREI0Ny9tZzhJOUlOaElKMFJjb1psSVcyakNGaTYvaEcw?=
 =?utf-8?B?MUdvU3VJWmdoMU5yODNQYWFVY0ZyVVVackNacEYzdmZleUdnZWpvK1RJYkxl?=
 =?utf-8?B?a3JZd05pWlBTa0FrUitjcm5FVXFvSS9nYWFIVGpDZFZBVFA5ZjdVQlA5R2FW?=
 =?utf-8?B?cTZ3aXZkMkVWMDJSUjJtWmdXam5WWWUybmEzZUY5cWdyY3pRMDZKekJIMmcz?=
 =?utf-8?B?amc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	WzBCWlwrrAcqVQlmNxYbMc43howIJGMze1fwg6HHIMqG3DrNLdYorrW03+i27X6qYdxnzcH0I+Fp35vZdDhs9+di4/PuDujlCwIBHaGaafcZ61tFIlv8xJlrdb6jvzNs4QADZGAVjWMMZNay3GiAjxnza4tRr1yrRI5aQLj2/O6CxwvknLyBgRTt0iEae4/8eTzL+0A0TzhVzXTG3E4bMl9JTm+cp+FzQi2ZjyaeLmPwSq2ZPOHVcK6o8pO8B55BI6Lr+QJArtUdkSmtLeTJm8pPkKXpUO/rAzqDp++cyN8YiJWDhxDDvmS7WOfE5bVyQTPOkbE6K7AbKMcwT6BFt2hU5cVgGZZojCbNISpn2DuQu3Ay67NZaM8BTkxVdce1qGbVtCgiYeDBMpkTJGeKf4GPH0ExU7LNJ8YcjxhusQpMiza5YmH7cazxfoUH7iMeOjuLHVwuJuGoJjpuu5K4Mt68oxuZWI0/40fg/GgPXCA5ljC+I8Ta8NCBvayCGENnjWFVWT3eyID/U6FE2Wo0T9X6R8C6RMo4+MxLsWGxj64rEJTnmWRsu/CzUkTtXXcjUrijzcPSaftNtKJdujN88gjs5VwQQT5YSTt/DXQyce0=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 33eb8deb-a7c6-4c35-f461-08dc31ee4c06
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 08:31:12.9036
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zLDakLeWIuxZ8wFlWVx2shX/G083FPFMvz2XPt4FH0dFA33Ft7AIptbt4HDqRENpxgumg6hpG5YtefMPVE8wSw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR10MB7726
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-20_06,2024-02-19_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 malwarescore=0
 bulkscore=0 adultscore=0 suspectscore=0 spamscore=0 mlxlogscore=889
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402200060
X-Proofpoint-ORIG-GUID: YVXq-oZyAjtrTAZdv9u5FBUgKzxiH7tV
X-Proofpoint-GUID: YVXq-oZyAjtrTAZdv9u5FBUgKzxiH7tV

On 19/02/2024 18:57, Keith Busch wrote:
> On Mon, Feb 19, 2024 at 01:01:00PM +0000, John Garry wrote:
>> @@ -53,9 +53,6 @@ static ssize_t __blkdev_direct_IO_simple(struct kiocb *iocb,
>>   	struct bio bio;
>>   	ssize_t ret;
>>   
>> -	if (blkdev_dio_unaligned(bdev, pos, iter))
>> -		return -EINVAL;
>> -
>>   	if (nr_pages <= DIO_INLINE_BIO_VECS)
>>   		vecs = inline_vecs;
>>   	else {
>> @@ -171,9 +168,6 @@ static ssize_t __blkdev_direct_IO(struct kiocb *iocb, struct iov_iter *iter,
>>   	loff_t pos = iocb->ki_pos;
>>   	int ret = 0;
>>   
>> -	if (blkdev_dio_unaligned(bdev, pos, iter))
>> -		return -EINVAL;
>> -
>>   	if (iocb->ki_flags & IOCB_ALLOC_CACHE)
>>   		opf |= REQ_ALLOC_CACHE;
>>   	bio = bio_alloc_bioset(bdev, nr_pages, opf, GFP_KERNEL,
>> @@ -310,9 +304,6 @@ static ssize_t __blkdev_direct_IO_async(struct kiocb *iocb,
>>   	loff_t pos = iocb->ki_pos;
>>   	int ret = 0;
>>   
>> -	if (blkdev_dio_unaligned(bdev, pos, iter))
>> -		return -EINVAL;
>> -
>>   	if (iocb->ki_flags & IOCB_ALLOC_CACHE)
>>   		opf |= REQ_ALLOC_CACHE;
>>   	bio = bio_alloc_bioset(bdev, nr_pages, opf, GFP_KERNEL,
>> @@ -365,11 +356,16 @@ static ssize_t __blkdev_direct_IO_async(struct kiocb *iocb,
>>   
>>   static ssize_t blkdev_direct_IO(struct kiocb *iocb, struct iov_iter *iter)
>>   {
>> +	struct block_device *bdev = I_BDEV(iocb->ki_filp->f_mapping->host);
>> +	loff_t pos = iocb->ki_pos;
>>   	unsigned int nr_pages;
> 
> All three of the changed functions also want 'bdev' and 'pos', so maybe
> pass on the savings to them? Unless you think the extended argument list
> would harm readibilty, or perhaps the compiler optimizes the 2nd access
> out anyway. Either way, this looks good to me.

Yeah, I was thinking about changing the arg lists. Specifically adding 
bdev, as that lookup takes many loads, so maybe I will make that change.

> 
> Reviewed-by: Keith Busch <kbusch@kernel.org>

cheers