Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1597358rdb; Tue, 20 Feb 2024 00:39:09 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXf4eHbhGKIlTNW/60DquSpIugHPJSuWd0lgbBbwHcIIOP5asx+nKyGfdjIAt9VqAg2ZvK9qReGUxZC3Y+DAfsjY6KE9PA4WJyAe3y4Cg== X-Google-Smtp-Source: AGHT+IHd6gOOUjqOJf3IEceEQidpzfEMFPn+54JaG2CxLplt8sA0mOesMFQIMF+sCewkedgDn5HX X-Received: by 2002:a17:906:f745:b0:a3e:422d:a27d with SMTP id jp5-20020a170906f74500b00a3e422da27dmr5319049ejb.47.1708418349678; Tue, 20 Feb 2024 00:39:09 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708418349; cv=pass; d=google.com; s=arc-20160816; b=kV3reBYxe1Y8F92SvfiqPq15OkiZP+NssrWdaTdQoLukOCKlhnPGAWfILY+ARC5/rf 977U+dZ/06TZemNdqRkkItruC2iF2Q8IsA44gtQYc1mnH+NI0vJ0F7xlRB5JHV63Bg2C szloLTF2V3PQh1jhA6ggGd/lN0fIDxYC/qUEE7ZR1zF5FQDpeW5f/lo7yj9BROkLUPiI FpblpuPxWrhXIjjge68Tr9dHwUwsKM6r/oaRO674mbj7/Mper5T0FtA/nRfTMp73OQLx 5ORSJCZe1rTjuytX7TpBLIRydN5+14sG/xUT8TcSmzSNeSphZ6SgtnxY6/4ZrJxKzsm9 ChFg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=xaQQvYpzmBVHnCracW1/zWSt6cgfuwxk6XJIuCevoKo=; fh=k0KwIAxxGDmvbEv7HMCYF6Iskkhm+K+W/cyBZ02i0JU=; b=xqNea7dBDoIpHs+81lHXKCKQJ9g55HM0Llrkm6NaZdiIltSLazAsoHmQ2lajA3DTs3 tZx77FZ4F2PrqIbGmxXlBevmNp8bmZeqwodshitKiKzO5k39HxPHnc5V4Pgg/XRWOxIK BARzWDrnZeGUqzL/fUtIke+d9HBdYDfO089B+LMOWhbPAyDH8kdw0k1n+AEg1pdWL4dF BCW8dQkFwh7Ne9wxRWPvY5P0iwvE6s5WgBT9s/FHCita1HeqSeVgr2b3AC7k+K43df41 CaPNUJDulrHG1Ms8x66gwmfJnSh6o7WBwHduIc4o8AQFz7jyfWNEbyPYdOMQqx/+wBDb jXLQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="eziz/zho"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-72579-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-72579-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id l9-20020a1709061c4900b00a3eebb345c8si630086ejg.569.2024.02.20.00.39.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 00:39:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-72579-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="eziz/zho"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-72579-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-72579-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 701FC1F21E37 for ; Tue, 20 Feb 2024 08:39:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E63D95D460; Tue, 20 Feb 2024 08:38:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eziz/zho" Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D5EF5D46C for ; Tue, 20 Feb 2024 08:38:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708418339; cv=none; b=Ll0w/JRkVTgOB0tWTAWsarmYOZ4xRZ8+PopxOddb/WYtcE/m3o/4iijNZ3ZadcshNqL+CqBM07juzsfd5BgvR5QIJA4igFo7eYTDgceTrXp5R4+TMMSHyhbx2I4rj6ucZN6Xmr6VuWjgWf0aq1/cPbX9jPdLP0kR4jl3mCR0Clc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708418339; c=relaxed/simple; bh=xaQQvYpzmBVHnCracW1/zWSt6cgfuwxk6XJIuCevoKo=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Q/9dZNDIR/plSHEmLr2suwhqGfIDDjN75Id20bmGT7ALYYrQQGS6KDowXN4nTCdMaytTZhp9uiIf05OEoOZq5zWJd4GCoowWRkaZl7GnSF40QeXU6esNjlR/uUa/e+1ohZEDGPxM2muKDHyp4FPSXFGxs2aFFQKXUluxA9S1xRI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=eziz/zho; arc=none smtp.client-ip=209.85.128.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-607e707a7f1so49657037b3.2 for ; Tue, 20 Feb 2024 00:38:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708418335; x=1709023135; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xaQQvYpzmBVHnCracW1/zWSt6cgfuwxk6XJIuCevoKo=; b=eziz/zhouO07dAp2r1xXi+RG/aEiEh8pdV+07MwbXl4BWTattvvPJe3YohtHQOPnl8 823bE3VxU3wFxlKF/RWMqO3uVxT6elzrXUd3ZGX64Od7GdzPv+mh3H8EzHoJGvGAxwBA X4z47iX5AOYnh0HtJ/b9Am1qQlI/RTarO3hVxdCySD6/RJZR+7+J+RodCC35wNkpm+zD XbfdQpljkO6+zTtB+QdiMo2MdqydrDapLBNmMYDUk97BfI0RJjwZHem0QHSVBOWXXvZR CUD2olAhdfh9r/8wtfaH3XJsZt3vIT/4xl3TJLJNUxd9dy/cIhf++kKfiBpYIAJzbWxv Cwcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708418335; x=1709023135; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xaQQvYpzmBVHnCracW1/zWSt6cgfuwxk6XJIuCevoKo=; b=swEr0PipDI5Se4pmS3ym4kTXLQlHk2rhn/l9weEOT05OtpLoafSwdfs5dX4qjdm0I/ 5xf1HFRNYZks4rYGOAPBdMXKG9q5kVyX+XIzafhVqMTtrSJ56Yd33AEr+dXizzBrxVMJ QsWPlo0kMiOBNp9N3xkNlOvBg2iLbgNC/QEyeq56YT2ada+zCvjGa/nPhRKRJo94aFcY CRv65SAe66uQr2H8a0F/mETICOp0exoYdDYwcyTablkD6S/UHrbdSzVMJAFiL0NvHm8b Zkd5EI3lkU8KLqSBLJI1em59rRf2e16QG1CPdv9f6W8HIvgjP0Zh/Zs1SpFLhfdTxzRq FYxQ== X-Forwarded-Encrypted: i=1; AJvYcCUClCOXRu4oXUUNUnum4GHI/Nz2c4HhAr4UHpXnYXtNa2fMxPgBQRhN3ndluTDXjDE5dV1Yr4IojsgauyXfEj3La2rfhHVGK96kGG0A X-Gm-Message-State: AOJu0YwnkPeUgijmVpRRucn/njMiawykVpeQJz9vmN1NlBvOugptOBPv 7FeZU4GqKR2BHlXLk/T51YZ4AGg6DCkIlQVu0yvBolHRZ3utWwGb0l7cYMFGHtEo9TViHxrtSeE 3hswsgxI0E94+PUj9n072x48kuvA+fr+HM2V+8g== X-Received: by 2002:a25:83c4:0:b0:dcd:59e4:620c with SMTP id v4-20020a2583c4000000b00dcd59e4620cmr12705446ybm.49.1708418335046; Tue, 20 Feb 2024 00:38:55 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240220045230.2852640-1-swboyd@chromium.org> In-Reply-To: <20240220045230.2852640-1-swboyd@chromium.org> From: Linus Walleij Date: Tue, 20 Feb 2024 09:38:43 +0100 Message-ID: Subject: Re: [PATCH v2] gpio: Add ChromeOS EC GPIO driver To: Stephen Boyd Cc: Bartosz Golaszewski , linux-kernel@vger.kernel.org, patches@lists.linux.dev, devicetree@vger.kernel.org, chrome-platform@lists.linux.dev, Douglas Anderson , Pin-yen Lin , linux-gpio@vger.kernel.org, Lee Jones , Benson Leung , Guenter Roeck Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Feb 20, 2024 at 5:52=E2=80=AFAM Stephen Boyd = wrote: > The ChromeOS embedded controller (EC) supports setting the state of > GPIOs when the system is unlocked, and getting the state of GPIOs in all > cases. The GPIOs are on the EC itself, so the EC acts similar to a GPIO > expander. Add a driver to get and set the GPIOs on the EC through the > host command interface. > > Cc: Lee Jones > Cc: Linus Walleij > Cc: Bartosz Golaszewski > Cc: Benson Leung > Cc: Guenter Roeck > Cc: > Cc: > Cc: Pin-yen Lin > Signed-off-by: Stephen Boyd This looks good to me! Reviewed-by: Linus Walleij Yours, Linus Walleij