Received-SPF: pass (google.com: domain of linux-kernel+bounces-72590-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 20 Feb 2024 09:42:21 +0100
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Vincent Mailhol <vincent.mailhol@gmail.com>
Cc: Oliver Hartkopp <socketcan@hartkopp.net>, 
	"David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, 
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, linux-can@vger.kernel.org, 
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] can: raw: raw_getsockopt(): reduce scope of err
Message-ID: <20240220-tremor-suspend-36bc012b061c-mkl@pengutronix.de>
References: <20240220-raw-setsockopt-v1-1-7d34cb1377fc@pengutronix.de>
 <CAMZ6RqKPUUrgfVpdu4y=mGUFjNTbfH7q46ZwcMwOn6zEwfHnZg@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="g4vopqhpjlyktekh"
Content-Disposition: inline
In-Reply-To: <CAMZ6RqKPUUrgfVpdu4y=mGUFjNTbfH7q46ZwcMwOn6zEwfHnZg@mail.gmail.com>


--g4vopqhpjlyktekh
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 20.02.2024 17:27:05, Vincent Mailhol wrote:
> On Tue. 20 Feb. 2024 at 17:16, Marc Kleine-Budde <mkl@pengutronix.de> wro=
te:
> > Reduce the scope of the variable "err" to the individual cases. This
> > is to avoid the mistake of setting "err" in the mistaken belief that
> > it will be evaluated later.
> >
> > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
>=20
> One nitpick to remove a newline, but aside from that:
>=20
> Reviewed-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
>=20
> (as usual, I do not mind if the nitpick gets resolved while applying).

Thanks for the review, fixed that while applying.

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung N=C3=BCrnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

--g4vopqhpjlyktekh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEUEC6huC2BN0pvD5fKDiiPnotvG8FAmXUZeoACgkQKDiiPnot
vG/JKwf9Fjdu8IgIhXwRaJizysOl76e9n79st3d0kq2yQau5Hlgw6sjOW2IoGlkS
TAk1YnxkerpQSjjJ1i550qZ+kmAXFPl8Lp3DHfddcIciQYqiTxUc0iTGo/XxEQRv
hxPguYeMJAsYFEqh5lGXCjxcm3sbIzkUZ5Lb2lbAPukVLa9w9gYeO4dYl+EwUwam
RWlIAeOOfjOo0QCUTauv/o4P6dwjuV5dzZCI1lv/DD5G76fCblJYnIwsmoyMKrgz
NFeNLpixKfv0vAPrvl67GvuJEw0YGWJJMFbu2K9i/Pu6+2BIprqPgRwB7PA5yJES
GBx7BoEa5YKFglY59+KRtBNthNfX4w==
=boQJ
-----END PGP SIGNATURE-----

--g4vopqhpjlyktekh--