Received-SPF: pass (google.com: domain of linux-kernel+bounces-72606-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 20 Feb 2024 16:51:04 +0800
From: Chao Gao <chao.gao@intel.com>
To: Yang Weijiang <weijiang.yang@intel.com>
CC: <seanjc@google.com>, <pbonzini@redhat.com>, <dave.hansen@intel.com>,
	<x86@kernel.org>, <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<peterz@infradead.org>, <rick.p.edgecombe@intel.com>, <mlevitsk@redhat.com>,
	<john.allen@amd.com>, Zhang Yi Z <yi.z.zhang@linux.intel.com>
Subject: Re: [PATCH v10 13/27] KVM: x86: Refresh CPUID on write to guest
 MSR_IA32_XSS
Message-ID: <ZdRn+A7g395N2AGx@chao-email>
References: <20240219074733.122080-1-weijiang.yang@intel.com>
 <20240219074733.122080-14-weijiang.yang@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240219074733.122080-14-weijiang.yang@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tSYe45shUMt5CDVuy5FZyYO1Ietngy3fTW6jFwiKET9brBWxAYYdzj9+v/3F?=
 =?us-ascii?Q?qkiUwxy/ro1pCj//NUSwkydw1b88xcenIBjsjtsiX/rkC02TVsA3YPiDpcfG?=
 =?us-ascii?Q?RsC0tsEYAcWT2PplfffvBtOWS3ikbq3+WehPfHkveYT0+/Bk6nG04cV/692v?=
 =?us-ascii?Q?8BYTdwGWyQtkPTrxGAJOqp7orAIIhj0xhbAq+xCAYbYPg4mNBYUZyYS6u+Vd?=
 =?us-ascii?Q?1ezvkDBlbpzxwoacZsvGU0Yeb8HA0VxhStvDHdZWSj+pyWhExy1LPDqfupLx?=
 =?us-ascii?Q?OUrSyJcasdLWqrlZqFqGB+ruyw+XZjltm5fs2YaqhnpE44GphQNUgZlF4pxz?=
 =?us-ascii?Q?LPXgXPJCtjVix96O0fG6+dM1YTnufff+565DPeGyeZKxBxXl5yQ64yJ3pgar?=
 =?us-ascii?Q?/NaIQQpLKk8JqKuP42Tyw5EjaN1Z8pXh9mqpKV8yD58h0ztxUR+kKse2u2t3?=
 =?us-ascii?Q?IAOyXqFU468YN74UxV1mQcDMi4Fjxd0cDFGKccZOOnt+CIT3y71utAZH/HCe?=
 =?us-ascii?Q?mmcJCpaiC+O/vsAd8Ea0WHoHKXThCBMwRPzZUTL5IJIlNgxPNjndslfM9Vz2?=
 =?us-ascii?Q?1WSsZ2UYOBO6O0jktxRhGgN2VCgkHPwtvOzC1mROgL6rAaZCuaQQ0x2JBx06?=
 =?us-ascii?Q?bh4fiwunFRyIYt3A8B6JuuwMRfoWaFGj03DAuw638Y5RpQeorZhYeoK69NBy?=
 =?us-ascii?Q?JUQdmUwu/VJgIq/a15oT5bu408ESx/ltWUq8i89QEN5xpVP0DTYsHdpJiiPy?=
 =?us-ascii?Q?5XCxlTJRISRFdSsBWX0vo9HYYWKnChZ2S8sma6KdEdHlezrnD2IoT3GZOU0J?=
 =?us-ascii?Q?OMKt3eMRSNP3mtySxx28VC1e15QoYtmvclCLNHwuChC/yA93vBVYkzt53nHy?=
 =?us-ascii?Q?77uXpRen+DrNlRskWfH19xuX8ottO/+Qw562iIMlOrazXpZpKXZNRZNMr+sn?=
 =?us-ascii?Q?feZgq+oDbYKHVj+FQzt348KRdfc6X5lUsDuqFcbbJ940VOJrcNdPwPTVD1CO?=
 =?us-ascii?Q?e0GwWDSgCaxICPzlyk+dKVGjV9AbiJjFVwMo3zVIYlHqB4x64/710BTIPilf?=
 =?us-ascii?Q?XIqA9tT4/DrhIi8mFzL6+pgxwCPe5cVNi88yUM6oGuYerj0xOM9LBi0jmec7?=
 =?us-ascii?Q?B3pfRO++6YIJdzvTNuLB76H5Ued00qegotc32rNRnx02Lku9tsUzDLWsBSH8?=
 =?us-ascii?Q?H6l+BbPveLSygYluwv5ilxdNUvhfo6G/0+GucdJEVru54HY3o/40jrrKvgSF?=
 =?us-ascii?Q?hEi3FqS7ZF8X0HCR3etiaDdW4C4UU7/sx5I3SEXb42v9Z+kKrMNKJPSnUIMN?=
 =?us-ascii?Q?thxD5mvDey33U4zMFYDkSKqdTWhjnSKZqQRxNJfGdGO83qDJuYWHRSpDdd37?=
 =?us-ascii?Q?tDsHN5I/6Fbh9HGi66ny5DtQeshAkwVzHAcqp5ujym47K2dG9aFbAnhDXZYk?=
 =?us-ascii?Q?wtAXQJd7hKiGsJ9ouqLYbz+ooTd/I9dEVDWW3iHfP8yfUgolPkS4kRBymDyJ?=
 =?us-ascii?Q?iWSWMl/DixI1bfStYqbKwF4G1GEPxZDomQ7J2hBT5p6ljYlhmWrZcYMMfJHi?=
 =?us-ascii?Q?tDEfS0ERwsEWQ/tEQtR1vl3W0VxjHLk0mamfDLAD?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 05f2ba58-9f97-4523-0796-08dc31f1176c
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB8665.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 08:51:13.0485
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: B/Iz8mWjzBMQKBsOXOIDopmLh+vTVF2Ra2dwieaOLv0vtMxKallCiIUCEbz13wsTinpPbmgko5bK45IQzkptNQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5659
X-OriginatorOrg: intel.com

On Sun, Feb 18, 2024 at 11:47:19PM -0800, Yang Weijiang wrote:
>Update CPUID.(EAX=0DH,ECX=1).EBX to reflect current required xstate size
>due to XSS MSR modification.
>CPUID(EAX=0DH,ECX=1).EBX reports the required storage size of all enabled
>xstate features in (XCR0 | IA32_XSS). The CPUID value can be used by guest
>before allocate sufficient xsave buffer.
>
>Note, KVM does not yet support any XSS based features, i.e. supported_xss
>is guaranteed to be zero at this time.
>
>Opportunistically modify XSS write access logic as:
>If XSAVES is not enabled in the guest CPUID, forbid setting IA32_XSS msr
>to anything but 0, even if the write is host initiated.
>
>Suggested-by: Sean Christopherson <seanjc@google.com>
>Co-developed-by: Zhang Yi Z <yi.z.zhang@linux.intel.com>
>Signed-off-by: Zhang Yi Z <yi.z.zhang@linux.intel.com>
>Signed-off-by: Yang Weijiang <weijiang.yang@intel.com>
>Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>

Reviewed-by: Chao Gao <chao.gao@intel.com>