Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1606996rdb; Tue, 20 Feb 2024 01:04:29 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU4hjIbJfBbtTVDOx8ghgj+w44pkFOR486MEw5kdvz7HO3fkNE7rm2LC9iyrEQ70lAUZXMpD7/aWmWdY+k4jVIYrKgfH92MngRZ8SbScw== X-Google-Smtp-Source: AGHT+IHuoDrv0zH1xXaGG3CalhWzUjkYt2rxRiO66EMwjKALyAM2JbWo09pvlQy/7moe3UeLNCwY X-Received: by 2002:a17:906:6c90:b0:a3e:cf42:cc1c with SMTP id s16-20020a1709066c9000b00a3ecf42cc1cmr2213912ejr.52.1708419869342; Tue, 20 Feb 2024 01:04:29 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708419869; cv=pass; d=google.com; s=arc-20160816; b=AHJ1pbd1JQelKXMHk6WHBd4V8MFZQpTnf2vw+4shHx9dRuB53SYrX0ld0iNdOflqWl QIopc0PC1TKPZcp68F3QtMh7i+o2PPfOogfycEGsYVdBKJq4HxB82k0Pm4lp+PBmPXos L7r7JC+GXMBASTFpWrgu2T9xAqjtYUhIZPqX4+vB5FdeBHGxmEfGONxvfr7GrIPwQT+C estB8dUKvgVbp1+qmFPy8v/vU/G4jZN5uo+vnQbQbawC7qBLbP4fRvYfxpZ8mLqPCwRc NSCx5fP/0G/5/hjcBD0sdy8OPO+XhCrLgpWeEOg9EDWHcvhJihnfVblTWr1ATpb+fsZe IW0Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-disposition:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:message-id:subject:cc:to:from:date :dkim-signature; bh=c2ULPGAo97hdg1ZsQ6jr2biEBRsVNCZw09zaItnJf/I=; fh=pSOd+RMErZIlALGMxSv1hpgYSPMUtXaqXVMiQMTYvBw=; b=FiySV70x0UQlsqd1FHPIKMRmKLXlB7xVxnKexnC940dqP9w0R99SUS7oEWy0wG+Fy5 TotI1v4bhz1lt2wCb3bPIXr0padYse1yu+n8WisypyQRsrwslEiumenugURYCkoeBxVD QTIbdoUYD3oM7ohPlP2Tx4aeabStNUvb5947HStVIBnZvVzPrj02wazNTlTcFAEefCHs uQ75JVemub+ZGjXTIInpsk/U4W+tyVhmdXXXZ4Nby2KFermSStRBj/9kedqpyx18ShCg bdsn8z7acX/dVVkvy7FzMSefMQOp6QbGd7eAEl6u3nP4Q4JST4URz5NdMzGOSKQrUPwe VFSw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Xq1yixNs; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-72638-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-72638-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id o7-20020a1709062e8700b00a3e40929aabsi2608241eji.151.2024.02.20.01.04.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 01:04:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-72638-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Xq1yixNs; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-72638-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-72638-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 1C71D1F24FDC for ; Tue, 20 Feb 2024 09:04:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 27D055D48B; Tue, 20 Feb 2024 09:02:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Xq1yixNs" Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A39FF5C8E9 for ; Tue, 20 Feb 2024 09:02:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708419761; cv=none; b=FmOd7TtIGhg852x52J5fKEXUJ+SgoCi0fsxVCZNMPQuEcXuFRpAnuDp8EC18IuyGRE90JRC+Tp7eV5y7QLHPq5p6mn1bXKNpNZI6E7IBEbGVnyHNglxsR/vJ2ku/0BQj2upMuJaqSBy8tZgtz5V9ruCEbRsPAtMfjLIr7jIQE/I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708419761; c=relaxed/simple; bh=SgoqViaaje+AgC+n7ivCHYAc8WaXGdnEMAxju39c9XY=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=QfQm2lsI08U/vpIUIjSzdJuuYbYRAIoxXhNVbto4XGEWBkbs5B0D7gO2M9Lh2VxK7calgeYOfyBsR93SnKsZpMTtBwD8rDA2O/+N8NKGLQEQxSjUap5cwepgVxu+jonvYh7ljIAPJF1W49KXDjq+fuR2KbaRR+Gg52M5ZFeinGQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Xq1yixNs; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-a3e85a76fa8so188537566b.1 for ; Tue, 20 Feb 2024 01:02:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708419758; x=1709024558; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=c2ULPGAo97hdg1ZsQ6jr2biEBRsVNCZw09zaItnJf/I=; b=Xq1yixNso7pw/x5t8IT/f4qOdwR+izJKKj3NoXGeM9aPT4+Y3NB/L0BShKiZE1YuBj p7j9E6g6mQj7FcNOV+bbuuaadA+u2XHa7DQ8Ozz6H5YZW5zC21pzl+VLx9U2UWrOAZ9p 9Y1RM7qjagL1Xv9Zu+UhUPN870GVG/00GRrfnfVbMPGfPX/m86fhH15OmFkUdcAjCk0y N+K952V2wtAez61gwBi9T476OzfOBNf+naXLOP+mJDsN7u/8oJOp3cgEmywy8k2QFlGY gbonEHErW1zZIp/4loFJ7CGm8obBIU12h5OHtKeinJDtfHfdbWQ71ocPJrmlHukjutid 0PpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708419758; x=1709024558; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=c2ULPGAo97hdg1ZsQ6jr2biEBRsVNCZw09zaItnJf/I=; b=oRrUl4OBLn73RaAXimaLQnzK1uUIEenjqjsp8TN4/c2Quq2rnM+6qX25wj9bmMGjIP htfXjv24CJv/ijnZw6CUuNSqHlFKXVoO2Ul39prozi9wSpPz3kOF2dt6uX3/ap6DKh1G qU3u1THAtjxU+ArW1huUc3euzejFbYYgJ4w8yB+dnyZuIfdV3Qk7UEVFiK6OmLKbh9yM R/2OIiLF6DVy/WEMHyGnUCZ+b53dC9pSb+pGVhwP+cW5NYu0m/s/dz7tMuJGXZn4pneL z1ldEoGlJT1yWN64yoN7O3xxQjseYV4bnCCLDhUUjT3505G03x9H+JfonXacAqnBgCcb gbbQ== X-Forwarded-Encrypted: i=1; AJvYcCU0BlKNTmFPRQK3NIqbT8ezGmxXF650/A6A8/l67CJFtTgfCbhr7OuBc1TPTz6WwiFPaxfQQoOPiGhh2RKST2EJlnBvfLShgDt5fGoR X-Gm-Message-State: AOJu0Yy4pHaT+pfSVohOjh55g1U79hQZinJ0yMLzDYqfIWsmf0A8YpeO LVtebRkpcyPqwe+A2RSKGhetywp1KBWWr2lpiGsnbIMkXvu/LLOZtpqd5495Gf4= X-Received: by 2002:a17:906:e2d0:b0:a3f:14f5:2f87 with SMTP id gr16-20020a170906e2d000b00a3f14f52f87mr91187ejb.42.1708419758047; Tue, 20 Feb 2024 01:02:38 -0800 (PST) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id ha1-20020a170906a88100b00a381ca0e589sm3746733ejb.22.2024.02.20.01.02.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 01:02:37 -0800 (PST) Date: Tue, 20 Feb 2024 12:02:31 +0300 From: Dan Carpenter To: Rob Herring Cc: Arnd Bergmann , Greg Kroah-Hartman , Michal Simek , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Benjamin Tissoires , Ivan Orlov , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] char: xilinx_hwicap: Fix NULL vs IS_ERR() bug Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding The devm_platform_ioremap_resource() function returns error pointers. It never returns NULL. Update the check accordingly. Fixes: 672371832193 ("char: xilinx_hwicap: Modernize driver probe") Signed-off-by: Dan Carpenter --- drivers/char/xilinx_hwicap/xilinx_hwicap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/xilinx_hwicap/xilinx_hwicap.c b/drivers/char/xilinx_hwicap/xilinx_hwicap.c index 019cf6079cec..6d2eadefd9dc 100644 --- a/drivers/char/xilinx_hwicap/xilinx_hwicap.c +++ b/drivers/char/xilinx_hwicap/xilinx_hwicap.c @@ -639,8 +639,8 @@ static int hwicap_setup(struct platform_device *pdev, int id, dev_set_drvdata(dev, (void *)drvdata); drvdata->base_address = devm_platform_ioremap_resource(pdev, 0); - if (!drvdata->base_address) { - retval = -ENODEV; + if (IS_ERR(drvdata->base_address)) { + retval = PTR_ERR(drvdata->base_address); goto failed; } -- 2.43.0