Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1609961rdb; Tue, 20 Feb 2024 01:10:56 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXI0TU2kSq1QGVWtQO+8oW6pFcODDpKhO3aXYasbYsCje9OMjZzwET5hVAeKrZ86yFrU3BEhInlwmI70F2XTHi2aM6lTrH/GOYBoEvmEg== X-Google-Smtp-Source: AGHT+IEcoIJFwW2nYiAj+NEb/LuAQux6jr0cFekm/XuR6StxedEQKRdULUn6gcv4m0eGHhoLt557 X-Received: by 2002:a05:6a00:9383:b0:6e4:6981:e9b3 with SMTP id ka3-20020a056a00938300b006e46981e9b3mr4551248pfb.2.1708420256299; Tue, 20 Feb 2024 01:10:56 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708420256; cv=pass; d=google.com; s=arc-20160816; b=rKbJ1g1VLgvzLQA7fL7bS30MLbqhlWKPU7o1g3rzpyQw9ieHuPbrZcb++3KNXEBSTZ g039q8IquDUz+svQ61XRzoxIx4kbtnCR2aK8MPikZrI34pdfbtYzZ/fgzFPPTCZM8FzO WR0FvECqOI5SEbP4EX+92aHM1SCRA5/CyYzVyUFZ91g6YzHlCR6ceWF3xqURGRXcp/34 pz8LHhnfMXrvVS/URVcOSJa/xSzA1IbSOUwk2OTUxHfzGrN4sVxzHL+XacZRXra/lCQ1 L1DfeROO8JAIkKKE9VsWWsNGznSMXVJUfyGfkXHVGWamI0C7LOZm+3UsaVASXOOJChS3 5sfw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=4UN6sgMk6bLKJ0L7h6B25JoRdBFRS4Pz0U/gnq5gthQ=; fh=RiN8vEE0N3HYrJkX4sWxp9Hxu6mLVrNgviDv2z8hWhk=; b=0AILJuFIwPT+5aF5K3M4bwviIistpwDwuzNsyIV5CUvhE+l0IwOH8iBI+EPSBsEKzA qd/rSEUbB4p9dF4lhV4A/RxhGnGJzo4Rm9quWUBT79vESnJ0cBbDcm0lYxCsZQ/DFwXt hhivOx8nMgQsbRp6NYrNK/eNjWckTRjAVqSUA8K+Wj22HjegBp5JapZzUpJa+f1HnJe2 Vmae71WAmnIcEgfGPNdLp531gSijUF9f3CxWG1xueBGktRUpSKM7Lf3Pjxd2/y0WDwdw Aoh5VY4UvAJYqhJ1CU8BnOnrvCmr3o+Asu3gKtH52UxGnN/U1hDwMvOyWSFg3bZI0pGm z4mQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JeeiAhWy; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-72621-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-72621-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id a65-20020a639044000000b005e3cdf125easi1899838pge.612.2024.02.20.01.10.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 01:10:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-72621-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JeeiAhWy; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-72621-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-72621-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 08AFBB24CA5 for ; Tue, 20 Feb 2024 08:58:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 99B3860EE9; Tue, 20 Feb 2024 08:54:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JeeiAhWy" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0A3A60ECA; Tue, 20 Feb 2024 08:54:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708419254; cv=none; b=ud4LuM5ZsmPN65+xCEdzLvWUA70SGLCsM79XoDThNvfPseG+s9bREcxwf+/RimYVQeD0W0a0TFlPYVZz6wU5AMhdQunqGkhB54UOftlqFB8j+AV8tnmB5wviMKIevvglFgdoGMYAP4GBNcOsd0CEAvEgdBXy2vJOhv3jibhQiAc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708419254; c=relaxed/simple; bh=B6qD+njWAH/o7ZNCwh75UCFh4ZHfi8ezu7N8qDHMHw4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=k+WA5RJ+oKWe8atNK6Qvz73nmRZ5bxmX9Tgb7YJarJ0SyRc4IDeo0I3iVGQiM7sgp7wBxiNrQonAJeerXLIyYNwRlJwn48j2tXKz51H0gISa4toaReOvnAXsU8ss+0N3V0f7/VtSVUQVI0RvCoMAP7e73twYDlsZgpQcMQ2Gudw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JeeiAhWy; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2AE6CC433F1; Tue, 20 Feb 2024 08:54:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708419254; bh=B6qD+njWAH/o7ZNCwh75UCFh4ZHfi8ezu7N8qDHMHw4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JeeiAhWyjcvwUk03TSAbocMadDU5HsYxS8+vtSeYC+fPbehwlourI3vJDZEnTICCy QKAwXEzsZlPTh6yKmVHnpVrnjJl0xI+FgVSghN6izUPG3FMeblKWFilALK2ZF71a8y WHNbHZ7lGx9zTu3HWdLOyrO5aQRc+oEHRmwILcF5+nA2VPbH2e+CYDpdYJ/IStxbLr lRLNxCxkfnf7WOcM7k6wggrQ1fT2RRuBuFCXE7UCxwhG4jccixB4e0ocIP7eKcB+Rx fB5v4G5cO8jJaSGxJegjV2s5jsuKj+lXfUaT958VskIrCXToK2L8sFgd2jzFH5/0dM Jq/ybHqVcOXTw== From: Christian Brauner To: Jeff Layton Cc: Christian Brauner , Alexander Viro , NeilBrown , Alexander Aring , Chuck Lever , Jan Kara , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH] filelock: fix deadlock detection in POSIX locking Date: Tue, 20 Feb 2024 09:54:05 +0100 Message-ID: <20240220-kundtat-abklopfen-214a31e5c522@brauner> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240218-flsplit4-v1-1-26454fc090f2@kernel.org> References: <20240218-flsplit4-v1-1-26454fc090f2@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1177; i=brauner@kernel.org; h=from:subject:message-id; bh=B6qD+njWAH/o7ZNCwh75UCFh4ZHfi8ezu7N8qDHMHw4=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaReyVj/YFkOw3Ujyw2zzs/XTVe8t8v6sJtwcNLy5O/mq W/V50umdZSyMIhxMciKKbI4tJuEyy3nqdhslKkBM4eVCWQIAxenAEyEU5zhN4v7pDLdU4tk101d vi2tLpvP4Z3m+m+m63afCfxmkBh7WYThr8Ah4ZU1wbU5bNMmLLm8bdbOspezzkfP3WZl++bN2hf NVxkA X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit On Sun, 18 Feb 2024 08:33:28 -0500, Jeff Layton wrote: > The FL_POSIX check in __locks_insert_block was inadvertantly broken > recently and is now inserting only OFD locks instead of only legacy > POSIX locks. > > This breaks deadlock detection in POSIX locks, and may also be the root > cause of a performance regression noted by the kernel test robot. > Restore the proper sense of the test. > > [...] Applied to the vfs.file branch of the vfs/vfs.git tree. Patches in the vfs.file branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.file [1/1] filelock: fix deadlock detection in POSIX locking https://git.kernel.org/vfs/vfs/c/14786d949a3b