Received-SPF: pass (google.com: domain of linux-kernel+bounces-72650-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <4e984b59-b50c-48dc-abbf-8045d924331b@oracle.com>
Date: Tue, 20 Feb 2024 09:01:14 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 09/11] scsi: scsi_debug: Atomic write support
Content-Language: en-US
To: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Cc: axboe@kernel.dk, kbusch@kernel.org, hch@lst.de, sagi@grimberg.me,
        jejb@linux.ibm.com, martin.petersen@oracle.com, djwong@kernel.org,
        viro@zeniv.linux.org.uk, brauner@kernel.org, dchinner@redhat.com,
        jack@suse.cz, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
        linux-fsdevel@vger.kernel.org, tytso@mit.edu, jbongio@google.com,
        linux-scsi@vger.kernel.org, linux-aio@kvack.org,
        linux-btrfs@vger.kernel.org, io-uring@vger.kernel.org,
        nilay@linux.ibm.com, ritesh.list@gmail.com
References: <20240219130109.341523-1-john.g.garry@oracle.com>
 <20240219130109.341523-10-john.g.garry@oracle.com>
 <ZdRQ8mPGRVidvjQI@li-bb2b2a4c-3307-11b2-a85c-8fa5c3a69313.ibm.com>
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <ZdRQ8mPGRVidvjQI@li-bb2b2a4c-3307-11b2-a85c-8fa5c3a69313.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?LzZWMFBPU3pEaFd2cHY2cFJuZldaUzJ1Vjl2QnovYW1YeFpoOHhGQ3ZyMEda?=
 =?utf-8?B?ZExFQndPc3BmOFRTd2loTWthQ1JkZ1Z6N3o5NXM0UzlVcEltT0NFNy9xSjFT?=
 =?utf-8?B?eG8rTDkzOFlIcFRMV0NiRXdRckxUOEpNdjFjZ2JMU1Z1YlRGVUhRWGhyTC9G?=
 =?utf-8?B?Y2NSVnN6UTFUUnZiemJObTNjNHQ1REhLd3daQjRJZERkV25lNkc2U3YwMUxp?=
 =?utf-8?B?clhaR2N1SmZuQU5CNnRnWVRReXRJYTRwQ0VFaW5UcHlkWDVYaGVmQWJQUEVl?=
 =?utf-8?B?KzlVbmN0Y3g0K2xRQkFRbXl1akJmSHpocVFkZTRRUlJOZ1VyNU50MTVLUnlP?=
 =?utf-8?B?RzhXcTZIM2NPbXZqQmxObkNMOFcyK2hGV05PUzBQM0orbGtVNHoxbG53OW95?=
 =?utf-8?B?RllpandNR1ViNGVMcndnQkc3VEZkN3RqVkZOSEJRSzhVa21lZ0F5VHhGQ1F3?=
 =?utf-8?B?OUdzbGNRMGprZ0I2Q2Y0ZHhsdUpaNWhVZFpNQXdzeXN6dmtwN0RCLzBCZTJN?=
 =?utf-8?B?cWt4ZHM1clUwWXRPTzhBMG1TcjhpbTFlbWdvWVk2V3cwb1NJdXhkZ3F5ck5Y?=
 =?utf-8?B?QzJCbWtDaEkxcm9zVy9QcXd0Ym1lL3dOZTNqM0Q2WWFoQkplTlUyWGkwdnE5?=
 =?utf-8?B?d2lzdDBWdnc3Q2dqOVlpVzVLQ3pJV29zbUUzdXRtenpMaXcyeDJ4QWcwTlFP?=
 =?utf-8?B?eXNyQUVmdmI2YUFaZ3dOVnY2dHQ4L1k3Z21lcGxGanU0T3VNbFhTQnFmb0hB?=
 =?utf-8?B?Q1hRd0RDTGcxM2ZyU1FyWDd2RGZ2dWVDRi80OGRIK0g4NmlhdVpPTlErZWdF?=
 =?utf-8?B?YlZkbzdBMHByak9aTi9iRm1sck9zdWQ5OE9tUTAyb0Jnd0FzaG81M2JaL0p6?=
 =?utf-8?B?ZFBGQTlkeE9tVUxxWTI2NUsxZUc3QXZxdEZyTUc4SktFeHNTY0JTRThiK09J?=
 =?utf-8?B?NE5jbmhkaTJRaVdpMXBNdjRlSlhNQjZyVTk4MnBzZFUwWlpZYUFlNUxJdjRx?=
 =?utf-8?B?K0U5bVBZK28yZDN4Ti8wY3pwcytKRGdLSlhmSXZHMlBRN1FDanV3cVlkWjhw?=
 =?utf-8?B?c2FNREYvZC83TURrdlF4VmpvR3ZTL1oreUlXc0d4T3hEN01ZR2dkL1FOQm5v?=
 =?utf-8?B?OFVSTjdUM1pkcjFYRDFXTkVZZGlINHJ1Y3RITit2ekd6Rk5GZDBxaVVnT1Ez?=
 =?utf-8?B?UUNDaHQvdDRiVXl5UE8yT09mTzFSL2VSdFVYNkdmL3pwUE9iTStQZVo1S0Fi?=
 =?utf-8?B?QXJzTHFRblAxRUpNRlNuQ3FEVUdKdjhvdno3QUtEOHNGV0RsMDMyZGJFcTZv?=
 =?utf-8?B?Zmx1dXZDYzB5S29zRUZVWU84eWxUYlhWZ3ZHNmFMRDBackdiQUs5QVd0REJw?=
 =?utf-8?B?TE9XQ2FFY0tEbTZDVXpWbGRqUENyVmdwcmkrU0k2NC8xTnZpTWc1d2t3SU5G?=
 =?utf-8?B?dlVFaXdvNFhrZHNoczJ2YkhMOTFGY3pZNzBlUlBzUTM4YXp1WWJMTGZRZUUw?=
 =?utf-8?B?eWw3M3RIYkV6QU9yTDB0Y005UXBNRS90VHJ3R1BwUEs1RnFqWnk3NXJuLzVB?=
 =?utf-8?B?VmxRTzMrT1J2d3V5RmFYNzM1NnNsUHFSRHhIZ2FTOXlkUW00YjhKYW5rTC9X?=
 =?utf-8?B?bERVcEhxWHBONTNmUm9UNmlzdVYvdnlxc1RJRXlxMW5iOW56eXZGZjlMQW9w?=
 =?utf-8?B?NjFOb0J6MGlmKy9NZmFmcUx3UktFalVORit2Q3loL01Ud0lQNXAvTWdKbUZx?=
 =?utf-8?B?czYvckhTWTB6V0hacXpwWDBRZXJvSzA0c2t3SVpNY01WVHJhM3BabkFwOE9a?=
 =?utf-8?B?QU54d0NJcWgyaUV5MFhXd0NoMzNkc0ZNaVZDU3dnYXQvRm5DRktzS3p5VEJK?=
 =?utf-8?B?dDRsR2padkU4NWNHRUNRQVBRd2huTDVpS05HYlQxRUZhd1JCc3VvR3RZTlJS?=
 =?utf-8?B?czlDSURRZTVKVW5jdHNsUi9tK25OeXlUcmF5RWhZQ3I2ZGdkRHFiMmlra3oz?=
 =?utf-8?B?dHV4YUFwbWNaNGErQ2tHM2dsRWtMMWo5RU9rMC85L29KQ0ZVNDhXUks3bFNi?=
 =?utf-8?B?SlQwMFBvaW9XNDdvK3B5dXBMSE1aUUNZcFhMdzNZYmtTT2lRbW96dkZGV1Vo?=
 =?utf-8?B?YXZTN1ptMk1PVDhKWXorQjRQd01pak85TkpRVmJLNFYrdURFcXZwRnZya0ti?=
 =?utf-8?B?ekE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	om0ftdRuWoNi9FRqI2n3kX1XJDxQAUBO+63O5gX9OALvLb/+oqPJV9zdijp+vUNiTnvbDN78CYMpYP54i7IfK4n2f02R6PMlLng+w3G1HN2lL/GO0iDcuJWPMVkWfV7ehRWdHgiw64OFfhcmM+oY1cuOSGuVz/ywFEmda2EK3Pe19dtw5ppOsVFLKWG5NpMC8+tOzMz/DU2x1L9qW+B2hzeV7amkT13ok3S2lSIW6xpIQY9DfjQldb9LYIlBxIf6lvWdQu4ZyArO+wqgmtqIRArUjgH3/tbKsxiAhntv9jZsLLJgzJ6l+TmxlIB7m7xIEXh5eSjiOoRPTVfjxy6a60hznVj3miiN+4z91clo55VW+pxYcAMojui8NN11O/baxRSqssckMaxzr8vkkngbb5D37/5zgtGsgumzi4Bt42X6McbzVdVXFQc3Bu10TWHyRegEjTO4pitqx46S/Hv/ssikdZPMySb6I+LzIoBNdb3ighfugIk6srbebBurLCpBzFVcUBXnqyOuZoraYhg7siSfR8mkHnZu40bz2geQkjVzfbXpPYCj8b5rooyjDiTpF/lVYDo/QZ6koxcyT06Kv75YxocxPH9VcVTFgU2j/7Q=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 07251d48-aff4-4bfb-277b-08dc31f280a3
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 09:01:19.1599
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UtpvMY9boec9nJXCnBD8evLeMVROTiH2WZ9LWWDORp1Qkf+4LKX5qkUvqMJO1q0WpAmcuwbOdHdIO/DZFhNtZQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB7312
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-20_06,2024-02-19_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 malwarescore=0
 bulkscore=0 adultscore=0 suspectscore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402200064
X-Proofpoint-GUID: CF3k8tgFHOOWXNY8KSVjmqPuBAO6EChe
X-Proofpoint-ORIG-GUID: CF3k8tgFHOOWXNY8KSVjmqPuBAO6EChe

On 20/02/2024 07:12, Ojaswin Mujoo wrote:
>> +MODULE_PARM_DESC(atomic_write, "enable ATOMIC WRITE support, support WRITE ATOMIC(16) (def=1)");
> Hi John,
> 
> The default value here seems to be 0 and not 1. Got me a bit confused
> while testing ????

I can fix that MODULE_PARM_DESC() text.

I don't think that many disks support atomic writes, so I was leaving 
this disabled by default.

Thanks,
John