Received-SPF: pass (google.com: domain of linux-kernel+bounces-72644-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <ab809d89-339a-44fc-8a5a-ac667d220ce1@collabora.com>
Date: Tue, 20 Feb 2024 10:03:48 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] soc: mediatek: mtk-socinfo: depends on CONFIG_SOC_BUS
Content-Language: en-US
To: Chen-Yu Tsai <wenst@chromium.org>
Cc: Daniel Golle <daniel@makrotopia.org>,
 Matthias Brugger <matthias.bgg@gmail.com>,
 William-tw Lin <william-tw.lin@mediatek.com>, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org
References: <cc8f7f7da5bdccce514a320e0ae7468659cf7346.1707327680.git.daniel@makrotopia.org>
 <CAGXv+5EKCrvsvZwc2zYiMWAeT9vqvU0JnDrz=WBoebBBbcgp0g@mail.gmail.com>
 <f1fc67d4-f979-4c3e-988f-a803b7b11c46@collabora.com>
 <CAGXv+5Gxc3OP8nE681C6YQbDMUNmFDf21BfSvJZPBFgoncve=A@mail.gmail.com>
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
In-Reply-To: <CAGXv+5Gxc3OP8nE681C6YQbDMUNmFDf21BfSvJZPBFgoncve=A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Il 20/02/24 10:03, Chen-Yu Tsai ha scritto:
> On Tue, Feb 20, 2024 at 4:56 PM AngeloGioacchino Del Regno
> <angelogioacchino.delregno@collabora.com> wrote:
>>
>> Il 20/02/24 07:40, Chen-Yu Tsai ha scritto:
>>> On Thu, Feb 8, 2024 at 1:43 AM Daniel Golle <daniel@makrotopia.org> wrote:
>>>>
>>>> The mtk-socinfo driver uses symbols 'soc_device_register' and
>>>> 'soc_device_unregister' which are part of the bus driver for
>>>> System-on-Chip devices.
>>>>
>>>> Select SOC_BUS to make sure that driver is built and the symbols are
>>>> available.
>>>>
>>>> Fixes: 423a54da3c7e ("soc: mediatek: mtk-socinfo: Add driver for getting chip information")
>>>> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
>>>
>>> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
>>>
>>> Angelo, I believe this should be picked up for -next?
>>>
>>
>> I'll pick this up for fixes, as I've already sent the PRs for v6.9.
> 
> The socinfo driver is in -next, so I guess you could pick it up as a fix
> for v6.9.
> 

Of course! :-)

Cheers,
Angelo

> ChenYu
> 
>>> Also, mediatek/v6.8-next/soc is missing from mediatek/for-next in today's
>>> linux-next.
>>>
>>
>> Fixing immediately.
>>
>>>> ---
>>>>    drivers/soc/mediatek/Kconfig | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig
>>>> index 50c664b65f4d4..1b7afb19ccd63 100644
>>>> --- a/drivers/soc/mediatek/Kconfig
>>>> +++ b/drivers/soc/mediatek/Kconfig
>>>> @@ -72,6 +72,7 @@ config MTK_SOCINFO
>>>>           tristate "MediaTek SoC Information"
>>>>           default y
>>>>           depends on NVMEM_MTK_EFUSE
>>>> +       select SOC_BUS
>>>>           help
>>>>             The MediaTek SoC Information (mtk-socinfo) driver provides
>>>>             information about the SoC to the userspace including the
>>>> --
>>>> 2.43.0
>>>>
>>>>
>>
>>