Received-SPF: pass (google.com: domain of linux-kernel+bounces-72678-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 20 Feb 2024 10:18:11 +0100
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Michael Walle" <michael@walle.cc>
Cc: "Marco Felsch" <m.felsch@pengutronix.de>,
 <srinivas.kandagatla@linaro.org>, <gregkh@linuxfoundation.org>,
 <rafal@milecki.pl>, <linux-kernel@vger.kernel.org>, <kernel@pengutronix.de>
Subject: Re: [RFC PATCH] nvmem: core: add sysfs cell write support
Message-ID: <20240220101811.6ae23f2e@xps-13>
In-Reply-To: <CZ938PEUZ1JQ.2DJE7C03HI9OO@walle.cc>
References: <20240215211401.1201004-1-m.felsch@pengutronix.de>
	<CZ6DFL6061FS.2WMDPMSSBXX8S@walle.cc>
	<20240216100750.zxl4wncbgpulr2cc@pengutronix.de>
	<20240219120414.32395299@xps-13>
	<20240219115358.xui5fpoisvsubdyb@pengutronix.de>
	<CZ938PEUZ1JQ.2DJE7C03HI9OO@walle.cc>
Organization: Bootlin
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi,

michael@walle.cc wrote on Mon, 19 Feb 2024 14:26:16 +0100:

> On Mon Feb 19, 2024 at 12:53 PM CET, Marco Felsch wrote:
> > On 24-02-19, Miquel Raynal wrote: =20
> > > Hi Marco,
> > >=20
> > > m.felsch@pengutronix.de wrote on Fri, 16 Feb 2024 11:07:50 +0100:
> > >  =20
> > > > Hi Michael,
> > > >=20
> > > > On 24-02-16, Michael Walle wrote: =20
> > > > > Hi,
> > > > >=20
> > > > > On Thu Feb 15, 2024 at 10:14 PM CET, Marco Felsch wrote:   =20
> > > > > > @@ -432,6 +466,7 @@ static int nvmem_populate_sysfs_cells(struc=
t nvmem_device *nvmem)
> > > > > >  	struct bin_attribute **cells_attrs, *attrs;
> > > > > >  	struct nvmem_cell_entry *entry;
> > > > > >  	unsigned int ncells =3D 0, i =3D 0;
> > > > > > +	umode_t mode;
> > > > > >  	int ret =3D 0;
> > > > > > =20
> > > > > >  	mutex_lock(&nvmem_mutex);
> > > > > > @@ -456,15 +491,18 @@ static int nvmem_populate_sysfs_cells(str=
uct nvmem_device *nvmem)
> > > > > >  		goto unlock_mutex;
> > > > > >  	}
> > > > > > =20
> > > > > > +	mode =3D nvmem_bin_attr_get_umode(nvmem);
> > > > > > +
> > > > > >  	/* Initialize each attribute to take the name and size of the=
 cell */
> > > > > >  	list_for_each_entry(entry, &nvmem->cells, node) {
> > > > > >  		sysfs_bin_attr_init(&attrs[i]);
> > > > > >  		attrs[i].attr.name =3D devm_kasprintf(&nvmem->dev, GFP_KERNE=
L,
> > > > > >  						    "%s@%x", entry->name,
> > > > > >  						    entry->offset);
> > > > > > -		attrs[i].attr.mode =3D 0444;   =20
> > > > >=20
> > > > > cells are not writable if there is a read post process hook, see
> > > > > __nvmem_cell_entry_write().
> > > > >=20
> > > > > if (entry->read_post_processing)
> > > > > 	mode &=3D ~0222;   =20
> > > >=20
> > > > good point, thanks for the hint :) I will add this and send a non-r=
fc
> > > > version if write-support is something you would like to have. =20
> > >=20
> > > I like the idea but, what about mtd devices (and soon maybe UBI
> > > devices)? This may only work on EEPROM-like devices I guess, where ea=
ch
> > > area is fully independent and where no erasure is actually expected. =
=20
> >
> > For MTD I would say that you need to ensure that you need to align the
> > cells correctly. The cell-write should handle the page erase/write cycle
> > properly. E.g. an SPI-NOR need to align the cells to erase-page size or
> > the nvmem-cell-write need to read-copy-update the cells if they are not
> > erase-paged aligned.
> >
> > Regarding UBI(FS) I'm not sure if this is required at all since you have
> > an filesystem. IMHO nvmem-cells are very lowelevel and are not made for
> > filesystem backed backends.

I'm really talking about UBI, not UBIFS. UBI is just like MTD but
handles wear leveling. There is a pending series for enabling nvmem
cells on top of UBI.

> > That beeing said: I have no problem if we provide write support for
> > EEPROMs only and adapt it later on to cover spi-nor/nand devices as
> > well. =20
>=20
> Agreed. Honestly, I don't know how much sense this makes for MTD
> devices. First, the operation itself, seems really dangerous, as
> you'll have to delete the whole sector. Second, during initial
> provisioning, I don't think it will make much sense to use the sysfs
> cells because you cannot combine multiple writes into one. You'll
> always end up with unnecessary erases.

One cell per erase block would be an immense waste.
Read-copy-update would probably work but would as well be very
sub-optimal. I guess we could live with it, but as for now there has
not been any real request for it, I'd also advise to keep this feature
out of the mtd world in general.

Thanks,
Miqu=C3=A8l