Received-SPF: pass (google.com: domain of linux-kernel+bounces-72704-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <8b4234f3-3fa7-47ca-bbcf-0198a102f7a9@oracle.com>
Date: Tue, 20 Feb 2024 09:35:22 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 06/11] block: Add atomic write support for statx
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, kbusch@kernel.org, sagi@grimberg.me, jejb@linux.ibm.com,
        martin.petersen@oracle.com, djwong@kernel.org, viro@zeniv.linux.org.uk,
        brauner@kernel.org, dchinner@redhat.com, jack@suse.cz,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org,
        tytso@mit.edu, jbongio@google.com, linux-scsi@vger.kernel.org,
        ojaswin@linux.ibm.com, linux-aio@kvack.org,
        linux-btrfs@vger.kernel.org, io-uring@vger.kernel.org,
        nilay@linux.ibm.com, ritesh.list@gmail.com,
        Prasad Singamsetty <prasad.singamsetty@oracle.com>
References: <20240219130109.341523-1-john.g.garry@oracle.com>
 <20240219130109.341523-7-john.g.garry@oracle.com>
 <20240220082902.GC13785@lst.de>
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20240220082902.GC13785@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?cm4wSUFVOHN0Z0FCTGZzeHFWeVFhdlNLUFczYk14UUhtTGdmRTZCakNwbVUw?=
 =?utf-8?B?czh3KzVOSWtIQlZicjRlVFZTUkVBamNvM1NMdXlWcnlLZkJCOXdSUmRFaERQ?=
 =?utf-8?B?RWFiVEJ0d3NJdi9TZlQ0T0xEMEtEc1F6S01zbktxcmNoOVc0alJXSTdCenln?=
 =?utf-8?B?dmFkYU8zR2Zqb2xHSGtCQkhrR2duYkFQZmNFdTJHZk5kTEJpM1I4cVdhTGVh?=
 =?utf-8?B?elVtTE5nTlpjdFlaYUh1d29LU0RiVTF3WVoxS3ovQjBZemU3cVY2dzd3WWRx?=
 =?utf-8?B?aE5nTzZtQXdNaysrMVhTc3N1QVFwQS9zdk54UnVzVDJUaUdQUmdBREFZWnBB?=
 =?utf-8?B?WXplMGRIUWY2ekErWndGbG9LYXlYOXNiQ1VCeDkzYjlBWnc3NndOWEhzUVdE?=
 =?utf-8?B?NTdmTEw0YjJteU1nOUNjQlZXblpZR1B2b1hieHJrd3FLTW5UT2NtWk1jSVBt?=
 =?utf-8?B?U0kwbERkRWN6NjBFYXNhRlVaQkJtTE1nVEZDM1RvN1dwZlhWNXlsRjNGc3Ur?=
 =?utf-8?B?TDZtcUVlZFMzU1VSc1pzakY5QW5NUEVzSGdrcVgwY2liSDNwd2s2bDdPVnJv?=
 =?utf-8?B?SktGTHJ5N21MbGMrZ0NJSEhvM2VyYXQ1YVdQSC9HOU0rOGppemMwcWxXV0lY?=
 =?utf-8?B?cjZOSUNFallUSWZkKzNHSkpOUXNIcytQWjdNa0NQNnNSekVmcmtHWllGQ1RE?=
 =?utf-8?B?bjN5SEk4bytHejN0Y3Y4dzhkR2cwNzJhQ3BaZVN5WFBLaHQ2Y3E5aURvOWFS?=
 =?utf-8?B?ZTlJeVJsVGRvdit1UFpwbzM5dVBZY1l0eUJoZTBoMUdtSCtQRkFZNkdFY2RO?=
 =?utf-8?B?MlJWUXpnU0tSdkdTNERHSk9OYkJkQkRvMkZ1bm5KTmZMVEkrek9id0VIdVJM?=
 =?utf-8?B?N3VtamswQVlPUHd6am5VSDlLMDZYdDZORXZ2WllDNGowTDgycTNmbTJSMU5T?=
 =?utf-8?B?S0dNZGsxdDRWU2MzK2krSXlMRHdZTm9CQk1LTlRLajdZMlY1OE5UVGJWZ0xP?=
 =?utf-8?B?Y09xaUw3clR0bmM4bmtzemRzeXBqZ0g4YzUvenFPNktjSkVhVFlEVE0wZGNZ?=
 =?utf-8?B?RGQ1QkVQTnNhczY0NHlNYmRkcnVObk5FRjIrRUlPWjBNVmFSZWhyc2VsaGFB?=
 =?utf-8?B?bjN6cFBjMzQzdVh6d01YTmh1dXhiamk5cm43WGF1dGNraFo4TzJNNTE1bk42?=
 =?utf-8?B?cUxPeGdyckJZWk1lUjd2TndhN1BLanpXR3ZtS2NoZzQ1ZHBtSUJCcTlOS1pq?=
 =?utf-8?B?SVNZNk9vOEt6SjNXQWtMVll3UGt6WnNKVzc5MTRxbkhyY25RTkxiQm84Y0dB?=
 =?utf-8?B?bU1HRlErbm85Yit0dTNRclM2L1lwck80SXJlUUlhWFFpMlBadWpRQlVjZVNI?=
 =?utf-8?B?dFZZRzUycFBRWHBpZWYyTVpQcDZ1ZUdBalVDK2hwREtwbldIaTE2YVhMUyt5?=
 =?utf-8?B?ZFJ3NTlZNnUyWjl0MUQ5TWp5bGlSa2xUV29pekE2MzdDeE95Z3hHczNCT2Fw?=
 =?utf-8?B?bWgzdGFYTW5nYlFLNlBZMkVzb2wxTy9RQ0lvYkhBdnNXYW9YTEdheG4wWjBp?=
 =?utf-8?B?MW51WjFVdEFUTncwS0xoTFlXMGxGeUwwdTVFYmgvRTNQcDNsNzM5S3BlMTJG?=
 =?utf-8?B?QUY0dVBpdHE0Wld5Z05jVDdycDl2ZDNQVE15U2FOdFFiTnJ2UW9hOHAvNUlw?=
 =?utf-8?B?cGpJcWQ0engydW82ckMxdUVHTEZTUGJTbEgzZmNtSkNsbU9wUWdXL3YxZER1?=
 =?utf-8?B?N3VoRWMwMVFIUGJPQ2tzbzBnRjQ2dHZBaGt4bGExbExrVHJsTUhIaHBia1F5?=
 =?utf-8?B?T2FPSTFsdE5KQTBoelJISWUvaXZvWGpsNVdzZ2RpcVRERXJtN1ZDSEdJMldK?=
 =?utf-8?B?U2NNeGlaemtOU1ZoaHBxd1pGWGhtOXdPZE5XV3MyZ214QUtqMGx5VndEU3VN?=
 =?utf-8?B?NlA4b0lkbkhoM0V2MWVyOXN5SkNPWVhJRW93Z2RFRTNNRmVWRTE4YnBqTTJx?=
 =?utf-8?B?a3h2VEZ0SEUzMmtGcldPMmJMWXZMcTBqUW1CZnBNbTNwTjJ6TnJadGQ3YnBk?=
 =?utf-8?B?YnBLaG9VWVU0VUJjYzNNVnNGLzYrQkx4MXlLYzJvbmRGNXFrRXFLR2xRR3FN?=
 =?utf-8?B?UEdGRXI2aTJxYThHZFZPenRzYmVpTGQyejJCbDkxT2NFTnJmRjRhRTFhT2xZ?=
 =?utf-8?B?WFE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	4WVs2YduwC4D7p1F2yCJp1XAM/DC2EUtlRIA30jYt4qll5G85HfkS8Vkil804917hK9TzRqIOFsn/4txx30pCRioTzPzNsEKKlmvrFFdDhHjiBguVihIpbMweT/3kWP97QdnlBNjcksJWhutssUZCJL71JF1tzmiEEOhY74uuREvbhEWogWtDHOpKFI4PxhGpODjGjrwzFKvN89IO6620cmlyQrVdZRj4dP5/g0H9gqVPD1bZKXIQJQj/0yTQwe5imbFs1Pwsr1ZfMmajWFwIBhjKrXAPFVPJx2L8bMUkGEUDk8lrUeTrRSTOeYaXohC2lfH+a5sF/OW8kSaOQP7tHFE2fm3UoYEySLfjLh6AWNvN8upZZw+fm4SCIqdq7XtjKH45YNZzUx3gIKWZi7ZXbqDyC62qaiamoXes861XfB1a4JYbP/ujP7Na5rXMZmLpXGYv3Dcu6ANCJsSSxONHk+yM4NxEn+Cspo2uFRtNg3+cyXPIe+UrigRm0Y+YRwlS+b+yx5cVGs1b1/QDjxeliCXlazlyzAJjsyd9ZQTEzQLo80hnWelOwRLSq8ISE89RVLtmmQW98Li89C7i+mvQZArxpuznZ6DqY/aRFSuAS4=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 16fed12a-5e59-45ee-fd10-08dc31f74631
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 09:35:28.6120
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Tuvjv94QQxAjRbpLItJ4dYpYaGW5UzrL+7jalN+96Ety+5KKLkvbIE8cR7B1ijt7X2xVnxAJHoUqx2GwWkBRVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB6349
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-20_06,2024-02-19_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0
 mlxscore=0 spamscore=0 mlxlogscore=999 phishscore=0 bulkscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402200067
X-Proofpoint-GUID: ApoltNzY954qP1He8e0bDl9s5XV0K5Yt
X-Proofpoint-ORIG-GUID: ApoltNzY954qP1He8e0bDl9s5XV0K5Yt

On 20/02/2024 08:29, Christoph Hellwig wrote:
>> +#define BDEV_STATX_SUPPORTED_MASK (STATX_DIOALIGN | STATX_WRITE_ATOMIC)
> 
>> +	if (!(request_mask & BDEV_STATX_SUPPORTED_MASK))
>> +		return;
> 
> BDEV_STATX_SUPPORTED_MASK is misleading here.  bdevs support a lot more
> fields, these are just the ones needing special attention.  I'd do away
> with the extra define and just open code it.

ok, fine

> 
>> +	/* If this is a block device inode, override the filesystem
>> +	 * attributes with the block device specific parameters
>> +	 * that need to be obtained from the bdev backing inode
>> +	 */
> 
> This is not the normal kernel multi-line comment format.
> 

will fix

>> +	if (S_ISBLK(d_backing_inode(path.dentry)->i_mode))
>> +		bdev_statx(path.dentry, stat, request_mask);
> 
> I know I touched this last, but does anyone remember why we have
> various random fixups in vfs_statx and not in vfs_getattr_nosec, where
> they we have more of them and also the inode at hand?