Received-SPF: pass (google.com: domain of linux-kernel+bounces-72725-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Javier Martinez Canillas <javierm@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>, linux-kernel@vger.kernel.org
Cc: kernel test robot <lkp@intel.com>, oe-kbuild-all@lists.linux.dev,
 Andreas Larsson <andreas@gaisler.com>, Arnd Bergmann <arnd@arndb.de>,
 "David S. Miller" <davem@davemloft.net>, Helge Deller <deller@gmx.de>,
 sparclinux@vger.kernel.org
Subject: Re: [PATCH] sparc: Fix undefined reference to fb_is_primary_device
In-Reply-To: <929a159f-f6dd-49d3-b6b5-70ab7450ab19@suse.de>
References: <20240220003433.3316148-1-javierm@redhat.com>
 <929a159f-f6dd-49d3-b6b5-70ab7450ab19@suse.de>
Date: Tue, 20 Feb 2024 10:43:20 +0100
Message-ID: <87h6i3ii87.fsf@minerva.mail-host-address-is-not-set>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Thomas Zimmermann <tzimmermann@suse.de> writes:

Hello Thomas,

> Hi
>
> Am 20.02.24 um 01:34 schrieb Javier Martinez Canillas:
>> Commit 55bffc8170bb ("fbdev: Split frame buffer support in FB and FB_CORE
>> symbols") added a new FB_CORE Kconfig symbol, that can be enabled to only
>> have fbcon/VT and DRM fbdev emulation, but without support for any legacy
>> fbdev driver.
>>
>> Unfortunately, it missed to change a CONFIG_FB in arch/sparc/Makefile and
>> that leads to the following linking error in some sparc64 configurations:
>>
>>     sparc64-linux-ld: drivers/video/fbdev/core/fbcon.o: in function `fbcon_fb_registered':
>>>> fbcon.c:(.text+0x4f60): undefined reference to `fb_is_primary_device'
>> Fixes: 55bffc8170bb ("fbdev: Split frame buffer support in FB and FB_CORE symbols")
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes: https://lore.kernel.org/r/202401290306.IV8rhJ02-lkp@intel.com/
>> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
>> ---
>>
>> I don't have a sparc64 toolchain to test this patch, but I'm pretty sure
>> that this is the correct fix for the linking error reported by the robot.
>>
>>   arch/sparc/video/Makefile | 2 +-
>
> I think you also have to fix arch/sparc/Makefile.
>

Oh, you are right! Thanks for pointing that.

> Best regards
> Thomas
>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat