Received-SPF: pass (google.com: domain of linux-kernel+bounces-72795-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID:
 <SEZPR06MB6959E45F52C87C08320B7E7A96502@SEZPR06MB6959.apcprd06.prod.outlook.com>
Date: Tue, 20 Feb 2024 18:14:01 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH RFC v2 2/5] clk: hisilicon: add CRG driver for Hi3798MV200
 SoC
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Michael Turquette <mturquette@baylibre.com>, Stephen Boyd
 <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>
Cc: David Yang <mmyangfl@gmail.com>, linux-clk@vger.kernel.org,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240217-clk-mv200-v2-0-b782e4eb66f7@outlook.com>
 <20240217-clk-mv200-v2-2-b782e4eb66f7@outlook.com>
 <31188f64-7c6b-4279-a2d7-8b5133b1d485@linaro.org>
From: Yang Xiwen <forbidden405@outlook.com>
In-Reply-To: <31188f64-7c6b-4279-a2d7-8b5133b1d485@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SEZPR06MB6959:EE_|SEZPR06MB5574:EE_
X-MS-Office365-Filtering-Correlation-Id: 8ab090e3-0079-4da5-e097-08dc31fca9a1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	yzvafQpGYdWcOMHExSAL2YP/vwQU+w+Zwrjd8V6EUrxadb+mmyOabBp4LdCBNMJxbnWmqPMAgBVmsGrgN9IpdXlSvmO4rUQIPResZG5c23MAbx/DfiYToDkXdXYb/rrmM/uLV7RYA0lRYvAMey1PctRkNaCYVaRplH8O+lMAIBgulkvlGalQ3p4lIgvkqBtBxPNSWEz7zwn4cwZq06oG3MqwK2HsAPn29JZV0w/glAAz5PhjawYh4h8RAa0eacnmKHqxjtXy8G3GC3IWUkOgsdXiHPTA/inSbjfsi6ltvj8o9iDv/R2U3d6M9mk7Ld/OE4kxtXwB1/nL1w4jvBKTTiV5PgYk+4Z1ZcLzVNpGe5MjI7LZxdWGKtaV/1yBFkcIzrjioMjI4g5krdMCjPH4SwlCX8zPcIFIDQiNYA5Y+fHJUOnVgY5e3mkWn3E2wm2/mrcahfZq5dA4Zw6T8Fm8t36MOAadYvGBf9r/hjyE2ItfgEaYWzvLg6/bC58qLBhNqVzZhr89G99rM1X8yAd4poWSt4LfsfgmARmXCxTyrHbAJRs36wbBKhPOZWqmIthN
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MVF0N1Y3Mmdyd0ZZaEU2THNVaGF1cXBRSkIxeEw4eUh4NzlESGw1SURUUkVp?=
 =?utf-8?B?T2poRDhjakxvejl3Q3BRUmc1eTdCRXVZU0ZTRFRpV2d4SmtiTVRpOVJnSmg5?=
 =?utf-8?B?NjR2RWR1ek9jYVZjR2xsdVBNbEZVTXo3Tk5ieGJtV0Q3MlpFdXYrR1VXVVRo?=
 =?utf-8?B?WEhZaTcvL3hEcG13SFRDVVhwMXl0TzNwQmlFL1lmT3JCME5IVlQ3UWE2Y3U3?=
 =?utf-8?B?NjJSdE00OENvTUlEbml2cSs4YXlxTnpFcHNoMk0rTytMRVExY3YvakpRalAr?=
 =?utf-8?B?MWY2ak1sdHB2ZVpuS0RzMjh3a2VZRkhVOUhVUWtSdUpFOTIzeG5xMkVRWnVu?=
 =?utf-8?B?R0UzVXd4N0RJUEhKcWg3V01rRUpGa0U2aEU1b0dNbkxZQ3JZa3FNbkZXRHd4?=
 =?utf-8?B?TENwdnA4TUVhcnlhanA5RXluRTh3UEJpWXY2N2hZZU12TVlSNk5WaXhjckFa?=
 =?utf-8?B?anlJR0YrWmxSUGxoSmtrdEJvWUJuNUhTcVIvYlFIYjBrLzN3Z0REeFlPcWpi?=
 =?utf-8?B?eFErODFJR3M1bUYvTU50aC9IV3VwMzhqdFZqOGNUYit0OWNkQWhiVmpzOE5Q?=
 =?utf-8?B?dnFiWTh6NnpKRlJQbVVpeXFHSlYvdDlDZFZkMHpESVUvei9DbmNkNmJSUW9w?=
 =?utf-8?B?NEdGVXF5RDNFbEhTR3FldVJEYit1Q1B6Zzd6ZEFJUHY0Z3NlZjJEVEVHdUNl?=
 =?utf-8?B?aHRybktQUkZ2anQ2amRhTW9iSko2WTFXMVlXQmZWSUJZQWRvMDFXUXBNcUt5?=
 =?utf-8?B?K1dZWk5mUllvQVQ3c0p1aHp4Y3VQc2V5M2xuOVJjdDVpWEl2K05jcU9mTTRS?=
 =?utf-8?B?dUhxUkd3b3pzYjNJWXRQaGlOYUlHTG5SNithb25tYnBEN0k5SGd4aGcvUVZp?=
 =?utf-8?B?T0lpcGVpbWxFNXZweVpYeG1OMDVvVzZNUWRycERCY2NHamtNckNJYUJLamtV?=
 =?utf-8?B?Nm5QalNvdGNzYW15eXg3ckZHWGNyT0hQeUJrMnRuZXJSdmNWdjMzamJOSmRo?=
 =?utf-8?B?WGtCb1RSTGJOb1RJbzZLV3ZiVitJTUJMNDk5b0E0b2R3YWtDT2JyYmNyQXJo?=
 =?utf-8?B?WUl1ZHFvVS9PZjNoZm5obHd2VXh5aVZLVGdZWkhPMms3d281WGNyeG9IdSs1?=
 =?utf-8?B?dUxVOWNNcnF1UzYwMVo0ZGpZUU94OXRiaHZYRVF5dGhrYzlLazFQd0Iyb1BY?=
 =?utf-8?B?Q3dwTnhwOUM3T1p1K0VncTc5bVY2eVBoNWJtWEluWjk2NjA5RnVTbHJ4ZHAv?=
 =?utf-8?B?L0g3dThyY2VUcWFwU0Q1OUU2b2FCRWZ4NFJBTVhVUVVhVzNoUjJFeXJjWmVD?=
 =?utf-8?B?YVc5UFN5RFAzNlVMUnNzbE9PREJGVEFFSmU3SkNzMEozdTlMYm5SWGEySjJs?=
 =?utf-8?B?UTJZSyttYkw5OE5PVzlMeFdFbjEzSENOa1VoeE1IUEtuOFU2WFl4UFpTWm9k?=
 =?utf-8?B?bTFvQ0hCVkpkNmZ4Tk1TYUpXdUdndm03a0FGT1pYK0QyTmhHZExVdDZoRm9J?=
 =?utf-8?B?SC9UZ0lFcnpydGNlUlBiZ1hGdkF1RE95RlhvRFBsd1JremY3YjVGNXBPSWh2?=
 =?utf-8?B?eUV4TjJJNkg5RmwvVVhkdVFpYnBYSWVKeVJhNXF1YXg3RGVJVE0xSTlHOVdx?=
 =?utf-8?B?MG1yelo2Q2JnbHY2RUFtbjVmM0Y1Mjk1TC9pUXhHOTQ0R0IzQVB2NzNWNzdq?=
 =?utf-8?B?bllkY2VVYVpzR1dnaCs2UXVnLzdPVmpHQ1ljRXkwVGt1WDJyNmNsbmpCM3M1?=
 =?utf-8?Q?IHyfMwSA397VbGDAR88eFWdwQWwoUwXPyajL3fy?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ab090e3-0079-4da5-e097-08dc31fca9a1
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB6959.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 10:14:02.8537
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB5574

On 2/20/2024 6:11 PM, Krzysztof Kozlowski wrote:
> On 17/02/2024 13:52, Yang Xiwen via B4 Relay wrote:
>> +
>> +static const struct hisi_crg_funcs hi3798mv200_sysctrl_funcs = {
>> +	.register_clks = hi3798mv200_sysctrl_clk_register,
>> +	.unregister_clks = hi3798mv200_sysctrl_clk_unregister,
>> +};
>> +
>> +static const struct of_device_id hi3798mv200_crg_match_table[] = {
>> +	{ .compatible = "hisilicon,hi3798mv200-crg",
>> +		.data = &hi3798mv200_crg_funcs },
>> +	{ .compatible = "hisilicon,hi3798mv200-sysctrl",
>> +		.data = &hi3798mv200_sysctrl_funcs },
> These are undocumented compatibles. Run checkpatch or properly order
> your patchset.
It's in patch 5. You mean binding patch first and then driver?
>
> Best regards,
> Krzysztof
>

-- 
Regards,
Yang Xiwen