Received-SPF: pass (google.com: domain of linux-kernel+bounces-72837-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Inochi Amaoto <inochiama@outlook.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Inochi Amaoto <inochiama@outlook.com>,
	Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Chen Wang <unicorn_wang@outlook.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Jisheng Zhang <jszhang@kernel.org>,
	Liu Gui <kenneth.liu@sophgo.com>,
	Jingbao Qiu <qiujingbao.dlmu@gmail.com>,
	dlan@gentoo.org,
	devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org
Subject: Re: [PATCH v3 1/2] dt-bindings: clock: sophgo: Add top misc controller of CV18XX/SG200X series SoC
Date: Tue, 20 Feb 2024 18:37:36 +0800
Message-ID:
 <PH7PR20MB4962ADC17704683D90B8BE13BB502@PH7PR20MB4962.namprd20.prod.outlook.com>
In-Reply-To: <99df43cc-37fd-4f50-a086-2864a6545673@linaro.org>
References: <99df43cc-37fd-4f50-a086-2864a6545673@linaro.org>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: PH7PR20MB4962:EE_|BL1PR20MB4588:EE_
X-MS-Office365-Filtering-Correlation-Id: 234d5a0e-b576-497f-dfbd-08dc31fff92f
X-MS-Exchange-SLBlob-MailProps:
	O8uo9vZ0QHU57nZ+bmZTlwNTf5+IW0LuC9iPUZYaWsHeSP++fhOBBc3yKcwAgmf1ivcP0GXzo58GlXsUen18DN4ssnfCU+sSE4x5QbFDyBT7cNoVZf8Ze6yKrNFGRfP48Ai4wJd04HpYIwGu+zU/b2NTdF6zlOsm/0YxnaWPT2n/2PUEjA7EycRqKbCMv0dUM+AEETb086bWYpkuCpQxhANrZbAzL36m+WPCetupWPOyzJNEjaA6tvJBSwKSuhH55DmhdiOFxFAhxxQGzKQp7b1ogvQGVeXWX0/e5vKIQsoScUpL7y2F4Sp3vK8Gspc3giXgPpmEk8RD7RStMgsNjy8602aRYsQVUEuTzH+VSqkRg2QRmiJMpgGwkDH3NgrGsivuaEG281SGYLGhm1gjhEBenqrDStEzrBKxoAlbSLbc4ReBYN2BMKRFtauBwHmI98dxJyDA1cudFmdWmAuZi4YysEeilooYYPaJBZRsmXctW+3cakQDfnCutzJbU6x+YvBLLMMf8si8ibat4lt1Rb0CmVoJFFbQoQm5Aomm8VyOrJDrch1MMWz/orx0HHdnRBwHdSq94lLPc4MDfoNZaSGQnI2qLKEZq+HELiSpDHKzEOdrKo09gCBn6KXmLvqAL83ql0VFVOi9zqpF8DpHwz7h9e6VDS2tHkQkF2RRxLHlGYyGPZT78o4XMG90t6jwTOnFVCkUx31be0oUspSTw/AeeWjarlqgktyZA5FsM0HuKyjSr7Tp/9z/F4I+yhCR7JxA3phzcuvx2TNZXmsYv4VWuck7ye85bhl2eR6W4CkKahXu/mITz2wVSODmjeopjdrQbgaWI+GFhMt5BFKV0aw9iZ4083aFHgh9ofdLAFQOPcT62RPTW3EG7yQyItZ7RZXPdrxSKtHbzBc8YWq2gw==
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	kqzZ6xaUwxo+zPKT3BsbugFwLLv2l6kI+4QfqbtDLudb8IZaXst6M5BT+n6zNmrKhUYKPqrXBBnKDMs3iwmEn2uuvCqr28HYHUmsIowTkTjiaKDrccesBHtBYQDbZVlERd9aRksBWmyRtGm3XyC8mtuK/C+gHGktvl5AE0JB/lvK0vxSaOIDQRTkYiYOQT6i9JfhEIV6OYrlxrOl15bns0vszbmcJ2B9cPJyaQ/h9j8KFo5qZ9vSarwkUMbGDHL8c+ZtyfS6i9JQtzNlGC1LilzKqjtoIJy69vA17fJvzuIW4cJDsQ/Gci3xikTG+9Yw438Pb5nG2ZyrnA6PtSQPI+nDRw1Kz7DV/B1e/KMw7feYk16xJ1mgjen2/+z0iRycS9ECIjv+HCqB0HXNVlEDu8BDo9fKIxqdZpRNBF/VPCYCazATiM/eFX5t1jq+9kAL7vR3t1a2gyH7pSkWHVbxqKtThvTUPOMQVvARcO4C9goabQEFTSS491ejZi+jqmXJykedYpgeU7fFEIP7xAuuBPtUOHALKAyEDjo/G61u3YNF7pOMio1PBauqUdWxx047AEA9AKAZswjJrGEphyrTmOliImy40cf9bHz2xEpzw1Jxg6IOsK4hTXKWsQIJ06xJ
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?8tTfnqpj3S/60MS2ulNXouMjaWgJfXTgVfxSv26doO0iASgVvp8EA2zYvwO/?=
 =?us-ascii?Q?/goGY0o4nDiDZ0TsmwiUk0opiyL8MBL2EXXt3V5mzREpI9sk9giA8qk54Y/N?=
 =?us-ascii?Q?HJWEBLFZ9r4dyGIeW2FlnO+wlvTDXc8Ut/3U0O0PIFcJ3V5XA4Ok69uTBghr?=
 =?us-ascii?Q?4/NOLzmA/UEZlOu4a+0hWunpxMBFg5lrBmrJE83RRFP7fX6mUETthuTVs7Ow?=
 =?us-ascii?Q?E4EEoU4/1VfrT0fclNqfZAQiTA3NYIn6YK29P+o2Zb1Qd8hgkgaP0humzImf?=
 =?us-ascii?Q?t6wj1y1w5Le8PoiM9CzS7TKcbpLqnLDIAZshJ/oZVmUEiMk6AVakQ1slQ++X?=
 =?us-ascii?Q?VzFDB7JV2CbnHsnuZgrcVYe/vAHdK8sjC4q4vQUaGdVuEKsJBUIt5opqjz6o?=
 =?us-ascii?Q?Fj2Ff2MexbXmW6uyhISBVXZ7LVQ5Yv6pJQMyL1rdJHgFOY0nRvPx9+w65ktS?=
 =?us-ascii?Q?JZLOaJmfDIJm4950r9bDK16kee95+Ofe7QZDzBjkI9D5F0+tIdvqAVcvgaDH?=
 =?us-ascii?Q?4SSF8B7Vts1vN8o7g1nqyIF4dIFcrlNm/rfSSiKQKPw/gim2WoTlVsAKWKsX?=
 =?us-ascii?Q?Yq57Hr2WakGWgVfQ8vsT0mvcHOxTSrhOHxmIAnpW1m1EocVOhNxRUWNFCWPW?=
 =?us-ascii?Q?YAUMh0pJh1I/EjfaXyhlQCVyh+JLFEXP2M3UAY7P5vagR2tiOPIqPhb+3rcd?=
 =?us-ascii?Q?hpiAqNWRPafCMwWGB/CDrFPOn6DoaHejeenJjhVyfMMrvemIpAMxUr+b46TG?=
 =?us-ascii?Q?eb70BC0iMSOjILn11KnXESfgbtJon9z1udgWiy8jIeyBQIu8sttTC8xV++vG?=
 =?us-ascii?Q?t35GuCs7qelGlMEAZjEBSwb1DgfqXwd/Z8v1FkTNzPYOnD+fHVWfQa0OQh/X?=
 =?us-ascii?Q?qMwvOAX7cU0sDSeHc4uKSgUKL0FCDlHQ/InpXEgbLFgX3YcokLlC0wmwOMQT?=
 =?us-ascii?Q?phR+ki4AuPQ0oh62aKQjgdIovN25Mo+63QEh++ujeG6Gy+Kp/38tkj/+GAaW?=
 =?us-ascii?Q?5kgBN/o/+0jPIoNytHf0ASJ+agR8gHJ6lWfkVtaMLbua8fPXY1Acn0zON8sy?=
 =?us-ascii?Q?5oh0RPdd5xfeDGOeC7uFk6fE/abO7f5vxa1gDMXC3QW7fdI1yz+vg/uHDh2s?=
 =?us-ascii?Q?5fi1Lm9RmPUwnKZbN9cytsnH0Gp3k4jSRtb7ODClmzOF9MTMPxg5OhUcPQ/A?=
 =?us-ascii?Q?mzeChkag/0kxHeMxqpaskrRiegMgKRLvtKSlU7EuqAyigF//HCHn0JEwOCQG?=
 =?us-ascii?Q?LNYDrN/0Dn0zlNFSLedZ?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 234d5a0e-b576-497f-dfbd-08dc31fff92f
X-MS-Exchange-CrossTenant-AuthSource: PH7PR20MB4962.namprd20.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 10:37:44.9960
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR20MB4588

>On 16/02/2024 00:56, Inochi Amaoto wrote:
>>> On Wed, Feb 14, 2024 at 02:33:14PM +0800, Inochi Amaoto wrote:
>>>> CV18XX/SG200X series SoCs have a special top misc system controller,
>>>> which provides register access for several devices. In addition to
>>>> register access, this system controller also contains some subdevices
>>>> (such as dmamux).
>>>>
>>>> Add bindings for top misc controller of CV18XX/SG200X series SoC.
>>>>
>>>> Signed-off-by: Inochi Amaoto <inochiama@outlook.com>
>>>> ---
>>>>  .../soc/sophgo/sophgo,cv1800-top-syscon.yaml  | 40 +++++++++++++++++++
>>>>  1 file changed, 40 insertions(+)
>>>>  create mode 100644 Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.yaml
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.yaml b/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.yaml
>>>> new file mode 100644
>>>> index 000000000000..619237532801
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.yaml
>>>> @@ -0,0 +1,40 @@
>>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>>> +%YAML 1.2
>>>> +---
>>>> +$id: http://devicetree.org/schemas/soc/sophgo/sophgo,cv1800-top-syscon.yaml#
>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>> +
>>>> +title: Sophgo CV1800/SG2000 SoC top system controller
>>>> +
>>>> +maintainers:
>>>> +  - Inochi Amaoto <inochiama@outlook.com>
>>>> +
>>>> +description:
>>>> +  The Sophgo CV1800/SG2000 SoC top misc system controller provides
>>>> +  register access to configure related modules.
>>>> +
>>>> +properties:
>>>> +  compatible:
>>>> +    items:
>>>> +      - const: sophgo,cv1800-top-syscon
>>>> +      - const: syscon
>>>> +      - const: simple-mfd
>>>
>>> You have to define child nodes to be a simple-mfd.
>>>
>>> You could drop it, but I now suspect your binding is incomplete.
>>>
>>> Rob
>>
>> Hi Rob,
>>
>> I have a small questions: Can I drop "simple-mfd" and just add it
>> when the new subdevice is added? I know the binding is just a example,
>
>No, because bindings should be complete.
>
>
>Best regards,
>Krzysztof
>

Thanks. And please see
https://lore.kernel.org/linux-kernel/PH7PR20MB49624AFE44E26F26490DC827BB502@PH7PR20MB4962.namprd20.prod.outlook.com/T/#t.
This new patch series includes this binding.