Received-SPF: pass (google.com: domain of linux-kernel+bounces-71150-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <82320769f502c5fadad90f1ec8d782c6ef423f56.camel@iokpp.de>
Subject: Re: [PATCH v2] PCI: Increase maximum PCIe physical function number
 to 7 for non-ARI devices
From: Bean Huo <beanhuo@iokpp.de>
To: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>,
  bhelgaas@google.com, schnelle@linux.ibm.com
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Bean Huo
	 <beanhuo@micron.com>, stable@vger.kernel.org
Date: Mon, 19 Feb 2024 11:50:23 +0100
In-Reply-To: <4858e202-6097-493a-8405-86d3e8e17c83@linux.intel.com>
References: <20240216190113.20341-1-beanhuo@iokpp.de>
	 <4858e202-6097-493a-8405-86d3e8e17c83@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
Precedence: bulk
MIME-Version: 1.0

On Fri, 2024-02-16 at 14:26 -0800, Kuppuswamy Sathyanarayanan wrote:
> It looks like for an ARI capable device the limit is 256. Why not add
> that
> check as well?

" With ARI, the 16-bit field is interpreted as two fields
instead of three: an 8-bit Bus Number and an 8-bit Function Number -
the Device Number field is eliminated. This new
interpretation enables an ARI Device to support up to 256 Functions
[0..255] instead of 8 Functions [0..7]."

the above statement on PCIe Spec highlights that since the Function
Number field in an ARI-enabled device is 8 bits, it inherently supports
numbering from 0 to 255. Thus, there's no need for additional checks to
limit the function number to this range; the 8-bit size of the field
naturally imposes this limit. This efficient use of the available
address space aligns with the goals of ARI to enhance device
functionality within the PCIe specification.

Kind regards,
Bean