Received-SPF: pass (google.com: domain of linux-kernel+bounces-72910-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <3ad2909d-4ac3-fff3-739d-b12a3408fa0f@quicinc.com>
Date: Tue, 20 Feb 2024 17:02:40 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH 0/5] Add QPIC SPI NAND driver
Content-Language: en-US
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
CC: <andersson@kernel.org>, <konrad.dybcio@linaro.org>, <broonie@kernel.org>,
        <robh@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <conor+dt@kernel.org>, <miquel.raynal@bootlin.com>, <richard@nod.at>,
        <vigneshr@ti.com>, <linux-arm-msm@vger.kernel.org>,
        <linux-spi@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-mtd@lists.infradead.org>,
        <quic_srichara@quicinc.com>, <quic_varada@quicinc.com>
References: <20240215134856.1313239-1-quic_mdalam@quicinc.com>
 <20240219130412.GC3281@thinkpad>
From: Md Sadre Alam <quic_mdalam@quicinc.com>
In-Reply-To: <20240219130412.GC3281@thinkpad>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 2/19/2024 6:34 PM, Manivannan Sadhasivam wrote:
> On Thu, Feb 15, 2024 at 07:18:51PM +0530, Md Sadre Alam wrote:
>> This series of patches will add initial supports
>> for QPIC SPI NAND driver.
>>
>> Currently this driver support following commands
>>
>> -- RESET
>> -- READ ID
>> -- BLOCK ERASE
>> -- PAGE READ
>> -- PAGE WRITE
>> -- GET FEATURE
>> -- SET FEATURE
>> -- BAD BLOCK CHECK
>>
>> This driver has been tested with dd command with read/write page
>> with multiple file size 1MiB, 10MiB,40MiB etc.
>> Also tested with "mtd" command like mtd erase, mtd write, mtd verify etc.
>>
> 
> This is not the first version isn't it? Where is the changelog describing what
> has changed since then?

   The earlier patch was the RFC for design review only.
> 
> - Mani
> 
>> Need help to test these all patches on SDX65 and SDX75 platform.
>>
>> Md Sadre Alam (5):
>>    spi: dt-bindings: add binding doc for spi-qpic-snand
>>    drivers: mtd: nand: Add qpic_common API file
>>    spi: spi-qpic: Add qpic spi nand driver support
>>    arm64: dts: qcom: ipq9574: Add SPI nand support
>>    arm64: dts: qcom: ipq9574: Disable eMMC node
>>
>>   .../bindings/spi/qcom,spi-qpic-snand.yaml     |   82 ++
>>   .../boot/dts/qcom/ipq9574-rdp-common.dtsi     |   43 +
>>   arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts   |    2 +-
>>   arch/arm64/boot/dts/qcom/ipq9574.dtsi         |   27 +
>>   drivers/mtd/nand/Makefile                     |    1 +
>>   drivers/mtd/nand/qpic_common.c                |  794 +++++++++++
>>   drivers/mtd/nand/raw/qcom_nandc.c             | 1226 +----------------
>>   drivers/spi/Kconfig                           |    9 +
>>   drivers/spi/Makefile                          |    1 +
>>   drivers/spi/spi-qpic-snand.c                  | 1025 ++++++++++++++
>>   include/linux/mtd/nand-qpic-common.h          |  548 ++++++++
>>   11 files changed, 2547 insertions(+), 1211 deletions(-)
>>   create mode 100644 Documentation/devicetree/bindings/spi/qcom,spi-qpic-snand.yaml
>>   create mode 100644 drivers/mtd/nand/qpic_common.c
>>   create mode 100644 drivers/spi/spi-qpic-snand.c
>>   create mode 100644 include/linux/mtd/nand-qpic-common.h
>>
>> -- 
>> 2.34.1
>>
>