Received-SPF: pass (google.com: domain of linux-kernel+bounces-72913-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <74cfdded-be3a-4af6-b23a-eea2c5e748b8@amd.com>
Date: Tue, 20 Feb 2024 12:34:18 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] dt-bindings: rtc: zynqmp: Describe power-domains property
Content-Language: en-US
To: "Buddhabhatti, Jay" <jay.buddhabhatti@amd.com>,
 Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "monstr@monstr.eu" <monstr@monstr.eu>,
 "michal.simek@xilinx.com" <michal.simek@xilinx.com>,
 "git@xilinx.com" <git@xilinx.com>, Conor Dooley <conor+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Rob Herring <robh@kernel.org>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@vger.kernel.org>,
 "moderated list:ARM/ZYNQ ARCHITECTURE"
 <linux-arm-kernel@lists.infradead.org>,
 "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" <linux-rtc@vger.kernel.org>
References: <202402192019160b9c4120@mail.local>
 <DM6PR12MB4465FAF7AB3F9CE15FAC6C879D502@DM6PR12MB4465.namprd12.prod.outlook.com>
From: Michal Simek <michal.simek@amd.com>
Autocrypt: addr=michal.simek@amd.com; keydata=
 xsFNBFFuvDEBEAC9Amu3nk79+J+4xBOuM5XmDmljuukOc6mKB5bBYOa4SrWJZTjeGRf52VMc
 howHe8Y9nSbG92obZMqsdt+d/hmRu3fgwRYiiU97YJjUkCN5paHXyBb+3IdrLNGt8I7C9RMy
 svSoH4WcApYNqvB3rcMtJIna+HUhx8xOk+XCfyKJDnrSuKgx0Svj446qgM5fe7RyFOlGX/wF
 Ae63Hs0RkFo3I/+hLLJP6kwPnOEo3lkvzm3FMMy0D9VxT9e6Y3afe1UTQuhkg8PbABxhowzj
 SEnl0ICoqpBqqROV/w1fOlPrm4WSNlZJunYV4gTEustZf8j9FWncn3QzRhnQOSuzTPFbsbH5
 WVxwDvgHLRTmBuMw1sqvCc7CofjsD1XM9bP3HOBwCxKaTyOxbPJh3D4AdD1u+cF/lj9Fj255
 Es9aATHPvoDQmOzyyRNTQzupN8UtZ+/tB4mhgxWzorpbdItaSXWgdDPDtssJIC+d5+hskys8
 B3jbv86lyM+4jh2URpnL1gqOPwnaf1zm/7sqoN3r64cml94q68jfY4lNTwjA/SnaS1DE9XXa
 XQlkhHgjSLyRjjsMsz+2A4otRLrBbumEUtSMlPfhTi8xUsj9ZfPIUz3fji8vmxZG/Da6jx/c
 a0UQdFFCL4Ay/EMSoGbQouzhC69OQLWNH3rMQbBvrRbiMJbEZwARAQABzSlNaWNoYWwgU2lt
 ZWsgKEFNRCkgPG1pY2hhbC5zaW1la0BhbWQuY29tPsLBlAQTAQgAPgIbAwULCQgHAgYVCgkI
 CwIEFgIDAQIeAQIXgBYhBGc1DJv1zO6bU2Q1ajd8fyH+PR+RBQJkK9VOBQkWf4AXAAoJEDd8
 fyH+PR+ROzEP/1IFM7J4Y58SKuvdWDddIvc7JXcal5DpUtMdpuV+ZiHSOgBQRqvwH4CVBK7p
 ktDCWQAoWCg0KhdGyBjfyVVpm+Gw4DkZovcvMGUlvY5p5w8XxTE5Xx+cj/iDnj83+gy+0Oyz
 VFU9pew9rnT5YjSRFNOmL2dsorxoT1DWuasDUyitGy9iBegj7vtyAsvEObbGiFcKYSjvurkm
 MaJ/AwuJehZouKVfWPY/i4UNsDVbQP6iwO8jgPy3pwjt4ztZrl3qs1gV1F4Zrak1k6qoDP5h
 19Q5XBVtq4VSS4uLKjofVxrw0J+sHHeTNa3Qgk9nXJEvH2s2JpX82an7U6ccJSdNLYbogQAS
 BW60bxq6hWEY/afbT+tepEsXepa0y04NjFccFsbECQ4DA3cdA34sFGupUy5h5la/eEf3/8Kd
 BYcDd+aoxWliMVmL3DudM0Fuj9Hqt7JJAaA0Kt3pwJYwzecl/noK7kFhWiKcJULXEbi3Yf/Y
 pwCf691kBfrbbP9uDmgm4ZbWIT5WUptt3ziYOWx9SSvaZP5MExlXF4z+/KfZAeJBpZ95Gwm+
 FD8WKYjJChMtTfd1VjC4oyFLDUMTvYq77ABkPeKB/WmiAoqMbGx+xQWxW113wZikDy+6WoCS
 MPXfgMPWpkIUnvTIpF+m1Nyerqf71fiA1W8l0oFmtCF5oTMkzsFNBFFuvDEBEACXqiX5h4IA
 03fJOwh+82aQWeHVAEDpjDzK5hSSJZDE55KP8br1FZrgrjvQ9Ma7thSu1mbr+ydeIqoO1/iM
 fZA+DDPpvo6kscjep11bNhVa0JpHhwnMfHNTSHDMq9OXL9ZZpku/+OXtapISzIH336p4ZUUB
 5asad8Ux70g4gmI92eLWBzFFdlyR4g1Vis511Nn481lsDO9LZhKyWelbif7FKKv4p3FRPSbB
 vEgh71V3NDCPlJJoiHiYaS8IN3uasV/S1+cxVbwz2WcUEZCpeHcY2qsQAEqp4GM7PF2G6gtz
 IOBUMk7fjku1mzlx4zP7uj87LGJTOAxQUJ1HHlx3Li+xu2oF9Vv101/fsCmptAAUMo7KiJgP
 Lu8TsP1migoOoSbGUMR0jQpUcKF2L2jaNVS6updvNjbRmFojK2y6A/Bc6WAKhtdv8/e0/Zby
 iVA7/EN5phZ1GugMJxOLHJ1eqw7DQ5CHcSQ5bOx0Yjmhg4PT6pbW3mB1w+ClAnxhAbyMsfBn
 XxvvcjWIPnBVlB2Z0YH/gizMDdM0Sa/HIz+q7JR7XkGL4MYeAM15m6O7hkCJcoFV7LMzkNKk
 OiCZ3E0JYDsMXvmh3S4EVWAG+buA+9beElCmXDcXPI4PinMPqpwmLNcEhPVMQfvAYRqQp2fg
 1vTEyK58Ms+0a9L1k5MvvbFg9QARAQABwsF8BBgBCAAmAhsMFiEEZzUMm/XM7ptTZDVqN3x/
 If49H5EFAmQr1YsFCRZ/gFoACgkQN3x/If49H5H6BQ//TqDpfCh7Fa5v227mDISwU1VgOPFK
 eo/+4fF/KNtAtU/VYmBrwT/N6clBxjJYY1i60ekFfAEsCb+vAr1W9geYYpuA+lgR3/BOkHlJ
 eHf4Ez3D71GnqROIXsObFSFfZWGEgBtHBZ694hKwFmIVCg+lqeMV9nPQKlvfx2n+/lDkspGi
 epDwFUdfJLHOYxFZMQsFtKJX4fBiY85/U4X2xSp02DxQZj/N2lc9OFrKmFJHXJi9vQCkJdIj
 S6nuJlvWj/MZKud5QhlfZQsixT9wCeOa6Vgcd4vCzZuptx8gY9FDgb27RQxh/b1ZHalO1h3z
 kXyouA6Kf54Tv6ab7M/fhNqznnmSvWvQ4EWeh8gddpzHKk8ixw9INBWkGXzqSPOztlJbFiQ3
 YPi6o9Pw/IxdQJ9UZ8eCjvIMpXb4q9cZpRLT/BkD4ttpNxma1CUVljkF4DuGydxbQNvJFBK8
 ywyA0qgv+Mu+4r/Z2iQzoOgE1SymrNSDyC7u0RzmSnyqaQnZ3uj7OzRkq0fMmMbbrIvQYDS/
 y7RkYPOpmElF2pwWI/SXKOgMUgigedGCl1QRUio7iifBmXHkRrTgNT0PWQmeGsWTmfRit2+i
 l2dpB2lxha72cQ6MTEmL65HaoeANhtfO1se2R9dej57g+urO9V2v/UglZG1wsyaP/vOrgs+3
 3i3l5DA=
In-Reply-To: <DM6PR12MB4465FAF7AB3F9CE15FAC6C879D502@DM6PR12MB4465.namprd12.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TTdMZlJROHE3L1RpclpxMVBwZEZZTklkTGRtRS8ybWhUMXFmQ2tOWW95OGpI?=
 =?utf-8?B?dlNjRzZtSTc5cnNTY1A5eFA3aG1UZmlGV2tMYzlXWXptSjlFVXZGMDhyeXJT?=
 =?utf-8?B?bDk4OTQ0MkMybFNTN0p5cTg0Q3M2MEU3b3NxWE8vayt0MDd2blNLaVROb0xJ?=
 =?utf-8?B?ZUV5OTFUV3BpejVFUGhSZ0x5Mi91aHdZanlTOThucGFibWRRWU9mcUN2endK?=
 =?utf-8?B?aUM5N2M3WC90Qy9hTVdXSDlkVGNQdjkxd3NkY3hoUVVOSEpIbjNmczVXcFM1?=
 =?utf-8?B?R3JjeW9od3E2aUtrT2pXak5UNitIUkNudGZnSEs2ZFc1cDl6ekRIYWl3NTgx?=
 =?utf-8?B?T1lyWEJPeDAvWkEwZjZnOXRCb3NtZ1F3N0l4VGZyNEJCOHEyQ2Z0ZnpTTzR2?=
 =?utf-8?B?b2pQcXZoUFFmU1h0VEV5bDNkSDVDNnZmMDBxVi9jMCttVXFVUUpmWDdyR2Nx?=
 =?utf-8?B?YnBmL2VFN1dJNlpXQkRtOWVQV1lENWUxUXc1b2hDc1psUm1qVUYxSEpMb0hk?=
 =?utf-8?B?S0FsYjk5THhYN0NBMHhIQUQwdnFxUlNuNnNvaUN4QWxpK1dKMWE4VnN1RGR6?=
 =?utf-8?B?a2MrN3lxK1YzTXZsaE53TXJlZDlWb0dLTXljQ1h6clp1TkpsandSbDBUQ0hr?=
 =?utf-8?B?dkFncVh6UTYvK2tCYkdLcTFQREhjdldDemFxT2ZabktwdmwzKzNrTFF3VUhq?=
 =?utf-8?B?NFpWOHQzWlhkc21sMkJPTE9VZnN6czZkdUxDVkxpSUZMK2VuT3BueG1NbUFa?=
 =?utf-8?B?Yng3Rk9qS0NXMEs1N2RQdjIyM2lkc0ZOcXhsUmVKaXhsYUl2V1pYVElralNR?=
 =?utf-8?B?aWg5Rmk4NXF3TDBoODBMWWVuZVNvK0VQbGlJelNBTUNuVTBhemJ3enorOU9W?=
 =?utf-8?B?aW01NmNYWUdSZEE3aGpQb1pSK1FmbUxpOTdVTXRGQnBLRk4rV05DK2tCQmw4?=
 =?utf-8?B?SE5pdExoQmhPWXlHQzZrVjgrZFk3QVpsQ2tYVnNGaysvUGpyTDRhVW10NC9H?=
 =?utf-8?B?N0hVQ21WZm1JZm1iZDMwZE00dE5BOGxya1RYcjdlbGNaT3NNNmtQeDMzd0tn?=
 =?utf-8?B?ZHFVN1BIT1VQNGpHMHRNSEQxNmpTU1NIQjRUZFNrWHZJVXJia2ErYkxYdkVy?=
 =?utf-8?B?aHBkNG4xNGF1dHVoOWdiTUdYRHhBTTk0d21QV1htOExVOE5vOGVxNEh1UFFi?=
 =?utf-8?B?NzlNbUZzaHpXclNBVVZ5L0ZpclJIcmMyU0duN1ErLzRQbnJ3TU5FWkVQMUFD?=
 =?utf-8?B?ZnFJYmlQUU8vcGtScmhCS3dwL2pSTkVqVEpIRjN5SDI0SHkyeldhSnp4bnBo?=
 =?utf-8?B?N1A1Um5uRFlRREFzWlkwTzR2TzkvTnlwOWlObVB3QktLbjIwR3JNUjlTUkJQ?=
 =?utf-8?B?WUsrKzRjNWxnVFBGeS9PVlVkcUdPMmJhYlVPOHZ3NmQxcElaVWxWcEFvQXVi?=
 =?utf-8?B?bElrN0lWeW9XVHJzT25VdW5IK2Z2WWt1Yi9BN3pEUmVGKy9mbWd6OTVRSC8z?=
 =?utf-8?B?ajdZV3ExV3JYZE9QLy9GU0hCVEVKRkdYY0ptbElmVDlHOTFvdTN1MW9qZU4v?=
 =?utf-8?B?WVRmTEM4RnFZbmVEVXA4a2hsVm02UVVLNklycnFaSFhGWDhHamIyZ0dNcjZi?=
 =?utf-8?B?MjhWMmYrU1Y4bG9NclhSMHJLaDdWZXM1QXkwN3VwbWlwdE5VSGxDbDBVMWdC?=
 =?utf-8?B?KzRlYmZ6MjE3M0d4b0hPaFA4c0tYY0p4MUUxaExkQko3NFhHWk9OdkNNbWsz?=
 =?utf-8?B?ZHRZRGN5N3hLOVVIUnBmQVE0Tkg4OUVLekc5RUNzMDRMSWhtUUhvdWV6VXFF?=
 =?utf-8?B?dW1SVFFwYXU2MXRPWlNxekR4cHhEUE5xVit4ZDJVcmYvTFhUQ2hZTFZTbTlN?=
 =?utf-8?B?YlQwRmg5eWl6eE1TM0hRRThXN2pGbE01anVLc0Z1c1JTUlFETHhlUlRzYTJ5?=
 =?utf-8?B?a2pNQjRPMmVKZXhoNHdFUllMSmYvUlNvVkh3bXNISWJneHUzTi9YNmVLMnZB?=
 =?utf-8?B?ek1VSVhHYk44bjczRkRFT2JwNWFkUnhIa0FVK1JoVDBpQmhSdkpISTI5ZVQ4?=
 =?utf-8?B?MW5abzh2dENxNTdaU1RlWHFiUHEwL05QQW1SRTErWDhyUk5OMy9POEUrT2dG?=
 =?utf-8?Q?Bn5Jr4tWngVwsmwdx6BBpXjtU?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 157af0e4-75ee-48cc-d866-08dc3207e7cd
X-MS-Exchange-CrossTenant-AuthSource: CYXPR12MB9337.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 11:34:31.7075
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LrYVBeSEOAJQe8GbEXTnn5vaN3kP3OK+1eeA8hsLCvYckQ7AtR/f5WXS7qbFn66d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5806


On 2/20/24 11:51, Buddhabhatti, Jay wrote:
> Hi Alexandre,
> 
>> -----Original Message-----
>> From: Alexandre Belloni <alexandre.belloni@bootlin.com>
>> Sent: Tuesday, February 20, 2024 1:49 AM
>> To: Simek, Michal <michal.simek@amd.com>
>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; linux-
>> kernel@vger.kernel.org; monstr@monstr.eu; michal.simek@xilinx.com;
>> git@xilinx.com; Conor Dooley <conor+dt@kernel.org>; Krzysztof Kozlowski
>> <krzysztof.kozlowski+dt@linaro.org>; Rob Herring <robh@kernel.org>; open
>> list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
>> <devicetree@vger.kernel.org>; moderated list:ARM/ZYNQ ARCHITECTURE
>> <linux-arm-kernel@lists.infradead.org>; open list:REAL TIME CLOCK (RTC)
>> SUBSYSTEM <linux-rtc@vger.kernel.org>
>> Subject: Re: [PATCH] dt-bindings: rtc: zynqmp: Describe power-domains
>> property
>>
>> On 19/02/2024 14:11:50+0100, Michal Simek wrote:
>>>
>>>
>>> On 2/17/24 09:26, Krzysztof Kozlowski wrote:
>>>> On 16/02/2024 10:42, Michal Simek wrote:
>>>>>
>>>>>
>>>>> On 2/16/24 10:19, Krzysztof Kozlowski wrote:
>>>>>> On 16/02/2024 09:51, Michal Simek wrote:
>>>>>>> RTC has its own power domain on Xilinx Versal SOC that's why
>>>>>>> describe it as optional property.
>>>>>>>
>>>>>>> Signed-off-by: Michal Simek <michal.simek@amd.com>
>>>>>>> ---
>>>>>>>
>>>>>>>     Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml | 3
>> +++
>>>>>>>     1 file changed, 3 insertions(+)
>>>>>>>
>>>>>>
>>>>>> But Versal is not described in this binding, is it? I see only
>>>>>> one compatible.
>>>>>
>>>>> It is the same IP only as is on zynqmp with own power rail.
>>>>
>>>> Then you should have separate compatible, because they are not
>>>> identical. It would also allow you to narrow the domains to versal
>>>> and also require it (on versal).
>>>
>>> I can double check with HW guys but I am quite sure IP itself is
>>> exactly the same. What it is different is that there is own power
>>> domain to it (not shared one as is in zynqmp case).
>>>
>>> Also Linux is non secure sw and if secure firmware won't allow to
>>> change setting of it it can't be required. I am just saying that Linux
>>> doesn't need to be owner of any power domain that's why it shouldn't
>>> be required property.
>>
>> I guess because the integration is different, you still need a differente
>> compatible so you can forbid the property on non-Versal.
> 
> [Jay] RTC has its own power domain in case of Versal and ZynqMP both that we double check it.

Thanks Jay for looking into it. I should definitely update my commit message to 
reflect it. Do you still want me to create soc specific property?

Thanks,
Michal