Received-SPF: pass (google.com: domain of linux-kernel+bounces-72984-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Biju Das <biju.das.jz@bp.renesas.com>
To: Marc Zyngier <maz@kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
CC: Thomas Gleixner <tglx@linutronix.de>, Dmitry Baryshkov
	<dmitry.baryshkov@linaro.org>
Subject: RE: [PATCH] genirq/irqdomain: Don't call ops->select for
 DOMAIN_BUS_ANY tokens
Thread-Topic: [PATCH] genirq/irqdomain: Don't call ops->select for
 DOMAIN_BUS_ANY tokens
Thread-Index: AQHaY/KbOjxL2AVUs065o+G9f6K8uLETI0WQ
Date: Tue, 20 Feb 2024 12:10:02 +0000
Message-ID:
 <TYCPR01MB112691814D4D444C0CFB51C5186502@TYCPR01MB11269.jpnprd01.prod.outlook.com>
References: <20240220114731.1898534-1-maz@kernel.org>
In-Reply-To: <20240220114731.1898534-1-maz@kernel.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?p4WDOQ6PeMVVZLRzid7OOL9yxTV9J09ooZMpZlbP75PaYak5XXM5b4ythpYq?=
 =?us-ascii?Q?p8zheqht1HdJ96hmzL2F8xSFdsgPpH1L1UEB9N6KpPKKr7Og3o6Pu92o0VbO?=
 =?us-ascii?Q?+62EkAmU2CAowadxPtGLc/3NqeVdFhJo+d8ckjgIRCqEGkS9X+NsZ8sZSTIj?=
 =?us-ascii?Q?+Xv5CiJ6fjSDBG1ES/xg4R7JOdhdxkH6BjQzIkIDiCWlP+L0yg2aU+P+mG2u?=
 =?us-ascii?Q?1wPV7Dd9MkKUVfaBDas3DRA5ASJ3aQ96HNcW9VdGXgckJOnPHJbMJHpnuN3O?=
 =?us-ascii?Q?TS6vDhli4X0fisWSxZGPBAzi7N/hKeQNJCWg2PsWCCQ5mP86MXdcHE7dVqF2?=
 =?us-ascii?Q?XODG4UeQxMHhLxbTwmF69VKDLQzZQibWvT3hV04q8g25KWR5Nhg6Em6e4T4m?=
 =?us-ascii?Q?ouW3NDZ/NE0bJdHWNF6yXYBZuzlR1phM1T4at2z2QsapNwo4MA/DycVC4Vzg?=
 =?us-ascii?Q?QStAi/U+P04V1jJrN3/S9NrAgDXDCal/sR8MGWmLm4qpQ9zafx8CrKY7Wqhk?=
 =?us-ascii?Q?AHTWUiGXMsDhmgUiL9VpvxrMi/LtuQFirh4ZmgooGYcvnYHjUzrhWYYorY4d?=
 =?us-ascii?Q?VCKwaqEDrqJJn49/edx0jgdJrSRHDxvbRTnYgwul0OfxyG9b5FliM2mqryMk?=
 =?us-ascii?Q?3WFuWabhC/uDHmiamX5o6zNFoa84YlHdr2UbhAs/ZvdsD9cB/5D2RvFBICqw?=
 =?us-ascii?Q?Xnn/kvN8jTEfS8eNb/lAWFXyWungomDHLXyqA+AVlGeygvGp8i7eVr3Ov0su?=
 =?us-ascii?Q?ETEXITOibhxYGzs5xhlox6hHeaON9sUowZfHkz1yYsoMm2ZVWaCR9drOdRFA?=
 =?us-ascii?Q?lhrgr0uqpk1K4etxuAvMRbatJk0KMHzyAy4/h5Xn73I2mgfSHxDjzS+sZ2ye?=
 =?us-ascii?Q?pWleGYa3U8m6Snh6hoaKwkNseyFbVTGLVrKmBufA3bRjI/8xo3u6H4vFJZb7?=
 =?us-ascii?Q?obZaOP7Lsn3eC/g5sT2KfOeKa9Hfv+1876IziqD7Nybb3IZbGWBL9fGxpFZH?=
 =?us-ascii?Q?Exrbn1l1sgI/FEPs69lt7dIFr3dTK14GQqWGPFXrFmAba7l+7Hvk6n176FaN?=
 =?us-ascii?Q?mtNY+luWVyVZqZHcD5rppgH72VeMDYWH3YJ02EB/zSBnmlrFpWnCAW+G6jnd?=
 =?us-ascii?Q?VfEyiWv3HkfuFwNrHQNba0MlmN3LdNF8ThhNsamNrtkdVlkHCz/mqDhQz6me?=
 =?us-ascii?Q?is1LsWP9pf0x5oz4JupBH8RqZKgqIuP2SDgaxnRgqlaTp4Ol0vFGJJeruJ/b?=
 =?us-ascii?Q?iBPnVGZIfFfuJweJA0CytKZbCtsZU5Kvr2n/fJUe/5Aw+l4+DNQQ1BgKuwJf?=
 =?us-ascii?Q?eOxN6l2RADu+uWzn3ytKqi8U03T0iU8VVJ/fI/FlVRrmA6vcHcRpGsAZFl0p?=
 =?us-ascii?Q?H9KJsxGawT99QhTPG7Q7CMdtrmfbfLpU7e7SMvGafxCOB1lBnHQ7GbUrc0Ai?=
 =?us-ascii?Q?u3rpVFzIHrN3Ynqx6Ozr0mT8AKskIGR0Tazke7pw60OTNwP9GydDXX8PGt9Y?=
 =?us-ascii?Q?ExMgqMtCaEmt/fcU0Fcce0HZpMcSxLUI3SaxNFCoGeDjnrbgpDXcORGnw5oC?=
 =?us-ascii?Q?aqvla81SfOUdlIZpQlOx7ElfP275Wd/ym7KBJbto7LeABxkX4k0SClPoyk/1?=
 =?us-ascii?Q?QA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB11269.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a5a094c1-b765-44b6-de91-08dc320cddb3
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2024 12:10:02.0195
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JtRkMEzMplqpoCUEPCiZsSIqwP9Jw7i0He7CwLvHFm+vyXvS/aWSwfYMQaqNAmggy5PChulmAV7C1z44AehMMc0VDWGFTwk/UBVKMktmO8Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSYPR01MB5367

Hi Marc Zyngier,

> -----Original Message-----
> From: Marc Zyngier <maz@kernel.org>
> Sent: Tuesday, February 20, 2024 11:48 AM
> Subject: [PATCH] genirq/irqdomain: Don't call ops->select for
> DOMAIN_BUS_ANY tokens
>=20
> Users of the IRQCHIP_PLATFORM_DRIVER_{BEGIN,END} helpers rely on a fwspec
> containing only the fwnode (and crucially a number of parameters set to 0=
)
> together with a DOMAIN_BUS_ANY token to check whether a parent irqchip ha=
s
> probed and registered a domain.
>=20
> Since de1ff306dcf4 ("genirq/irqdomain: Remove the param count restriction
> from select()"), we call ops->select unconditionally, meaning that
> irqchips implementing select now need to handle ANY as a match.
>=20
> Instead of adding more esoteric checks to the individual drivers, add tha=
t
> condition to irq_find_matching_fwspec(), and let it handle the corner
> case, as per the comment in the function.
>=20
> This restores the functionnality of the above helpers.
>=20
> Reported-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Tested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Reported-by: Biju Das <biju.das.jz@bp.renesas.com>

Tested-by: Biju Das <biju.das.jz@bp.renesas.com>

Cheers,
Biju

> Fixes: de1ff306dcf4 ("genirq/irqdomain: Remove the param count restrictio=
n
> from select()")
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> Link:
> ---
>  kernel/irq/irqdomain.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c index
> aeb41655d6de..3dd1c871e091 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -449,7 +449,7 @@ struct irq_domain *irq_find_matching_fwspec(struct
> irq_fwspec *fwspec,
>  	 */
>  	mutex_lock(&irq_domain_mutex);
>  	list_for_each_entry(h, &irq_domain_list, link) {
> -		if (h->ops->select)
> +		if (h->ops->select && bus_token !=3D DOMAIN_BUS_ANY)
>  			rc =3D h->ops->select(h, fwspec, bus_token);
>  		else if (h->ops->match)
>  			rc =3D h->ops->match(h, to_of_node(fwnode), bus_token);
> --
> 2.39.2