Received-SPF: pass (google.com: domain of linux-kernel+bounces-73021-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <741c19b8-55f5-4f3f-8391-10fc2758e687@solid-run.com>
Date: Tue, 20 Feb 2024 13:31:14 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7] dt-bindings: mtd: spi-nor: add optional interrupts
 property
Content-Language: en-US
To: Pratyush Yadav <pratyush@kernel.org>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
 Michael Walle <mwalle@kernel.org>, Miquel Raynal
 <miquel.raynal@bootlin.com>, Richard Weinberger <richard@nod.at>,
 Vignesh Raghavendra <vigneshr@ti.com>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, linux-mtd@lists.infradead.org,
 Yazan Shhady <yazan.shhady@solid-run.com>, Rob Herring <robh@kernel.org>,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240219-mtd-flash-interrupt-binding-v7-1-206e30a656fa@solid-run.com>
 <mafs08r3f8h16.fsf@kernel.org>
From: Josua Mayer <josua@solid-run.com>
In-Reply-To: <mafs08r3f8h16.fsf@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?S3h6cXVSanhycjZjUVpaeXlYT2RFSFFkOWZNandmdnJxelo5cmpWUmVBVWV5?=
 =?utf-8?B?VmVNVjBIVEF2M3A0QVNQcXhmdnFCbEhaR0U4M0tCSk15VGFKNkpHWng5dEcr?=
 =?utf-8?B?MUxwNGNLajEzYnZlNVZTSW5CWmhEQ1JkaTliNTgyTi8wWFJNQ2MyR2xsajl3?=
 =?utf-8?B?K0xYeVozTU9sSXRiZHlVV1NUZEtMdXFjUG16WHlleG1jclNVV1ZBWDVjTS9X?=
 =?utf-8?B?K3lUN2docWtqZHRzeFBVcU5Ka1ZhSVJCM0hkeG0rZ2wxdWJEczRoUzFnWDZi?=
 =?utf-8?B?cS9KUlNZTlMyWHltWU1KYmZNdVpFUjYvb1FqZjV5ZVVZaWJwVFJsaXRTUmRY?=
 =?utf-8?B?YjRnUmhFRGhkdVN0ZTdHak05VE9vaHdIRWp2bzlTWUNoYVRIOEY5ZTJPSjdX?=
 =?utf-8?B?SzFNOFpHM2ttMStwZjlpZ2NTaUZOMWtTdWxNc213Z1FMcFJTbDBkY2hVbjUx?=
 =?utf-8?B?NlRnTGVYalJ0YUdzTTV3ajhSWHU4WDVUNWJnSTJjckplencyNkt2Ukdab05R?=
 =?utf-8?B?SEhLaVVDb1pPbTZjSkVCS3dLeXJrTmg5Ynk5M0VjWUZKeFJIN1FPZ1Z6SGxv?=
 =?utf-8?B?Qzl0aU00Y1ZHckJWTTlRZ1g3dUlXTm5TYy9xMzUyRVJRaUlhWEoxSllXakNu?=
 =?utf-8?B?d0RHY1FHV210b1JBMStFYjVSaVdsQUhGQ05rR1psakY4ZGhYMEJZMkRDQ3or?=
 =?utf-8?B?ZWVubCs5eWp6QVlTVjB6UURqOCtQenNJY2dHcDNsTTlDcnM5ZGtmNFBRQkto?=
 =?utf-8?B?NG1wa0FMTnpLRkRGN0oyZGhUOVcyNi9SYzRWcDNNcjczWlVTY08vMytLazBz?=
 =?utf-8?B?OVlXd3pENXAyY1Jmbk1rcFJ2OWRmbWM3ZjhOYlRkcDc1TisycHZBdlc1Q2VH?=
 =?utf-8?B?MU5rcEJqb0pXM1hYTjNWcTdqMStJSHFGTHBldnJ3RVNwNUY4RUJCM1hBRXUw?=
 =?utf-8?B?bVR5YWo2UW93NkdIMU1VNmgvaE9nMmxZYmlhdy9xSDlNUmhXeWthdnhrbWpt?=
 =?utf-8?B?WHUxdmFrczRSQWZzWEVKN0NpdUdtaG51bjBMeStoZTBUZHJ2dDZqc3V5Zkhv?=
 =?utf-8?B?ZExqODM1QWFqNkRFdTBJcCtHeWo2c2QwZlkvdmd3ZGFsbzRrT0VUTnFhaFJv?=
 =?utf-8?B?S0Y2cDUzaU0zZUQrb1diQVVrVFJvTGJtL2ZTT3RTMWd5OTg2WEszZGE3ejkr?=
 =?utf-8?B?aEF1MEh5Qm5YTXdlajluZGNyblVXL3BrZklkMjVrdmNHVWVMZkNmMEZ1aVpm?=
 =?utf-8?B?UGhKM3NhQ1ZWR3Jjek9sVG5VOWtJNnFWeklvVnYxMFdsNzJuRTB3ZVdhY0pC?=
 =?utf-8?B?eFUra1lsemdqMGs3K24ybHF1blFMbnM0T0FGZjZ2YVE5ZDJFZmo5U0hXbGxy?=
 =?utf-8?B?c2s3Q2Z3MUNsbGdtY1N6N2oyU25aVi9DM1ZKRTdhOUROYlVGZHpxdFAzZUlF?=
 =?utf-8?B?N05FMWFNaHoxVzlkdktXMEVCZTJ6bmNndFRQT29PWDF1VG83T2N2Tjh0cEhn?=
 =?utf-8?B?V0FSWVVTVHZmeGhVajBReVFab3Awb1lkNnFrOEdlSzRNTGpRdTdSOUFqUXdM?=
 =?utf-8?B?RTdRRSs1RmZmZDA4Z0VMKzFxVDU0SVJMRDYycDRoL2NKVVg2Rlo1cnQ5RXR0?=
 =?utf-8?B?SGMrS0NKbW9wTnhqTFhkVTgxSUNGQm9LYnFZUk9KU3R3RlAxbGZYZ1NrZnNF?=
 =?utf-8?B?d3R0QTltWmV1aUtXZEsyMkFRdkpTT0FZODFJcFZXV3UvU05CT3JadksxZDFJ?=
 =?utf-8?B?Z3dvZS9wRDNMKzk2K2xsNlFtRnFkY2U1RnVnbXhRQUNtYUhRRkN0VDFPY1Vi?=
 =?utf-8?B?dlJZQ0hqVUZsV0tqd05meG5ralFNdGQybkFhd2FRQW5WS211UEJtSFFTR3JD?=
 =?utf-8?B?VUR0OTdJWTNVUmt4aFZpSUN1YW41US9Tcmlvby9ySXpGdmZ4U1BGaWJick4z?=
 =?utf-8?B?R0MwdzlvQjBUbmVnMktUemduSkpDK29kOXplK0N0SU81S1R5eGRRZy9rUUlm?=
 =?utf-8?B?dUgrc1g0SjhCQ2FKc0tTd1ltUFVVWFl1TlNRcFdVSWt1TEptckdONk5IdFlI?=
 =?utf-8?B?YjYyTklFU3FRRk0yWjk5dXl0Q1M0SCtrSytNLzFnNmc4WHdlM0ZVN3FCRjg5?=
 =?utf-8?Q?lkPk/1jWXLz95tJGsAwczilcI?=
X-OriginatorOrg: solid-run.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f75b406-6aed-4653-b26a-08dc320fd66f
X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB7586.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 12:31:18.4697
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: a4a8aaf3-fd27-4e27-add2-604707ce5b82
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GR9FJ9hjEYObl1ejq8ao1hQqfePQkn8NP3e7rT4EPLI8rYE4qaXvjDSfmGJ5JzDxsT5b5RVxtNrNXzyBeloGDg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8383

Am 20.02.24 um 13:19 schrieb Pratyush Yadav:
> On Mon, Feb 19 2024, Josua Mayer wrote:
>
>> Some spi flash memories have an interrupt signal which can be used for
>> signalling on-chip events such as busy status or ecc errors to the host.
>>
>> Add binding for "interrupts" property so that boards wiring this signal
>> may describe the connection.
>>
>> Signed-off-by: Josua Mayer <josua@solid-run.com>
>> Acked-by: Rob Herring <robh@kernel.org>
> Acked-by: Pratyush Yadav <pratyush@kernel.org>
>
> BTW, I don't see any support in SPI NOR for handling these interrupts.
> Do you plan to add them in a later patchset?
No current plans, I have little knowledge how spi-nor works in the kernel.
> If not, what do you get by
> describing them?
Foremost I get to submit a correct device-tree (describes hardware)
to the kernel, without maintainers getting all over me for introducing
new dtbs_check errors.

And I really do prefer submitting a complete device-tree so that all
knowledge I have gained reading private schematics is readily
available the next time someone works on it.

>
>> ---
>> Changes in v7:
>> - split out of original patchset because it should go via mtd tree
>> - collected acked-by Rob Herring from v6
>> - Link to v6: https://lore.kernel.org/r/20240212-add-am64-som-v6-0-b59edb2bc8c3@solid-run.com
>> ---
>>   Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>> index 58f0cea160ef..6e3afb42926e 100644
>> --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>> +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>> @@ -52,6 +52,9 @@ properties:
>>       minItems: 1
>>       maxItems: 2
>>   
>> +  interrupts:
>> +    maxItems: 1
>> +
>>     m25p,fast-read:
>>       type: boolean
>>       description:
>>