Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1704458rdb; Tue, 20 Feb 2024 04:47:32 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCVSGFn6zDoxa6WG9zF8d0XARzBbYt4hzYsCI97ZE1ECMIcqKdenW2ZwK2NiAhtrTruRLD/fQmboNJY/KUbmuFr3r9npaV/TB7sjuelwcQ== X-Google-Smtp-Source: AGHT+IF9t21Vnx5wi6GDNaaGdaBC+0BLKGJAbkXwkDN4Hr9VGR3VOj/RQ6eABDyUgPzTm6aaN+mC X-Received: by 2002:a17:906:6850:b0:a3e:8f9e:9d0b with SMTP id a16-20020a170906685000b00a3e8f9e9d0bmr4056108ejs.70.1708433252467; Tue, 20 Feb 2024 04:47:32 -0800 (PST) Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id f14-20020a170906560e00b00a37fbf403eesi3433944ejq.748.2024.02.20.04.47.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 04:47:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-73041-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=GnKT9Vjr; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-73041-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-73041-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 39CF61F24040 for ; Tue, 20 Feb 2024 12:47:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2E6FB69E05; Tue, 20 Feb 2024 12:47:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GnKT9Vjr" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 501768814; Tue, 20 Feb 2024 12:47:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708433239; cv=none; b=stbnSB8RTLF4Uk+PB9bgjVZ2j/9Fr62QlLjCRJgQHG8saZnjcbo71JNOOtYzTi4W6ppNFLa4qWJj/cX5JCSH6axVukqZ2c5g+382e0kKbUI4FFyC5HKLvBxcLTtzhlNSjtj0veLG8YHvXKwX5sOru2PZgEEUyUdOXTogY2Uvxm0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708433239; c=relaxed/simple; bh=ShM9njjCxawrjQ/ZQDOu2m6lUpiT5zfxfZ1QJIMyxCE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dT864As0XAE+UAcbd7oEwp8pQA9SnjQjjztsEAiTr0hlO9DACyOZoV4KFWtb7WmGXp+xPnFKGeRdVksWKgRqw9J5ac2w23GKbYUnfw06j/8wzbf13d5bLUsr9+RTvqpCQdWe/d7wRyoup+BxVKFilRbQubEG+yCMUNF3+o1Z3IM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GnKT9Vjr; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B92CC433C7; Tue, 20 Feb 2024 12:47:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708433239; bh=ShM9njjCxawrjQ/ZQDOu2m6lUpiT5zfxfZ1QJIMyxCE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GnKT9VjrUMqyDQrYKel4WSgau86TunXqwSFMQE+9PRrh3qtwrPflVSKAN4cJcGvuP R8z2NhEwro7lMHdV9rFNNsKLVevei0YNk7fMSlp3K3vjeBNon5Ea9F330tSPiOd7fV Atkk3B1mV1H8O0GKUbmqAXK3RSV3szM4t+0g8zCguFqvS2d91WJt/MsIFcJHpDI2dj CiizMsTwhyODEa368kXAQDwX+8YBauRRD6JQRI4KsblbBbf/W3r7G4ln9LAVgTlW4r no3e4MuxKdi++Ygcp+xrEMFoB9BTqVGQ5W+PZEBYcS7Nsg4MiQf7XWzjbmdAdOtWR2 H8qA3FdAL17RQ== Date: Tue, 20 Feb 2024 12:47:14 +0000 From: Simon Horman To: Andrew Lunn Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ariel Elior , Manish Chopra , Jesse Brandeburg , Tony Nguyen , linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org Subject: Re: [PATCH net-next v4 9/9] net: ethtool: eee: Remove legacy _u32 from keee Message-ID: <20240220124714.GF40273@kernel.org> References: <20240218-keee-u32-cleanup-v4-0-71f13b7c3e60@lunn.ch> <20240218-keee-u32-cleanup-v4-9-71f13b7c3e60@lunn.ch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240218-keee-u32-cleanup-v4-9-71f13b7c3e60@lunn.ch> On Sun, Feb 18, 2024 at 11:07:06AM -0600, Andrew Lunn wrote: > All MAC drivers have been converted to use the link mode members of > keee. So remove the _u32 values, and the code in the ethtool core to > convert the legacy _u32 values to link modes. > > Signed-off-by: Andrew Lunn > --- > include/linux/ethtool.h | 3 --- > net/ethtool/eee.c | 31 ++++--------------------------- > net/ethtool/ioctl.c | 29 ++++++++++------------------- > 3 files changed, 14 insertions(+), 49 deletions(-) Nice :) Reviewed-by: Simon Horman ..