Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1708199rdb; Tue, 20 Feb 2024 04:56:27 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVuRjGOAL0e9ysrg5BqtgmslFKSDY7TYpsZ3yLHn3lZ8ewxkKrhOD2FM6KeHJUFcVqN4fOCrmrwbR+F+8CFjIHaACgf0ey1SY5ntTIYEQ== X-Google-Smtp-Source: AGHT+IHtgSXcRiWHeVbsgniFJfN5GMPeeqXiy4b5qXUG1eU8pnqs+j2yL+FDVhOlTUiWJYpCISIy X-Received: by 2002:a17:90a:7e18:b0:299:e9ca:c497 with SMTP id i24-20020a17090a7e1800b00299e9cac497mr854994pjl.4.1708433787494; Tue, 20 Feb 2024 04:56:27 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708433787; cv=pass; d=google.com; s=arc-20160816; b=fi4kSJZfecppdObEfFlA50Pw0elowFE1kdEVUVD9knR0b4L/S6asUrx2X/tQK5Hj8N /RlRaSBYkT+rv7T9nEmQuLI7lIPwfw38uedX7jhG4No8Aqr8o0P7ftAlT9xD4niMk3yc zYbRKiBNxfGTHgME6GedeLp0yl1JRpKSFogl4ta9FSKZWCiFlPlEB+AA8xxouaRigzZX R/QBdB+tjB/+ugi0LxxBEc46O+yZIUyE3K8Pjeg2U9qsbf1DjAQfQDD3dUSNm49IHpcl Uxeucn+uxYTooyu1XvRBVPzILoUMwgSBaj3Y70NX0SoFA7/Ftqcdo7TKpwqcuwoQhEX8 wJTA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ENXpTX7s0VpOWqmoeICjloXStTsQwhGAKR2p6Thu77M=; fh=G11uJ+5JlSi2xx4lB6OmCcmJpN3VDaQfPHPxeDMAHMs=; b=hD4jhW4eRPAyvBxlqDrHeMvFvJhpEp/J4CHhUcIYVBncrPyXK4rkxmDRMgZthp1RiH vrg8AwogMtqed8CTAvgdgRLzBmGPyqgy1S8Fj1DoRWw0JAxtGidSYXIkUg+EWU0triHs FCTydxyhh5NVdAOWIi1+f0oIzVQjgQ0XPi5+/S79ZutKW0aYGaXwywGdV3517/AEFXy+ gM8Co0nrDLTgosDjxQTVq2rW9Y8t4LQ468+PW109p/n05jTiZcy+wwIUg972/RYT3xyj nF0kZrzAxsyBiUr1PtWta4xlh7d8CRc2pOUHNUwZbV596MxQ4pKgvRhQKpL0V03ZDCjA ALsw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="NDL51/xP"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-73045-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-73045-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id x5-20020a17090a388500b002998a309b7esi3936736pjb.13.2024.02.20.04.56.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 04:56:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-73045-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="NDL51/xP"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-73045-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-73045-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 240382820E7 for ; Tue, 20 Feb 2024 12:56:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7E8DB69E1B; Tue, 20 Feb 2024 12:56:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NDL51/xP" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A15505CDED; Tue, 20 Feb 2024 12:56:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708433773; cv=none; b=j3cXAN6v2OCtfGk21bnKE3xXsuC1+418DcASR6W4d2kqyIxnbWboKVdI/w2JpY+yWEBAYKWQhgbOLqCDIF7kCCaAKOIcbHs5MjFaLBcAbn7zkrUUjRJZzRu+gLwO+//TmiI6W0dSw/dm73uBEQfi6EBEFy1QeGmjT6xxOQPjAYs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708433773; c=relaxed/simple; bh=Q5BWa8LkWf902AxVTsQ/Vk7boyDKv6MiQY5w+ZXdYKc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FI2hloyk6ZxqFhChm2qJA0pRgaghn0ZuVXgG60lyFzs+t6+OkwUi2F5k28oYqwNqKyDZDeJnWhRh93kfgywbqhFr6oXL0t14HdK22I68fcVUuZC4/V7UPyFiiUKiB5XoZhrMQdfKIXJKED81oj45KAS+mPbtNGE0bZmpVMLJgvk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NDL51/xP; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90FE2C433C7; Tue, 20 Feb 2024 12:56:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708433773; bh=Q5BWa8LkWf902AxVTsQ/Vk7boyDKv6MiQY5w+ZXdYKc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NDL51/xP6pc6UuWIIrE/ULokhaA0Vsu3/GWwd+ew91wGsc1nIk9kL/zCarULtlWWk n8oXykLkk1lkVXPdj28ctAzMV3NjQq12HaTujBx4w5zB+Nl4HBaCCz65guDc+uGA6n BNp3HCFt8zpK5YVEoZV05JTsAK/3s1Nkn0bsertTXPh0yzb5mx80ghJdLuKmrP/ThN NFsQi7M1r663rsSy7vyAcU9/4hamPARjn0qnQQOa/KUVf7/nFACL8E5oaJ+76oAPQ7 zFUqw71sreswoZq5sS/mbllizqCcdsXgJFzjVbFryODclY7YAY7+8vFZ7hYxh3W1en cuQlAhiLsdg1g== Date: Tue, 20 Feb 2024 12:56:08 +0000 From: Simon Horman To: Andrew Lunn Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ariel Elior , Manish Chopra , Jesse Brandeburg , Tony Nguyen , linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org Subject: Re: [PATCH net-next v4 1/9] net: usb: r8152: Use linkmode helpers for EEE Message-ID: <20240220125608.GG40273@kernel.org> References: <20240218-keee-u32-cleanup-v4-0-71f13b7c3e60@lunn.ch> <20240218-keee-u32-cleanup-v4-1-71f13b7c3e60@lunn.ch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240218-keee-u32-cleanup-v4-1-71f13b7c3e60@lunn.ch> On Sun, Feb 18, 2024 at 11:06:58AM -0600, Andrew Lunn wrote: > Make use of the existing linkmode helpers for converting PHY EEE > register values into links modes, now that ethtool_keee uses link > modes, rather than u32 values. > > Rework determining if EEE is active to make is similar as to how > phylib decides, and make use of a phylib helper to validate if EEE is > valid in for the current link mode. This then requires that PHYLIB is > selected. > > Signed-off-by: Andrew Lunn Reviewed-by: Simon Horman