Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1722319rdb; Tue, 20 Feb 2024 05:19:08 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXd+dTf3Wr09KFIccrjHrO/2kvHgy1pvS2ufd240Tp0fy8oh+TX4cm8wxMBWaIwLjqZT9GRKD/jzdzLWnmRcZBqVCZfSIhI4BAymMsWKQ== X-Google-Smtp-Source: AGHT+IGVPi7XBnR5fpeiPghEphuSpJDwxn4KWMf350AaCUd1q+lRB1LFLRTYAqP+ncfSXLc+Ndxm X-Received: by 2002:a05:620a:3183:b0:787:4bcf:7989 with SMTP id bi3-20020a05620a318300b007874bcf7989mr12003298qkb.5.1708435147985; Tue, 20 Feb 2024 05:19:07 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708435147; cv=pass; d=google.com; s=arc-20160816; b=IzjOeBd1hE75202/XFqXCQ8GkutXM/pKFkgF3vShNkeSlMAJSI1RGOpefvE2SmFbUd N/V56+0RGOoWxwYJg3sNuOemCwnC1LpKMwrapHttkqTL1CFiUV2Nbow7OMtDRY2JspPL 6Fr/NhPaKxMXM0ZCzofm6BHS2PfP25oYjXd9qfqkOP/Y3nHwVNonQHxoB6qyldMbE/mn pqTg1PXdddcdo4yI3KWziG1Eficc8YmZJQ4vJmUam6DhTNyWUS9+OPnoBnN9fS6IZIXa 8heTNwzssj8ZhxfNC5w1TeJlSNH1tkN1LyZLxF1rF0i3DyJ9SAubHCuITg9/5WY0mJtj a28Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=l0Ralh8boQXJNEyGO2s4oxTUhqy3aU6kobWt10CxPHI=; fh=Tu01z7ult7ve+Wmkxw43a0rZa+QJVn4g3VEr5KNpX64=; b=nASLKpAsFrQjLmMxwf0C9TxjEh7PM8JUpvZ96vm0WlHxEHqDJiNCfpRQt7X2MvhM8p rbXMShI+M/4gIxD8pXVYnvZQNjdKYXdTYnp+2L2Zs7crKBH8/BtOROM01hXFs2wXsr24 9MR8ARtDmntAdzjAG6c9A/tNbNbCpkLX7t7/p6xJMswnBI2Ge81Ek9KwLslJWCuH6Vgh 04FkPpbh1m+kfSvBXRcjgb/taD2KyDS8PN09uKQ045DzuwNjD9q84O2+Q12/7fi9AOzs tZ0x6hLyi1/IklLvFnx9QuegPk1mQAnR/frUsoMVH7WRoDiNPFT2T6a54HkYi118NxRx R5uA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="V/ezfS8Q"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-73065-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-73065-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id pe4-20020a05620a850400b007872d4ac1f1si8496916qkn.618.2024.02.20.05.19.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 05:19:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-73065-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="V/ezfS8Q"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-73065-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-73065-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id AA8A21C21DC1 for ; Tue, 20 Feb 2024 13:19:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1109C6A346; Tue, 20 Feb 2024 13:18:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="V/ezfS8Q" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 397C469DE4; Tue, 20 Feb 2024 13:18:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708435128; cv=none; b=HA0DYSLoj2NgJrSl6vGbzYgqvO4tEUkPLj0jTOdAmzzR845kOWv0lQ51xKrMLm1EDRjJA+rj3BIqlpREaSbdyO7nOmNMCwb2fSk1LuD8dvYQBAHwNTxQNn0vBxUZOr7fvzbLLfkJzVktFwnzuKLJE0ShTBSsZys+WB/3Ki16Aoo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708435128; c=relaxed/simple; bh=RZZk0PE0TiY7k+x5DBdvarX9mRIKYJiIQkRfbPjIlbw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AwUPqdcpcThz72IB7QEzb+HiXlsI6Dh5gCC+jwL6OMNQakYQgCirfBTVoi1WC10bR+vQguzeYtLYkenmmCaiJhT8WB3m+lE8D3uTJC80qjphegp+Zh2xqbCcUUSdQYtw9DPxnYB4suz/Ih6TtoNlg3eKFxQQDuhvwdt3znKWvkE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=V/ezfS8Q; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24F78C433F1; Tue, 20 Feb 2024 13:18:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708435127; bh=RZZk0PE0TiY7k+x5DBdvarX9mRIKYJiIQkRfbPjIlbw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V/ezfS8QpHqQymbTzuh8+/2ORCPdvgXTC8pBg0PQL7ijM5+4ScTS3/lVUXCZhAitq JIs3Hz5pToRl9TbqMy8zv0uG/dzFhxwwBKEP5zGBge6D3rVrXGokcR/7hAfZYY3Hq0 HbwkJ/alhGyXsvNNwtvYl6yoM+0yVX6rgcKh8K08utKyEBspi/ibqgib2HwtjDYhmy mAW1ZMWEgIefdfGc/ZuBPhWqtIkAwnkvqhGpOG6vbIWJCxFOPoz6B4T6clvOQoKDn8 k2Xeq4WixppjT91HaUTwfKkZNJMimrc5gvZ0IHrn6zsKeYfNIJID1qIScVdx2h2FOO 7e2h4bmLGr4PQ== Date: Tue, 20 Feb 2024 13:18:44 +0000 From: Simon Horman To: Breno Leitao Cc: kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com, edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net/dummy: Move stats allocation to core Message-ID: <20240220131844.GJ40273@kernel.org> References: <20240219134328.1066787-1-leitao@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240219134328.1066787-1-leitao@debian.org> On Mon, Feb 19, 2024 at 05:43:28AM -0800, Breno Leitao wrote: > With commit 34d21de99cea9 ("net: Move {l,t,d}stats allocation to core and > convert veth & vrf"), stats allocation could be done on net core instead > of this driver. > > With this new approach, the driver doesn't have to bother with error > handling (allocation failure checking, making sure free happens in the > right spot, etc). This is core responsibility now. > > Move dummy driver to leverage the core allocation. > > Suggested-by: Jakub Kicinski > Signed-off-by: Breno Leitao Reviewed-by: Simon Horman