Received-SPF: pass (google.com: domain of linux-kernel+bounces-73100-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 20 Feb 2024 14:38:24 +0100
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-mips@vger.kernel.org, linux-kbuild@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] MIPS: move unselectable entries out of the "CPU
 type" choice
Message-ID: <ZdSrUKlV+Q37S3B7@alpha.franken.de>
References: <20240127162309.1026549-1-masahiroy@kernel.org>
 <20240127162309.1026549-2-masahiroy@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240127162309.1026549-2-masahiroy@kernel.org>

On Sun, Jan 28, 2024 at 01:23:09AM +0900, Masahiro Yamada wrote:
> Move the following entries out of the "CPU type" choice:
> 
>  - LOONGSON3_ENHANCEMENT
>  - CPU_LOONGSON3_WORKAROUNDS
>  - CPU_LOONGSON3_CPUCFG_EMULATION
> 
> These entries cannot be selected from the choice because they depend on
> CPU_LOONGSON64, which is also located in the same choice.
> 
> In fact, Kconfig does not consider them as choice values because they
> become children of CPU_LOOONGSON64 due to the automatic submenu creation
> in menu_finalize().
> 
> However, it is hard to understand this behavior unless you are familiar
> with the Kconfig internals.
> 
> "choice" should contain only selectable entries.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
> 
>  arch/mips/Kconfig | 76 +++++++++++++++++++++++------------------------
>  1 file changed, 38 insertions(+), 38 deletions(-)

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]