Received-SPF: pass (google.com: domain of linux-kernel+bounces-73124-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <e69f523e-8d58-4a4f-af28-7238e818eac1@ti.com>
Date: Tue, 20 Feb 2024 07:55:35 -0600
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] power: reset: xgene-reboot: Fix a NULL vs IS_ERR() test
To: Dan Carpenter <dan.carpenter@linaro.org>
CC: Sebastian Reichel <sre@kernel.org>, <linux-pm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
References: <fe1b90d0-7234-4e03-accc-69a119f6a7eb@moroto.mountain>
Content-Language: en-US
From: Andrew Davis <afd@ti.com>
In-Reply-To: <fe1b90d0-7234-4e03-accc-69a119f6a7eb@moroto.mountain>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

On 2/20/24 3:02 AM, Dan Carpenter wrote:
> The devm_platform_ioremap_resource() function returns error points.  It
> never returns NULL.  Update the check accordingly.
> 
> Fixes: 7ddfd33c6ee5 ("power: reset: xgene-reboot: Use devm_platform_ioremap_resource() helper")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---

Acked-by: Andrew Davis <afd@ti.com>

>   drivers/power/reset/xgene-reboot.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/power/reset/xgene-reboot.c b/drivers/power/reset/xgene-reboot.c
> index 867162dfe7ea..b5eee19bac42 100644
> --- a/drivers/power/reset/xgene-reboot.c
> +++ b/drivers/power/reset/xgene-reboot.c
> @@ -51,9 +51,9 @@ static int xgene_reboot_probe(struct platform_device *pdev)
>   		return -ENOMEM;
>   
>   	ctx->csr = devm_platform_ioremap_resource(pdev, 0);
> -	if (!ctx->csr) {
> +	if (IS_ERR(ctx->csr)) {
>   		dev_err(dev, "can not map resource\n");
> -		return -ENODEV;
> +		return PTR_ERR(ctx->csr);
>   	}
>   
>   	if (of_property_read_u32(dev->of_node, "mask", &ctx->mask))