Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1748371rdb; Tue, 20 Feb 2024 06:03:42 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWnMfF+Hmn9cY/2PAtaeTbWFhpMSb8KQWKYJvNIreffsEBwuKkzVgJsOXQE0XyDHJCtID6e1Ib8jfvAI9gVPrHzP9VauhqHPc7j6GPMew== X-Google-Smtp-Source: AGHT+IE4A4K71uK+2jyXo9G9H0ampFTHK/dIQXmoMpBD/cXvlz2pH9T/LfyR4aoY5cfg5iTldvQX X-Received: by 2002:a17:90a:bf82:b0:299:ecba:cc6a with SMTP id d2-20020a17090abf8200b00299ecbacc6amr964858pjs.40.1708437821977; Tue, 20 Feb 2024 06:03:41 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708437821; cv=pass; d=google.com; s=arc-20160816; b=QIwQf8D3NY+qQpUpdAkRbso/3pwp3HKLStcKrSwVw0Zqfa8dODVo8mQuVP1cTAPpK9 ymfQbid7eljb6BSBgonWRMQIuGDZi4sF6y3EkH6eloaQ0i6xfITlsp16MdciEaA6/ZHc XrepRiOUAgXhMf9ZWuGMq7gfiqfPx58K8kMEWv3Bp1MFP2Y89dKrXy6Y9MeSUhaApLpa KZ0NaVO3JqYwGNCKq0GHmLmExvuVse5dnZcH6gHUGXO0mxOJEwWFNmWNJMAlTo5Sezh3 fEASrxxD0iBp2Nkab5fg+StQtm44yNWUKkQrvE3ZlPTe+3qhJosyv61o8pXr82hX4TCs popg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=YIgXLQrn14CWmrZfowaGPAblUiVDzjmJHLps35gqblg=; fh=SDaamPxbqDejKQtSVaaacJ54Ow4Vx0pGALnAuJIb7jU=; b=qJrhkB5p4vIwMsvGwDJNr/AoxpoRtnhG/xpA5Q+lz/TW8xGX3EsSfKRH20DU4nuKfy +2tFUYNJbNJhzfT3o/kNbS8Ikjp+TjjSCNh9NRPsYi6Whog7g/TcfYasDsJR4k4CaswN Y20suJG6VA0ybhfmg1KU1t9Ye2pBCq19gh4L+udo38DyTncXmD/HkyW1y9RnrHfM7lJk mnkVrbxkEUcEY9SYaPGfgp6JxqU9U+dl9Ab75zSi+MqOR3w1fG1Ffw9j1WXjPrQg/PC9 sK0E4KW76RRwLeysl8seCPE669USa/ohD0B+Nm7Oco4rQW/HRtP8F/Lc7XbGeHglb3YI SYsg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cUjaVRij; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-73133-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-73133-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id 4-20020a17090a098400b00298e649da8csi6364108pjo.135.2024.02.20.06.03.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 06:03:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-73133-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cUjaVRij; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-73133-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-73133-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 9A9CF286A98 for ; Tue, 20 Feb 2024 14:03:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5FFB36A35E; Tue, 20 Feb 2024 14:03:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cUjaVRij" Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1028D69D0D for ; Tue, 20 Feb 2024 14:03:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708437814; cv=none; b=ufcT4PaOYuXjbuF4yYnEgcOWdSYzb9kFhcSHDTkUS7avY0KJ/aRr+/vs5SQ9tACVXQDFZ42Q7wuY/Kutv2jwRpXSCkMxLyM52x1QlzeY2KJXOmU0DV5GX5ijLRQp6Ju6Hm07cnr2Gltv172H99fejAKgM4VuCtp2ZAmGXOfOlz0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708437814; c=relaxed/simple; bh=YIgXLQrn14CWmrZfowaGPAblUiVDzjmJHLps35gqblg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KSuQpuIHs8F7NYuWpgBeVXvcVO3JEMZxzzcIxprO8u64wqpcK7Ja09R7vpVX/4F0ZbHy/AptvrZdQwUMDuKH4uJdmdgulCy02YnzksOoF2/4TRBuHynImDe1U+RgG61CokBBCAXEKYUZgR+dPtkgG3ot90S07fkcg5dRD9zjY+M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=cUjaVRij; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-41271096976so2443865e9.2 for ; Tue, 20 Feb 2024 06:03:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708437811; x=1709042611; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YIgXLQrn14CWmrZfowaGPAblUiVDzjmJHLps35gqblg=; b=cUjaVRijlpkAuZyhcMvypRAMfKh2/AQw6/z8dfGU7S2aO72BL7k0f6E5CaYlHdrC7i B5CeBHk+oa3ThzoraBFbcmkWTASt2jDG/xQfkEbsNY7/2PpSgo8FDQUwpz1UGr3BLCGi JhClBUX8agY7V1P7/BOgo1JPNBoYWeyRDHbrTYAX8LDPQAX6usUAQ5m8/iFMprUTpf3E wOhSCzJJwSskJXqK2N7ncSWGbe5gZxpCg/L/e4mkOTgnzmmF+K3NHJ/3ouXJ/XTr/KWF r1HTvLz8oUsTsUAUxMiVbfiXxMmV6grWDrCRk6pHLPodfxLEtzHXifwBPX8429XnZ+Gj NbaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708437811; x=1709042611; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YIgXLQrn14CWmrZfowaGPAblUiVDzjmJHLps35gqblg=; b=YVnRR6Z/syDB2o9aYQVtATUTj4GbuzwVDnpoQyOo/NpUB6X7OJ1JT+G3n3CtzUVaHe 3BAD/gYWAmn+mXoQHgXGX9Jg0mYisN2Vfi8rq5qVlpktfrZZd0AIZEboS+gPRicQFZkp aM8Ro3Mi85xtK91Mtekj6mTk5ULkJz5Z0rD1jRKVHgnxLefwjv7jXlGwzlHi6Bom7V5o UvWPP7HM2DZDEtArdXDXZC2lk3LKMp7NgMe6vtpbSZBcObc428DH0DrkenxEnF7DLBRC pP9n4r++e3qfXUzWICsSfYdJqDgcH/K1Qv/Igh0ji4Fdqga4qUsQ7pd/9BKFzjGmwOb/ 3wzA== X-Forwarded-Encrypted: i=1; AJvYcCUqyaMpEhpIv8HrVnahTGOlUsQ764U6wlSGqmSCTVBaBN+AbUX+x/E384wMxZA9HYehxlz4HA9+yL7KTimPHd1B/eHYv87AzNgORFNM X-Gm-Message-State: AOJu0Yza3ryy8OWtk0f8cffCp8+ehx899zwUT6yCN8ozSomb4If7SKxc NdjXC/ktMbvUl8CISF6MFcABlrjnYL3nocQie9cimBENrk6eDwJG0+/pWm8dIC4= X-Received: by 2002:a05:600c:1553:b0:40e:d30b:6129 with SMTP id f19-20020a05600c155300b0040ed30b6129mr11941148wmg.13.1708437811534; Tue, 20 Feb 2024 06:03:31 -0800 (PST) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id bj29-20020a0560001e1d00b0033d5c454f03sm4888305wrb.114.2024.02.20.06.03.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 06:03:31 -0800 (PST) Date: Tue, 20 Feb 2024 14:03:29 +0000 From: Daniel Thompson To: Luca Weiss Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Lee Jones , Jingoo Han , Helge Deller , Andrew Morton , "G.Shark Jeong" , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maximilian Weigand , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 2/4] backlight: lm3630a: Don't set bl->props.brightness in get_brightness Message-ID: <20240220140329.GE6716@aspen.lan> References: <20240220-lm3630a-fixups-v1-0-9ca62f7e4a33@z3ntu.xyz> <20240220-lm3630a-fixups-v1-2-9ca62f7e4a33@z3ntu.xyz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240220-lm3630a-fixups-v1-2-9ca62f7e4a33@z3ntu.xyz> On Tue, Feb 20, 2024 at 12:11:20AM +0100, Luca Weiss wrote: > There's no need to set bl->props.brightness, the get_brightness function > is just supposed to return the current brightness and not touch the > struct. > > With that done we can also remove the 'goto out' and just return the > value. > > Fixes: 0c2a665a648e ("backlight: add Backlight driver for lm3630 chip") > Signed-off-by: Luca Weiss Reviewed-by: Daniel Thompson Daniel.