Received-SPF: pass (google.com: domain of linux-kernel+bounces-73153-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 20 Feb 2024 15:08:55 +0100
From: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
To: Ilpo =?utf-8?B?SsOkcnZpbmVu?= <ilpo.jarvinen@linux.intel.com>
CC: Fenghua Yu <fenghua.yu@intel.com>, Reinette Chatre
	<reinette.chatre@intel.com>, Shuah Khan <shuah@kernel.org>, LKML
	<linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH 3/3] selftests/resctrl: Move cleanups out of individual
 tests
Message-ID: <i7ixj5wy72mgcczmqc3j2in7uazplg6aqoei32iu444egxmbjh@a7xd6iv5a7zu>
References: <cover.1708434017.git.maciej.wieczor-retman@intel.com>
 <63b9763211c2954f0ef517a817b3bf0c482df8cd.1708434017.git.maciej.wieczor-retman@intel.com>
 <f08dafda-c8a5-324a-464c-5b84d779c4ad@linux.intel.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <f08dafda-c8a5-324a-464c-5b84d779c4ad@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?UY5CiQaw/BsYxXZaLEkxI9LnBbJRL3qqZ0cPfPLl9fXba/OOLpPHfunZ3m?=
 =?iso-8859-1?Q?kHLH0ap7DqTYm3P81UUGYWz2xHqIXTsCUTXp9QLvQ+huYLRig8i6a0V4ko?=
 =?iso-8859-1?Q?vBgrKrRDGxsmF7Y9sjYdZuMKGfaE9XBUmGaaspaK97w28PT15+r7mmGqmN?=
 =?iso-8859-1?Q?/lxmURy2XgoUtpXxRElb+Dsp5kYSV8BoNqd+ArT27V/LfqCjqIcFJBG9ei?=
 =?iso-8859-1?Q?n2UTAmP8swU7z/un2OWd+dP/6CZoI+mI4+4wMFR0UC0Jai57IgCUM43XUb?=
 =?iso-8859-1?Q?4jspu6X08WwJSoRUBKmhvl3Dc0643gcO+cdGP7xeyKIlfhKai6dkrIchlv?=
 =?iso-8859-1?Q?//1AE6YHW8grYgTW3/wk4IzCX3Gy0LA8FuksBVtEL+qVbPGW1ll2uA5Klm?=
 =?iso-8859-1?Q?gCDcD7kDP2y67bj1ajFBEgR/ETBRIMY1WbFZLmxM2k0WhZlfO/YH7E3tAO?=
 =?iso-8859-1?Q?byVT4I5iIrd4ozCiSng0bkFfYMvYCvdwf+eQcSZHITak/UDhpDzpWddqHK?=
 =?iso-8859-1?Q?+Hepoyco0PZ2V+LirqWUWOUu0k+ULgTHTofNPYFDFLtJ78ahuPJvkX97ni?=
 =?iso-8859-1?Q?2gm5vel9UszCNyB/ASLlumshP7SS3PjRQxVnbD/sHbhw6Bt1IK4DJEaaxz?=
 =?iso-8859-1?Q?Sus2bGbtX8jCG62qwAKlCCP+BMMQy2ZuBGy16Q5JaRqXApD7ZMWYjfCuAb?=
 =?iso-8859-1?Q?ngPkBpll467LfXO5VjiwkKZRGmpfPzZh++CqMHiBNpWlQXKw9CNJBVNPri?=
 =?iso-8859-1?Q?LW5ryWpnRFDSbOqy7f001EdtSurtR/fofHXeJwhVKKTJ6+6mBtteDhATGt?=
 =?iso-8859-1?Q?CBrAy7bQvscHuQOZuU4y+V6IBm2MHxz0d6llV0WQUuTWoX5LnzzAftMFg7?=
 =?iso-8859-1?Q?VYWm4NlFxosKuSPFCKPET4YM2YoJ7SlYeBYjfnG9uvBArpMeYo47EfwVoE?=
 =?iso-8859-1?Q?r0FpLspEzPc6Q8D3euwOsggcbN7K7VNH8XKbhcwdxgiy/uHMjH8esjRx3u?=
 =?iso-8859-1?Q?kBbRR4sP0H+SIAdRfWrv+YKRVv2Z47z921i4eo9SqSy29dJwBHKM0qQLxg?=
 =?iso-8859-1?Q?RxCjfkwd9vMOJbBywqk7depdSCqNEmG2teASan7XSD3VLpHC/a7c9z0pjt?=
 =?iso-8859-1?Q?tMCyBZDk9y5Jqq+2iDhcAdpVNyVICSZEY9z7B5rKLn9n44NuFvKZj8ptHz?=
 =?iso-8859-1?Q?mrIo7cfp+ULYzOVe87SqYcYXid0dKxnY1y2bqBoZztnKWFkoSQqgMqrxmn?=
 =?iso-8859-1?Q?h5jULueZoE0j9yyvx09bjQwkhR2+ViUoLKz5YfIFPDS8BEbUZZNiTeQaAb?=
 =?iso-8859-1?Q?ZJqoHsr8Q14JRwPjyq+GnJCKSncREJ2GY8kosXVK5yyILS0sFWWvjQ4sw+?=
 =?iso-8859-1?Q?1LJ302VbMDHL5F8ZWcBq4lAOrPsPfC6Qb6yAG5C67fkgvOmLiN+X3+egmZ?=
 =?iso-8859-1?Q?CryErvQYoYzxAlIiusDGoTzSYFMGa9sDstuuczJZYdIW+ovf5IKN0muScK?=
 =?iso-8859-1?Q?KfYilbiCkdIDCgCsFu/15vMplawYasr0M95xEbvQ82vyaBEZDqZEebStsS?=
 =?iso-8859-1?Q?qyLoL7WiCV/Z6rQIr3jd8+nEshSKCcwkr+tGXjdfour04Ax10ZxiY/Gfpu?=
 =?iso-8859-1?Q?jFb4ZNjDHG6pdh+nANfBb103yWoFyGzoEXI3FDR0ICdvRzTiVazs9l4k3K?=
 =?iso-8859-1?Q?uagGjFs/mDBB4GVhKAA=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 60b6fcb4-1bcc-4fb0-ece3-08dc321d7cdb
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6231.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 14:09:01.2459
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Fh71TV48cOI6XMXrgfJoz+gp2tCCVBLJGIblCdH6gfmC0L1KjMTrNCj8rxBytJZ45bRvIVBIDiYknUJJpvHMRHAB3h/rnKDRHlYOa9MNqL0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6800
X-OriginatorOrg: intel.com

On 2024-02-20 at 15:49:16 +0200, Ilpo J?rvinen wrote:
>On Tue, 20 Feb 2024, Maciej Wieczor-Retman wrote:
>
>> Every test calls its cleanup function at the end of it's test function.
>> After the cleanup function pointer is added to the test framework this
>> can be simplified to executing the callback function at the end of the
>> generic test running function.
>> 
>> Make test cleanup functions static and call them from the end of
>> run_single_test() from the resctrl_test's cleanup function pointer.
>> 
>> Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
>> ---
>>  tools/testing/selftests/resctrl/cat_test.c      | 4 +---
>>  tools/testing/selftests/resctrl/cmt_test.c      | 3 +--
>>  tools/testing/selftests/resctrl/mba_test.c      | 4 +---
>>  tools/testing/selftests/resctrl/mbm_test.c      | 4 +---
>>  tools/testing/selftests/resctrl/resctrl.h       | 4 ----
>>  tools/testing/selftests/resctrl/resctrl_tests.c | 2 ++
>>  6 files changed, 6 insertions(+), 15 deletions(-)
>> 
>> diff --git a/tools/testing/selftests/resctrl/cat_test.c b/tools/testing/selftests/resctrl/cat_test.c
>> index 2d2f69d3e5b7..ad5ebce65c07 100644
>> --- a/tools/testing/selftests/resctrl/cat_test.c
>> +++ b/tools/testing/selftests/resctrl/cat_test.c
>> @@ -128,7 +128,7 @@ static int check_results(struct resctrl_val_param *param, const char *cache_type
>>  	return fail;
>>  }
>>  
>> -void cat_test_cleanup(void)
>> +static void cat_test_cleanup(void)
>>  {
>>  	remove(RESULT_FILE_NAME);
>>  }
>> @@ -289,8 +289,6 @@ static int cat_run_test(const struct resctrl_test *test, const struct user_param
>>  	ret = check_results(&param, test->resource,
>>  			    cache_total_size, full_cache_mask, start_mask);
>>  out:
>> -	cat_test_cleanup();
>> -
>
>Any goto out can now become return ret; and the out label be then removed.

Right, thanks, I'll clean these up.

>
>
>-- 
> i.
>

-- 
Kind regards
Maciej Wiecz?r-Retman