Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1755488rdb; Tue, 20 Feb 2024 06:12:54 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU4ifPLvGxcidPdzQTnDtxPpTPIbECKmqGZG6zI5banQsndEnS+3ONJxE6bL137CBN82wEf9m1ToZwSfPq/J1BrrRciyD02PInLKEqfZw== X-Google-Smtp-Source: AGHT+IEM8zVUehI79XeFh+fZYRXa2FCEbuE2+AdrAg/xWfsH7EgSCykYtH8D7z7Q9giW8WlhFSjS X-Received: by 2002:aa7:dcce:0:b0:564:db11:7e4b with SMTP id w14-20020aa7dcce000000b00564db117e4bmr676430edu.14.1708438374105; Tue, 20 Feb 2024 06:12:54 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708438374; cv=pass; d=google.com; s=arc-20160816; b=ZVG3c3cxbzdF5nHCpqM9Fs+Hrk7wn7PC7LdcQGUF5ipB5i071jSrOlewMq2dF8BoKP XtKl5J4rTDnzUzGRyBUQR0qzzLqd2ryRiSXRyItD14WJ8tN/bwHMJLZqH1d84u31pTeg UGzZDxe2QOBM6ITZao5VMRzeB8hg3JcFkyVgNtSHTN4Yqg+YfX1m7tOaHXUQ1RkUg++L pKxTQiSVgdMWfeKwihcuAYKJ9ErZuB075kfyZefd6dkBiJHjokWe0sVWcdjnxKk6it/D H90A7Mhc5YFfeg/zq+s07f5D6aAzgsX2dLX467SvcCYqR11qgIt4eYfmuHJHd+T509au kSsg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=VlCI9F854lrsWDUIN6PG7zZ3hJeSzAbz00+8LmilWc8=; fh=/pgydRB5MDpiH59DY2BuiK/I/qctWQRV9MFPcZwiNfA=; b=QKxeb4PPUG3oRFXdIFaOS4SsuOw6H/pLXz60ba4kUVM8WDjq7XztBEzAPktIOcy/IO 6c2b+YXkYdWdTfZT6Zk9TsB+JBfec5Uudk30jbtdtvSQGJyz+2bFYHftIJgE/5QxVTwA UWM1BKKH76FWq8BoRNBgcfpxnSaLKqsj/1G4ZlqwZunPmFd7erWY/tlYhKWVp6pQpDn4 67FudwGCfRFg8FWG+Y4J1JQXIWxgdBdgKAQ6GENu2RfQa79ivUEX6sDcTMFW1aL5yVGu x/+KZOmbjn9R97bH72iE+hSfVJvldkZJB+KBqLHaYAlYnpXoxW1penUcrFQmtwCm9VKd zk4w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jwGeAk+R; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-73160-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-73160-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id dh6-20020a0564021d2600b00563a27fe507si3384110edb.609.2024.02.20.06.12.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 06:12:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-73160-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jwGeAk+R; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-73160-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-73160-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id D50961F21307 for ; Tue, 20 Feb 2024 14:12:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6C6876A8A5; Tue, 20 Feb 2024 14:12:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jwGeAk+R" Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 073976A352 for ; Tue, 20 Feb 2024 14:12:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708438335; cv=none; b=PBzEOgtMz0yIPGOl6wBvXSFHoXd/9CV4qmW/sPE2OBZACSmaP5RwpVCwxOSc2gxriTMq/m7HQbAn119LpyQFHCMTziDQYuJ71YmpbLyJk/RvQSK8L302DUClDwnMR/LAHQTIwMinGC6eDC6ACk2oKAsWHReAwrwebPrJwOZzAJA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708438335; c=relaxed/simple; bh=ZUd/4SIGCstdqfJUTd63+Gsgaaki8fxiSzh0mr3PVCU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Gsqh7jNJASbfBfyeXQ/RVY3XS91FLVee9/WwAssW0ygbCLbk86Wni21ZVE1DRWTn3xso+tlzTquLL3XEMbEsL9GCbuXHv0BTgUa1QJGa96nTZl3RjMv6B4EqxTK0b6vQ8qkVV8v5my+IUdyoa9x+DOF8dq2c9nAytWGtNDOZYk0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=jwGeAk+R; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-33d153254b7so2634316f8f.0 for ; Tue, 20 Feb 2024 06:12:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708438332; x=1709043132; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VlCI9F854lrsWDUIN6PG7zZ3hJeSzAbz00+8LmilWc8=; b=jwGeAk+R6VThW+JUlY4uPM1hbUFeOFHIh7TvNpyFy8lqUbVkMmMSUZO+mies2RHt8S DMQIo0B7bwaXIxYNYV66GyXKgq6tKRjMSAt87kA/IstD/uW8sxlz3I/+D8GRstrYaHap ReGFQhe+o49yE8gcedT1MZIovD2u7U9aODQZ60x3OS+B13BTcBm+g1G+C0N7+GYvbwv9 909FFIGpJJptV230JtxKxaLcWuhLSLlUowxFIjvv9YD71qcp3ipAF1dNqaxOPBsK2GC4 VUmKNrSNddMrBuKNX9UIZtPTajQFSz6X0AzdrTNo2XCQgplAJ2frDxP0OyEW9uHAJA9q wc5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708438332; x=1709043132; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VlCI9F854lrsWDUIN6PG7zZ3hJeSzAbz00+8LmilWc8=; b=gQNI5sW+6xd7Qw1w+Frfub7+P0VYlFckPfaFhmQTz+rwwRzJ6kQkEtI35HgQJ3vCwO /VDlAf9mkaHlbTb1GVALmXsZvBFRjvoAwdocKgKxMDFfga3bQq9IUYxr35GA/izKeIwW FEZdUwCATrQExyJVzqgZSRNvq3ym4JNP2/ZNYYlFLwax00r6tZGR+MCcilBJv6PKXcTs oclmO5M5k1KBK4avEVh8+r7Wpreu8TjIiFQCNlulPoUHbkAYAHjL+S8hlAa0MBomUZxM bPrvGRpgpAyKBjW4sEXqiHLrZ31VDK7unw1xYXwY0uUrtYq925O/W6uTa4Xeqf/73FYn d0SQ== X-Forwarded-Encrypted: i=1; AJvYcCVYfcW2y0F3groitpTzX6sCmzNHgiLKQSJ9eGsA+j4IGfX6drzb9Z3x/VwBMVECorPD3b4shxD00lLc3LRAZthnr5vr6kVQy6s7COUK X-Gm-Message-State: AOJu0Yzc8Lg6Tp2l8fj0DygtcStdKuhUYApJz6hssNo7T54JJrGJE7YZ uyJW83vN0laJbeye/Jb8yhNAJ2egTyxaeHo6vkdyetFs0LLmMK9SNPSCcaK6Mo8= X-Received: by 2002:adf:ec44:0:b0:33d:3ceb:5308 with SMTP id w4-20020adfec44000000b0033d3ceb5308mr4607368wrn.42.1708438332431; Tue, 20 Feb 2024 06:12:12 -0800 (PST) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id bq5-20020a5d5a05000000b0033d60ab6bc8sm4662665wrb.50.2024.02.20.06.12.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 06:12:12 -0800 (PST) Date: Tue, 20 Feb 2024 14:12:10 +0000 From: Daniel Thompson To: Luca Weiss Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Lee Jones , Jingoo Han , Helge Deller , Andrew Morton , "G.Shark Jeong" , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maximilian Weigand , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 4/4] ARM: dts: qcom: msm8974-hammerhead: Hook up backlight Message-ID: <20240220141210.GG6716@aspen.lan> References: <20240220-lm3630a-fixups-v1-0-9ca62f7e4a33@z3ntu.xyz> <20240220-lm3630a-fixups-v1-4-9ca62f7e4a33@z3ntu.xyz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240220-lm3630a-fixups-v1-4-9ca62f7e4a33@z3ntu.xyz> On Tue, Feb 20, 2024 at 12:11:22AM +0100, Luca Weiss wrote: > Connect the panel with the backlight nodes so that the backlight can be > turned off when the display is blanked. > > Signed-off-by: Luca Weiss Reviewed-by: Daniel Thompson > --- > arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts b/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts > index 4aaae8537a3f..8eaa5b162815 100644 > --- a/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts > +++ b/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts > @@ -182,7 +182,7 @@ &blsp2_i2c5 { > status = "okay"; > clock-frequency = <355000>; > > - led-controller@38 { > + backlight: led-controller@38 { Again... a minor nit regarding existing problems but this node doesn't follow the generic naming recommendations: https://devicetree-specification.readthedocs.io/en/stable/devicetree-basics.html#generic-names-recommendation Daniel.