Received-SPF: pass (google.com: domain of linux-kernel+bounces-73156-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240208144224.438146-1-r.smirnov@omp.ru> <5abcb44deb604258aff4cd02c3ca90a3@omp.ru>
In-Reply-To: <5abcb44deb604258aff4cd02c3ca90a3@omp.ru>
From: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Date: Tue, 20 Feb 2024 23:09:30 +0900
Message-ID: <CAKFNMomWkZeK+CzX6R0S+9UB0tCN2WBd9A0iiUcqJcji+LFsvg@mail.gmail.com>
Subject: Re: [PATCH 5.10/5.15/6.1 0/1] nilfs2: fix WARNING in nilfs_dat_prepare_end()
To: "stable@vger.kernel.org" <stable@vger.kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Roman Smirnov <r.smirnov@omp.ru>, 
	"linux-nilfs@vger.kernel.org" <linux-nilfs@vger.kernel.org>, 
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Alexey Khoroshilov <khoroshilov@ispras.ru>, 
	"lvc-project@linuxtesting.org" <lvc-project@linuxtesting.org>, Sergey Shtylyov <s.shtylyov@omp.ru>, 
	Karina Yankevich <k.yankevich@omp.ru>, Andrey Rusalin <a.rusalin@omp.ru>, Sergey Yudin <s.yudin@omp.ru>, 
	Valentin Perevozchikov <v.perevozchikov@omp.ru>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 20, 2024 at 5:44=E2=80=AFPM Roman Smirnov wrote:
>
> On Thu, 8 Feb 2024 17:42:41 +0300, Roman Smirnov wrote:
> > Syzkaller reports WARNING in nilfs_dat_prepare_end() in 5.10, 5.15 and =
6.1
> > stable releases. The problem has been fixed in upstream:
> > https://syzkaller.appspot.com/bug?extid=3D5d5d25f90f195a3cfcb4
> >
> > The problem can also be fixed in versions 5.10, 5.15 and 6.1 by the
> > following patch.
> >
> > Found by Linux Verification Center (linuxtesting.org) with Syzkaller.
> >
> > Link: https://syzkaller.appspot.com/bug?extid=3D325e6b0a1e7cf9035cc0
> > Link: https://syzkaller.appspot.com/bug?extid=3Dbebf30d67ea2569f0fd3
> >
> > Ryusuke Konishi (1):
> >  nilfs2: replace WARN_ONs for invalid DAT metadata block requests
> >
> >  fs/nilfs2/dat.c | 27 +++++++++++++++++----------
> >  1 file changed, 17 insertions(+), 10 deletions(-)
>
> Sorry to bother you, do you have any comments on the patch?

Hi Greg,

As a side note, this commit handles certain metadata corruptions
better if they are detected, rather than just killing WARN_ONs, and
prevents an internal error code (ENOENT) from propagating
inappropriately to userland.

So, in retrospect, I think it was worth backporting to stable trees.

I have checked the source code of each of the target stable trees, and
they are safe to apply.

Thanks,
Ryusuke Konishi