Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1774964rdb; Tue, 20 Feb 2024 06:45:37 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU6iBS9Mb03npKECm2f5F6d/yzoDn6J5nD4Re/DDY5S8pWggNdKg154MY16aNme/eZt8vWn7VpgSPNXau3wyu/U+VfewDy6qaiyg0ekDw== X-Google-Smtp-Source: AGHT+IH78Xi+g/6Pgh866OgJEIfxWudqdI2W4NzKUn+GljemGLi9RSLtcnjl5CEG1y4ZgW0lX4Rk X-Received: by 2002:a17:906:f293:b0:a3e:422d:a371 with SMTP id gu19-20020a170906f29300b00a3e422da371mr5580694ejb.37.1708440337652; Tue, 20 Feb 2024 06:45:37 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708440337; cv=pass; d=google.com; s=arc-20160816; b=CwGJ/o+HjPd6Peg8wYpoMU6AlCucK2k9g/sWcJkdrykVuF2gtGcjPxrjwLwQmbmP12 +TZifD0pgMKrGuj9cIDnTtUxTwUsiWs3k4Yk8hMKvcesOXEVixXsBvkoezMFbqDs+2Ky QiMmJLspp6vG4rvXRu5HeeDBOyya7ZpfX6hXYyv+e8vB9oes3BinMyAfUnsw4nsXK1hX dLzkLoXtwuYsw2aZjpIZNYSjkArZt+KmMvw6Unj1rc5NDFQceH/5YUAXEDPaABo7WlPb neP6cqn6vJNVxoP7o4B+QpWc5paLW0r3AO+BQIcX5dZdPEKrdpo4Y9QqHlusgnXC4t2K T6HA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=zfldrZzT5rYLjsaVPisGJB5OtCgQ4dz4zxtJzhM67DU=; fh=TCAt/R3HdXm5/548d62ObWzS/Jx3jcOKiUqrsB3bV+g=; b=dQ7uCtkWfux/UtNro61fcVHr13QrdRXQ+54IgGI+GUTgrw5qmVUH2S7hTAtc0Uz6wb 8AmBMizKBxvOM6FuV0aZ++QPL/6Q0t94hAm6lKv7TQKJcbd2kSrGAQ6hdppFAZkLEtAq czJMpkYcI0B8IBaqaPbySfsHL36MzX3OmvSK7MyIRQqv236lscNmuigwp0v752Qu62yY VadIjieFVwxTBrgs+W6EnJRGLU6CGNHf51gtT0kMrXUpg0qtINHQjudC+9skx5wvsmHI cSdzrcRXxJ2XHakzjfxxoz9sYMkvK7OM4yX6ATFLO4qAZFGMry+FOlsjwJ5+4/y1KvQD lbZg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b="Z/GpseWU"; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-73190-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-73190-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id md9-20020a170906ae8900b00a3ed20f7ddcsi1250632ejb.782.2024.02.20.06.45.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 06:45:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-73190-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b="Z/GpseWU"; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-73190-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-73190-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 37A611F25041 for ; Tue, 20 Feb 2024 14:45:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 991076D1D3; Tue, 20 Feb 2024 14:45:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="Z/GpseWU" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 168362C6AA; Tue, 20 Feb 2024 14:45:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708440324; cv=none; b=f90akbaP158s2BJD9Jy/7bbowh0K03U9o4mB82Kxuzt68ASf6eplSsXpiGzkC2J+YqAdHxdbUwKgwgQ1TYWnuKZQWwo1sRQ0kWNo2mCp9iXyezuXcVdauzbTjS3Zx9hcwyjHxPSc/xnxtfhdnrmv2NONhU58J/6bRggmAeb35nI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708440324; c=relaxed/simple; bh=9OuL8BYQcUg2azVMZYx+EOilMab+eq2qmK5iOEnFmb8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F1tMVqg64gsEKb917+xVdCkCeGewe9bb2Ei31cfjfhzrUzqY865xtVaZywf/JRjYa+y+7ZPyhUqLUP1f8odXRbTh9kBOe6LuA3nSPd8k+6AhhWSlBGz1oSwxsFz5DHIt8tGHTdL2CMg0ORA7Tn2wzX4eWAcMepCY4cxKtmTsSfU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=Z/GpseWU; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=zfldrZzT5rYLjsaVPisGJB5OtCgQ4dz4zxtJzhM67DU=; b=Z/GpseWUybd0CL/+h9GRJnkeHV bPjCC1+KlPq/kicfwPpx92uuiaaam8wCG28OzXBtIKSGUkuxr/tGEajFDSk/abmgCx+fIFDq6chQ0 BzsHOQ/r/t8FITaNIta+aHvW2EKnnvlfmNOqaIKhx1QHz2lzUng4v0oFd2n85Pfk/RyM=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rcRNA-008I4I-2Y; Tue, 20 Feb 2024 15:45:28 +0100 Date: Tue, 20 Feb 2024 15:45:28 +0100 From: Andrew Lunn To: Simon Horman Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ariel Elior , Manish Chopra , Jesse Brandeburg , Tony Nguyen , linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org Subject: Re: [PATCH net-next v4 3/9] net: qlogic: qede: Use linkmode helpers for EEE Message-ID: References: <20240218-keee-u32-cleanup-v4-0-71f13b7c3e60@lunn.ch> <20240218-keee-u32-cleanup-v4-3-71f13b7c3e60@lunn.ch> <20240220124405.GB40273@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240220124405.GB40273@kernel.org> > > + unsupp = linkmode_andnot(tmp, edata->advertised, supported); > > nit: Given the types involved, I might have written this as: > > unsupp = !!linkmode_andnot(tmp, edata->advertised, supported); linkmode_andnot() calls bitmap_andnot(): static inline bool bitmap_andnot(unsigned long *dst, const unsigned long *src1, const unsigned long *src2, unsigned int nbits) It already returns a bool, so there is no need to force an int to bool conversion using !!. Andrew