Received-SPF: pass (google.com: domain of linux-kernel+bounces-73191-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 20 Feb 2024 15:47:14 +0100
From: Andrew Lunn <andrew@lunn.ch>
To: Simon Horman <horms@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Ariel Elior <aelior@marvell.com>,
	Manish Chopra <manishc@marvell.com>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>, linux-usb@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	intel-wired-lan@lists.osuosl.org
Subject: Re: [PATCH net-next v4 4/9] net: ethernet: ixgbe: Convert EEE to use
 linkmodes
Message-ID: <610e70a3-eb3e-4a64-87c8-d03a17332dcb@lunn.ch>
References: <20240218-keee-u32-cleanup-v4-0-71f13b7c3e60@lunn.ch>
 <20240218-keee-u32-cleanup-v4-4-71f13b7c3e60@lunn.ch>
 <20240220120643.GZ40273@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240220120643.GZ40273@kernel.org>

On Tue, Feb 20, 2024 at 12:06:43PM +0000, Simon Horman wrote:
> On Sun, Feb 18, 2024 at 11:07:01AM -0600, Andrew Lunn wrote:
> > Convert the tables to make use of ETHTOOL link mode bits, rather than
> > the old u32 SUPPORTED speeds. Make use of the linkmode helps to set
> > bits and compare linkmodes. As a result, the _u32 members of keee are
> > no longer used, a step towards removing them.
> > 
> > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> > ---
> >  drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 48 ++++++++++++------------
> >  1 file changed, 25 insertions(+), 23 deletions(-)
> > 
> > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
> 
> ...
> 
> > @@ -3436,28 +3437,29 @@ ixgbe_get_eee_fw(struct ixgbe_adapter *adapter, struct ethtool_keee *edata)
> >  	if (rc)
> >  		return rc;
> >  
> > -	edata->lp_advertised_u32 = 0;
> >  	for (i = 0; i < ARRAY_SIZE(ixgbe_lp_map); ++i) {
> >  		if (info[0] & ixgbe_lp_map[i].lp_advertised)
> > -			edata->lp_advertised_u32 |= ixgbe_lp_map[i].mac_speed;
> > +			linkmode_set_bit(ixgbe_lp_map[i].link_mode,
> > +					 edata->lp_advertised);
> >  	}
> >  
> > -	edata->supported_u32 = 0;
> >  	for (i = 0; i < ARRAY_SIZE(ixgbe_ls_map); ++i) {
> >  		if (hw->phy.eee_speeds_supported & ixgbe_ls_map[i].mac_speed)
> > -			edata->supported_u32 |= ixgbe_ls_map[i].supported;
> > +			linkmode_set_bit(ixgbe_lp_map[i].link_mode,
> > +					 edata->lp_advertised);
> 
> Hi Andrew,
> 
> should this be edata->supported rather than edata->lp_advertised?

Correct :-(

	Andrew