Received-SPF: pass (google.com: domain of linux-kernel+bounces-73196-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <168765ff-98ea-42a1-82f7-56178bfcf7ec@efficios.com>
Date: Tue, 20 Feb 2024 09:50:13 -0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3] ring-buffer: Simplify reservation with try_cmpxchg()
 loop
Content-Language: en-US
To: Steven Rostedt <rostedt@goodmis.org>, LKML
 <linux-kernel@vger.kernel.org>,
 Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>
References: <20240219182032.2605d0a3@gandalf.local.home>
 <20240220091922.45848d9a@gandalf.local.home>
From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
In-Reply-To: <20240220091922.45848d9a@gandalf.local.home>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 2024-02-20 09:19, Steven Rostedt wrote:
> On Mon, 19 Feb 2024 18:20:32 -0500
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
>> Instead of using local_add_return() to reserve the ring buffer data,
>> Mathieu Desnoyers suggested using local_cmpxchg(). This would simplify the
>> reservation with the time keeping code.
>>
>> Although, it does not get rid of the double time stamps (before_stamp and
>> write_stamp), using cmpxchg() does get rid of the more complex case when
>> an interrupting event occurs between getting the timestamps and reserving
>> the data, as when that happens, it just tries again instead of dealing
>> with it.
>>
>> Before we had:
>>
>> 	w = local_read(&tail_page->write);
>> 	/* get time stamps */
>> 	write = local_add_return(length, &tail_page->write);
>> 	if (write - length == w) {
>> 		/* do simple case */
>> 	} else {
>> 		/* do complex case */
>> 	}
>>
>> By switching the local_add_return() to a local_try_cmpxchg() it can now be:
>>
>> 	 w = local_read(&tail_page->write);
>>   again:
>> 	/* get time stamps */
>> 	if (!local_try_cmpxchg(&tail_page->write, &w, w + length))
>> 		goto again;
>>
>> 	 /* do simple case */
> 
> Something about this logic is causing __rb_next_reserve() to sometimes
> always return -EAGAIN and triggering the:
> 
>      RB_WARN_ON(cpu_buffer, ++nr_loops > 1000)
> 
> Which disables the ring buffer.
> 
> I'm not sure what it is, but until I do, I'm removing the patch from my
> queue.

Try resetting the info->add_timestamp flags to add_ts_default on goto again
within __rb_reserve_next().

Thanks,

Mathieu


-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com