Received-SPF: pass (google.com: domain of linux-kernel+bounces-73231-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240220012540.10607-1-zhi.mao@mediatek.com> <20240220012540.10607-3-zhi.mao@mediatek.com>
In-Reply-To: <20240220012540.10607-3-zhi.mao@mediatek.com>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Tue, 20 Feb 2024 17:19:14 +0200
Message-ID: <CAHp75Vfbc0jE43Z-trFRnFdT5SxvJN+w2x7hS4vHuF5M2kTXgg@mail.gmail.com>
Subject: Re: [PATCH v5 2/2] media: i2c: Add GC08A3 image sensor driver
To: Zhi Mao <zhi.mao@mediatek.com>
Cc: mchehab@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, 
	sakari.ailus@linux.intel.com, laurent.pinchart@ideasonboard.com, 
	shengnan.wang@mediatek.com, yaya.chang@mediatek.com, 10572168@qq.com, 
	Project_Global_Chrome_Upstream_Group@mediatek.com, yunkec@chromium.org, 
	conor+dt@kernel.org, matthias.bgg@gmail.com, 
	angelogioacchino.delregno@collabora.com, jacopo.mondi@ideasonboard.com, 
	hverkuil-cisco@xs4all.nl, heiko@sntech.de, jernej.skrabec@gmail.com, 
	macromorgan@hotmail.com, linus.walleij@linaro.org, hdegoede@redhat.com, 
	tomi.valkeinen@ideasonboard.com, gerald.loacker@wolfvision.net, 
	bingbu.cao@intel.com, dan.scally@ideasonboard.com, 
	linux-media@vger.kernel.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, 
	linux-mediatek@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 20, 2024 at 3:47=E2=80=AFAM Zhi Mao <zhi.mao@mediatek.com> wrot=
e:
>
> Add a V4L2 sub-device driver for Galaxycore GC08A3 image sensor.

..

> +#include <asm/unaligned.h>

Usually asm/* go after linux/*

> +#include <linux/clk.h>
> +#include <linux/delay.h>
> +#include <linux/gpio/consumer.h>
> +#include <linux/i2c.h>
> +#include <linux/module.h>
> +#include <linux/pm_runtime.h>
> +#include <linux/regulator/consumer.h>

This looks semi-random.
For example, _at least_ the array_size.h, bits.h, container_of.h,
device.h, err.h, mod_devicetable.h, property.h, types.h are missing,
Please, use IWYU principle.

..

> +#define GC08A3_DEFAULT_CLK_FREQ 24000000

HZ_PER_MHZ ?

..

> +#define GC08A3_SLEEP_US  2000

USEC_PER_MSEC ?

..

> +static const s64 gc08a3_link_freq_menu_items[] =3D {
> +       336000000ULL,
> +       207000000ULL,

HZ_PER_MHZ ?

> +};

..

> +static const struct dev_pm_ops gc08a3_pm_ops =3D {
> +       SET_RUNTIME_PM_OPS(gc08a3_power_off, gc08a3_power_on, NULL)
> +};

> +               .pm =3D &gc08a3_pm_ops,

Use new PM macros (pm_ptr() and friends).

--=20
With Best Regards,
Andy Shevchenko