Received-SPF: pass (google.com: domain of linux-kernel+bounces-73239-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Zi Yan <ziy@nvidia.com>
To: David Hildenbrand <david@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
 "\"Huang, Ying\"" <ying.huang@intel.com>,
 Ryan Roberts <ryan.roberts@arm.com>,
 Andrew Morton <akpm@linux-foundation.org>,
 "\"Matthew Wilcox (Oracle)\"" <willy@infradead.org>,
 "\"Yin, Fengwei\"" <fengwei.yin@intel.com>, Yu Zhao <yuzhao@google.com>,
 Vlastimil Babka <vbabka@suse.cz>,
 "\"Kirill A . Shutemov\"" <kirill.shutemov@linux.intel.com>,
 Johannes Weiner <hannes@cmpxchg.org>,
 Baolin Wang <baolin.wang@linux.alibaba.com>,
 Kemeng Shi <shikemeng@huaweicloud.com>,
 Mel Gorman <mgorman@techsingularity.net>,
 Rohan Puri <rohan.puri15@gmail.com>, Mcgrof Chamberlain <mcgrof@kernel.org>,
 Adam Manzanares <a.manzanares@samsung.com>,
 "\"Vishal Moola (Oracle)\"" <vishal.moola@gmail.com>
Subject: Re: [PATCH v6 2/4] mm/compaction: enable compacting >0 order folios.
Date: Tue, 20 Feb 2024 10:27:50 -0500
Message-ID: <F159EA3F-FAA0-4DA2-90E3-7285A8D9AAD1@nvidia.com>
In-Reply-To: <7ca085eb-baa5-4085-a2b9-7402bb3fd9e9@redhat.com>
References: <20240216170432.1268753-1-zi.yan@sent.com>
 <20240216170432.1268753-3-zi.yan@sent.com>
 <416d1450-6480-4113-b778-689a8f1d4e42@redhat.com>
 <7ca085eb-baa5-4085-a2b9-7402bb3fd9e9@redhat.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_2BD89ECB-66B1-4C62-AAE2-A443E05E3395_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?/IakvAesqVPAE5SzAeuV5GqrcXT1n7AmuN01ZJ4vHFNIpJUI6+yeOcGfZ9Jd?=
 =?us-ascii?Q?jnEmSP4bEE85CGfbHdfEsDCjga6za2+Qla9SOeie6u9vxsSJagpdEVz82CPB?=
 =?us-ascii?Q?tnhYj35oiIaVMcXmiLKlbPtvHQvJT1i3GkmWEtkcYN0fD4ch+2+UKjrfjBWa?=
 =?us-ascii?Q?g4vj1hoSKJsz8fhr03nVAlWB1XYkaUcRamY0tFGdcKmElPN2VCzah3TKjCeP?=
 =?us-ascii?Q?8Co5A+fYDkMXu3YK/hsHWCZh0UIOQjGx1j+s+2741TaJa4zU6WF/Y/4trLoy?=
 =?us-ascii?Q?nqeeE6z2j9MCWIhcW+INb4FbdfqgoOVpcidumr1MgqTfZsWldD7lGMl4bU81?=
 =?us-ascii?Q?JhT/lPCqUOylvwnrNKzJSw0VpG/EiFCja46kU0TFGW8GB6+zZhWcJ5dAXdMr?=
 =?us-ascii?Q?wYsPjPBkcYZEZCm1Ofu9dPnFwx9/qzXKqmUpJ2Hw7MdANtwpAq4kb54z6FLz?=
 =?us-ascii?Q?el64fdyL2/xyqesNHotB0WLfz1eQyeIcp2N1aRHQBu877bB/J3bbxzoJ2VLl?=
 =?us-ascii?Q?wlQ8gdS5k5eLrH141Ac8FLiPJpIUUBlpUlTf7IHUfsTBJrwfa5WukETQ0nAo?=
 =?us-ascii?Q?B0Y65mceHFmVUx5++0qbTXV3g652kx9+BMoBH1LXUdKsFl/gEtyhjxr7MJMX?=
 =?us-ascii?Q?4alBwGMUUVFOktBb98e7jNsv79Duya8GHnAd60YP3K/GZxVoG0p5zgh0fQAR?=
 =?us-ascii?Q?wOhMPfPWAQ/J1Kjc3yhqFxeSTk35F1XIuzW1NHabRfB88oj6xmk/CGucHC36?=
 =?us-ascii?Q?Ap0MAIP7TolcXTWN7UqhAvO/F+2N+95rSwGMPToXSRmt/4ZgppT3fY9xpXoe?=
 =?us-ascii?Q?s1WM9pcXasrA9axfNU73AY+3TwkwSZ4msWxgouJChbRw89Q9L0JTvbcs8i74?=
 =?us-ascii?Q?G3zwkCwq0OuofLBcVf4R9/7m6GkRZvOvLOCOlY6bhPH4ctKGmuIkMT0+QxrN?=
 =?us-ascii?Q?Oo2xp57fLstTonDVZHeX+h+Wcts+ibHsnkYE0F8f2yvgk6hHohe/MPRLrJpo?=
 =?us-ascii?Q?e00BOLIlO4OtjIEcgLRF1NnkrMvDIhrjr8eA4YCkrTmXBXbEkN3ruMjjvXbE?=
 =?us-ascii?Q?hh5vLZyFgYRtMlBIE+bgpiL4k179CsLotXKjfs1QddITpeVqe6+q2fR5+nK0?=
 =?us-ascii?Q?4EeIcoSeiNPie/iyG8RsoUwxlsu3tjCkcSm8bPpVhGFWFTiOevQaIrj2BD2X?=
 =?us-ascii?Q?dcXerl8A9qlQGps7PdP/Te8E9x90KrGH74sRbV6rGpYQUbVQk9BnY1zh6YP+?=
 =?us-ascii?Q?jR4NTvnKFTlWjEJtj2eX861FhNzLm36lW9v4yA1CmK2fx8MWarll0tKtaSJ7?=
 =?us-ascii?Q?tzs0VKuBZfVZmoyXUflYSvD4Oxw4ttt65W18SiDbDY202k+JiGWu+meVaoPK?=
 =?us-ascii?Q?Q1JpZ28DTGphXu4N1yP2Y8j6AI01rUQg06ecg6XYPtTpK95mCM6WxtJAqeB/?=
 =?us-ascii?Q?TVTOxQYcAoHd+tcgue+jVK/N9RB1/9vN/J5gBwtQdLYT5MwKXBkNwij9y13y?=
 =?us-ascii?Q?+0CUilUIgtUMkNDYd2W9y91MfDZ9u2zagpQ4ciGfoy9JtREehbiVX2A3c0cG?=
 =?us-ascii?Q?o+Abh1zEBxsFKhAB5F2+4tA1x3cLJ2gVVk8zGvfT?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f4806364-6037-4685-c2a4-08dc322880e7
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 15:27:52.3823
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GDNd74pDShCSvmjICo4/orZFAzJS0tLvfmpf3n54HrAMffb/5++Zi5uqPbJbxZq0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5058

--=_MailMate_2BD89ECB-66B1-4C62-AAE2-A443E05E3395_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On 20 Feb 2024, at 4:11, David Hildenbrand wrote:

> On 20.02.24 10:03, David Hildenbrand wrote:
>> On 16.02.24 18:04, Zi Yan wrote:
>>> From: Zi Yan <ziy@nvidia.com>
>>>
>>> migrate_pages() supports >0 order folio migration and during compacti=
on,
>>> even if compaction_alloc() cannot provide >0 order free pages,
>>> migrate_pages() can split the source page and try to migrate the base=

>>> pages from the split.  It can be a baseline and start point for addin=
g
>>> support for compacting >0 order folios.
>>>
>>> Signed-off-by: Zi Yan <ziy@nvidia.com>
>>> Suggested-by: Huang Ying <ying.huang@intel.com>
>>> Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
>>> Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
>>> Tested-by: Baolin Wang <baolin.wang@linux.alibaba.com>
>>> Tested-by: Yu Zhao <yuzhao@google.com>
>>> Cc: Adam Manzanares <a.manzanares@samsung.com>
>>> Cc: David Hildenbrand <david@redhat.com>
>>> Cc: Johannes Weiner <hannes@cmpxchg.org>
>>> Cc: Kemeng Shi <shikemeng@huaweicloud.com>
>>> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>>> Cc: Luis Chamberlain <mcgrof@kernel.org>
>>> Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
>>> Cc: Mel Gorman <mgorman@techsingularity.net>
>>> Cc: Ryan Roberts <ryan.roberts@arm.com>
>>> Cc: Vishal Moola (Oracle) <vishal.moola@gmail.com>
>>> Cc: Vlastimil Babka <vbabka@suse.cz>
>>> Cc: Yin Fengwei <fengwei.yin@intel.com>
>>> ---
>>>    mm/compaction.c | 66 ++++++++++++++++++++++++++++++++++++++-------=
----
>>>    1 file changed, 52 insertions(+), 14 deletions(-)
>>>
>>> diff --git a/mm/compaction.c b/mm/compaction.c
>>> index cc801ce099b4..aa6aad805c4d 100644
>>> --- a/mm/compaction.c
>>> +++ b/mm/compaction.c
>>> @@ -816,6 +816,21 @@ static bool too_many_isolated(struct compact_con=
trol *cc)
>>>    	return too_many;
>>>    }
>>>   +/*
>>
>>
>> Can't you add these comments to the respective checks? Like
>>
>> static bool skip_isolation_on_order(int order, int target_order)
>> {
>> 	/*
>> 	 * Unless we are performing global compaction (targert_order <
>> 	 * 0), skip any folios that are larger than the target order: we
>> 	 * wouldn't be here if we'd have a free folio with the desired
>> 	 * target_order, so migrating this folio would likely fail
>> 	 * later.
>> 	 */
>> 	if (target_order !=3D -1 && order >=3D target_order)
>> 		return true;
>
> I just stumbled over "is_via_compact_memory", likely that should be use=
d instead of the "!=3D -1 check.

Thanks. Let me use it.


--
Best Regards,
Yan, Zi

--=_MailMate_2BD89ECB-66B1-4C62-AAE2-A443E05E3395_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmXUxPYPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUiT4P/2TUM/WGnrEeqRAOlA9IFmJtNAlNzuPOyRuU
Zc/xrzCv9jPYQ5zsF2uWgFg3cNHeHUAPddeq+JD+Bmb/twG9havMsUx7dp57TwRj
ERDpL3cRBm8pZliU64srt5PScVNmrs86r9c7TQv2b3EgANALf/EuiGBE8ntGF/MH
00eW1rK9RVBlKcWqgEZ6ujSpsGdJislvbtHrqyAvx4+xrOJ1Rr7xZ3Sugfisq2BK
IfjWUR6x+yaoyvBeZTWvOZYbcTSCNHjhuNysfPAD0z63uJN8Z4gyBdbwqSvcJiDr
czpDkHbvf0biE24E47EjMBl5GW1bl9WnMLdKaJ3IVJ+lVf33JzOd2F363qPkWvjW
oOuSAczMrepEqhDtlpGKWl6dmuhdasENVZ5UeFbDmGMXnnV6xlrDdUbI0oIw9x4L
7PN3flRPGPuMF1YuJezdQWj2kXa//LG1WsSBDCgM//L7znqI97TkVf4UAMgKWFGC
RTiQjT8gJsh6d93E/YTTaX/UYKJ97jBuyMyt9R69r/655CP+tdzERKYNIOc+gkf2
JilC2e6x0AR0r04sfqtyEXxLL1/B3mPfISuB1AMFu/vFSHbv4NLP0W9o52+wqbLW
dpQhiQOUrdwxeMFgGKsjcx2FV6FVY4SZ7Bnk6XcJqGHWrcG3AsHRC47jK+QCS4ms
mDs458Ok
=/dOB
-----END PGP SIGNATURE-----

--=_MailMate_2BD89ECB-66B1-4C62-AAE2-A443E05E3395_=--